From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68849C46475 for ; Tue, 23 Oct 2018 06:23:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2831C2064C for ; Tue, 23 Oct 2018 06:23:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K0S9G8y1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2831C2064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727651AbeJWOpO (ORCPT ); Tue, 23 Oct 2018 10:45:14 -0400 Received: from mail-qk1-f181.google.com ([209.85.222.181]:39753 "EHLO mail-qk1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727118AbeJWOpO (ORCPT ); Tue, 23 Oct 2018 10:45:14 -0400 Received: by mail-qk1-f181.google.com with SMTP id e4so125257qkh.6 for ; Mon, 22 Oct 2018 23:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y74D9wcXF+MF7UYTa5cF/Lz2OMdtopJLGklBfwbLKjI=; b=K0S9G8y1eoUvmpU6qCJDDWUAL/3Rozmrxr79c3OEnIfZJk2CEvMdmKj9xI14OJTp9F YtCbSNJzW3/2OUCMrqumYAeQ7Ei2nL6qJ0yr5KMvPfwL80PSXAVoDN5GfILJr+YRB6xq TJA41USfcVYSRgr/ryEIqUqKgDk1qyjvZjTJ30yeu6uJ8EDxKaFpVMZoeCzzDKZyFVjy mjOoEsYG9bvk/BKnz/JNTMoWQFAmsXuKHgy1BkxEKZgeGA20mo0u/6ne5qybUoMSLiD4 FkbLaE+lqbZlt0LVHzf68OAhS380t46DEVAYsdEpHDORqcpBftx1WxjXnYi53h4twwQq yr8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y74D9wcXF+MF7UYTa5cF/Lz2OMdtopJLGklBfwbLKjI=; b=BMD6xFkvnfSUEjM3pril6Hl+KY5tIR6QDohDF9rxF7RL+fy/Spa7c0TkDRUa2Ouu3y miSmAZhYgz2g6wIkRcsaRPfzYFnJPhYS3fT3rd37RleqsCIH5Aly9LGw6GBnuYwBls+L vmJHTQ42W+Mae9bNn747P1yInnt7lpgYvUKK4Uz7YxDfpImvaE0VmjbuLSVetirfz71x Lh+qKanKla2jLPLOHYRPHa7NyYstqI6ljGIHn8uzaHRStPgCkSxa57N2PlDKJCLKSK9G fwxWBFHvaKXOhjLIL0n3TWZ7tEaG+JMqOpE1uE4jsDh64Qtc3Xb+TyJiXYhSQA5M9a2e Phrw== X-Gm-Message-State: ABuFfojaOoYeX36B5oK2P2oCEvOiXFpiEvUJVbv0aFYXmVjiVbA2JM3V OlPikAUAlfL743EpiXUVMh7gkThnaJwYJ+l1ZGT7cg== X-Google-Smtp-Source: ACcGV62uEQpn2Q/jdxiCGRNNBW2SSzHrA5ZHkIhtmn2Alm2gHYsmGH+i8RWnqeFURTJHLZNUYZs6tFVQa1C/ZCiHcBU= X-Received: by 2002:a37:3094:: with SMTP id w142-v6mr25906665qkw.131.1540275796490; Mon, 22 Oct 2018 23:23:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Airlie Date: Tue, 23 Oct 2018 16:23:03 +1000 Message-ID: Subject: Re: To: mtirado418@gmail.com Cc: LKML , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Oct 2018 at 16:13, Michael Tirado wrote: > > That preprocessor define worked but I'm still confused about this > DRM_FILE_PAGE_OFFSET thing. Check out drivers/gpu/drm/drm_gem.c > right above drm_gem_init. > > --- > > /* > * We make up offsets for buffer objects so we can recognize them at > * mmap time. > */ > > /* pgoff in mmap is an unsigned long, so we need to make sure that > * the faked up offset will fit > */ > > #if BITS_PER_LONG == 64 > #define DRM_FILE_PAGE_OFFSET_START ((0xFFFFFFFFUL >> PAGE_SHIFT) + 1) > #define DRM_FILE_PAGE_OFFSET_SIZE ((0xFFFFFFFFUL >> PAGE_SHIFT) * 16) > #else > #define DRM_FILE_PAGE_OFFSET_START ((0xFFFFFFFUL >> PAGE_SHIFT) + 1) > #define DRM_FILE_PAGE_OFFSET_SIZE ((0xFFFFFFFUL >> PAGE_SHIFT) * 16) > #endif > > > --- > > Why is having a 64-bit file offsets critical, causing -EINVAL on mmap? > What problems might be associated with using (0x10000000UL >> > PAGE_SHIFT) ? a) it finds people not using the correct userspace defines. mostly libdrm should handle this, and possibly mesa. b) there used to be legacy maps below that address on older drivers, so we decided to never put stuff in the first 32-bit range that they could clash with. Dave. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: Date: Tue, 23 Oct 2018 16:23:03 +1000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 87EC16E0AF for ; Tue, 23 Oct 2018 06:23:17 +0000 (UTC) Received: by mail-qk1-x72a.google.com with SMTP id q184-v6so131436qkd.3 for ; Mon, 22 Oct 2018 23:23:17 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: mtirado418@gmail.com Cc: LKML , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMyBPY3QgMjAxOCBhdCAxNjoxMywgTWljaGFlbCBUaXJhZG8gPG10aXJhZG80MThA Z21haWwuY29tPiB3cm90ZToKPgo+IFRoYXQgcHJlcHJvY2Vzc29yIGRlZmluZSB3b3JrZWQgYnV0 IEknbSBzdGlsbCBjb25mdXNlZCBhYm91dCB0aGlzCj4gRFJNX0ZJTEVfUEFHRV9PRkZTRVQgdGhp bmcuICBDaGVjayBvdXQgZHJpdmVycy9ncHUvZHJtL2RybV9nZW0uYwo+IHJpZ2h0IGFib3ZlIGRy bV9nZW1faW5pdC4KPgo+IC0tLQo+Cj4gLyoKPiAgKiBXZSBtYWtlIHVwIG9mZnNldHMgZm9yIGJ1 ZmZlciBvYmplY3RzIHNvIHdlIGNhbiByZWNvZ25pemUgdGhlbSBhdAo+ICAqIG1tYXAgdGltZS4K PiAgKi8KPgo+IC8qIHBnb2ZmIGluIG1tYXAgaXMgYW4gdW5zaWduZWQgbG9uZywgc28gd2UgbmVl ZCB0byBtYWtlIHN1cmUgdGhhdAo+ICAqIHRoZSBmYWtlZCB1cCBvZmZzZXQgd2lsbCBmaXQKPiAg Ki8KPgo+ICNpZiBCSVRTX1BFUl9MT05HID09IDY0Cj4gI2RlZmluZSBEUk1fRklMRV9QQUdFX09G RlNFVF9TVEFSVCAoKDB4RkZGRkZGRkZVTCA+PiBQQUdFX1NISUZUKSArIDEpCj4gI2RlZmluZSBE Uk1fRklMRV9QQUdFX09GRlNFVF9TSVpFICgoMHhGRkZGRkZGRlVMID4+IFBBR0VfU0hJRlQpICog MTYpCj4gI2Vsc2UKPiAjZGVmaW5lIERSTV9GSUxFX1BBR0VfT0ZGU0VUX1NUQVJUICgoMHhGRkZG RkZGVUwgPj4gUEFHRV9TSElGVCkgKyAxKQo+ICNkZWZpbmUgRFJNX0ZJTEVfUEFHRV9PRkZTRVRf U0laRSAoKDB4RkZGRkZGRlVMID4+IFBBR0VfU0hJRlQpICogMTYpCj4gI2VuZGlmCj4KPgo+IC0t LQo+Cj4gV2h5IGlzIGhhdmluZyBhIDY0LWJpdCBmaWxlIG9mZnNldHMgY3JpdGljYWwsIGNhdXNp bmcgLUVJTlZBTCBvbiBtbWFwPwo+IFdoYXQgcHJvYmxlbXMgbWlnaHQgYmUgYXNzb2NpYXRlZCB3 aXRoIHVzaW5nICgweDEwMDAwMDAwVUwgPj4KPiBQQUdFX1NISUZUKSA/CgphKSBpdCBmaW5kcyBw ZW9wbGUgbm90IHVzaW5nIHRoZSBjb3JyZWN0IHVzZXJzcGFjZSBkZWZpbmVzLiBtb3N0bHkKbGli ZHJtIHNob3VsZCBoYW5kbGUgdGhpcywKYW5kIHBvc3NpYmx5IG1lc2EuCgpiKSB0aGVyZSB1c2Vk IHRvIGJlIGxlZ2FjeSBtYXBzIGJlbG93IHRoYXQgYWRkcmVzcyBvbiBvbGRlciBkcml2ZXJzLApz byB3ZSBkZWNpZGVkIHRvIG5ldmVyIHB1dCBzdHVmZiBpbiB0aGUgZmlyc3QgMzItYml0IHJhbmdl IHRoYXQgdGhleQpjb3VsZCBjbGFzaCB3aXRoLgoKRGF2ZS4KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==