* Re: [PATCH] libradosstriper: correct the first parameter of rados_striper_trunc
[not found] <1517475365-7732-1-git-send-email-yuelongguang@gmail.com>
@ 2018-02-02 8:18 ` yue longguang
2018-02-02 19:20 ` Yehuda Sadeh-Weinraub
0 siblings, 1 reply; 3+ messages in thread
From: yue longguang @ 2018-02-02 8:18 UTC (permalink / raw
To: yehuda; +Cc: ceph-devel
yehuda, please review my patch. thanks
On Thu, Feb 1, 2018 at 4:56 PM, yuelongguang <yuelongguang@gmail.com> wrote:
> change the type of first parameter from rados_ioctx_t to rados_striper_t
> ---
> src/include/radosstriper/libradosstriper.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/include/radosstriper/libradosstriper.h b/src/include/radosstriper/libradosstriper.h
> index 5aa4a6b..4d552c6 100644
> --- a/src/include/radosstriper/libradosstriper.h
> +++ b/src/include/radosstriper/libradosstriper.h
> @@ -207,7 +207,8 @@ int rados_striper_remove(rados_striper_t striper,
> * @param size the new size of the object in bytes
> * @returns 0 on success, negative error code on failure
> */
> -int rados_striper_trunc(rados_ioctx_t io, const char *soid, uint64_t size);
> +int rados_striper_trunc(rados_striper_t striper,
> + const char *soid, uint64_t size);
>
> /** @} Synchronous I/O */
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libradosstriper: correct the first parameter of rados_striper_trunc
2018-02-02 8:18 ` [PATCH] libradosstriper: correct the first parameter of rados_striper_trunc yue longguang
@ 2018-02-02 19:20 ` Yehuda Sadeh-Weinraub
2018-02-05 4:39 ` yue longguang
0 siblings, 1 reply; 3+ messages in thread
From: Yehuda Sadeh-Weinraub @ 2018-02-02 19:20 UTC (permalink / raw
To: yue longguang; +Cc: ceph-devel
Can you create a pull request for it on github?
Yehuda
On Fri, Feb 2, 2018 at 12:18 AM, yue longguang <yuelongguang@gmail.com> wrote:
> yehuda, please review my patch. thanks
>
> On Thu, Feb 1, 2018 at 4:56 PM, yuelongguang <yuelongguang@gmail.com> wrote:
>> change the type of first parameter from rados_ioctx_t to rados_striper_t
>> ---
>> src/include/radosstriper/libradosstriper.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/include/radosstriper/libradosstriper.h b/src/include/radosstriper/libradosstriper.h
>> index 5aa4a6b..4d552c6 100644
>> --- a/src/include/radosstriper/libradosstriper.h
>> +++ b/src/include/radosstriper/libradosstriper.h
>> @@ -207,7 +207,8 @@ int rados_striper_remove(rados_striper_t striper,
>> * @param size the new size of the object in bytes
>> * @returns 0 on success, negative error code on failure
>> */
>> -int rados_striper_trunc(rados_ioctx_t io, const char *soid, uint64_t size);
>> +int rados_striper_trunc(rados_striper_t striper,
>> + const char *soid, uint64_t size);
>>
>> /** @} Synchronous I/O */
>>
>> --
>> 1.8.3.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libradosstriper: correct the first parameter of rados_striper_trunc
2018-02-02 19:20 ` Yehuda Sadeh-Weinraub
@ 2018-02-05 4:39 ` yue longguang
0 siblings, 0 replies; 3+ messages in thread
From: yue longguang @ 2018-02-05 4:39 UTC (permalink / raw
To: Yehuda Sadeh-Weinraub; +Cc: ceph-devel
it is done. please look at https://github.com/ceph/ceph/pull/20301
thanks
On Sat, Feb 3, 2018 at 3:20 AM, Yehuda Sadeh-Weinraub <yehuda@redhat.com> wrote:
> Can you create a pull request for it on github?
>
> Yehuda
>
> On Fri, Feb 2, 2018 at 12:18 AM, yue longguang <yuelongguang@gmail.com> wrote:
>> yehuda, please review my patch. thanks
>>
>> On Thu, Feb 1, 2018 at 4:56 PM, yuelongguang <yuelongguang@gmail.com> wrote:
>>> change the type of first parameter from rados_ioctx_t to rados_striper_t
>>> ---
>>> src/include/radosstriper/libradosstriper.h | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/src/include/radosstriper/libradosstriper.h b/src/include/radosstriper/libradosstriper.h
>>> index 5aa4a6b..4d552c6 100644
>>> --- a/src/include/radosstriper/libradosstriper.h
>>> +++ b/src/include/radosstriper/libradosstriper.h
>>> @@ -207,7 +207,8 @@ int rados_striper_remove(rados_striper_t striper,
>>> * @param size the new size of the object in bytes
>>> * @returns 0 on success, negative error code on failure
>>> */
>>> -int rados_striper_trunc(rados_ioctx_t io, const char *soid, uint64_t size);
>>> +int rados_striper_trunc(rados_striper_t striper,
>>> + const char *soid, uint64_t size);
>>>
>>> /** @} Synchronous I/O */
>>>
>>> --
>>> 1.8.3.1
>>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-05 4:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1517475365-7732-1-git-send-email-yuelongguang@gmail.com>
2018-02-02 8:18 ` [PATCH] libradosstriper: correct the first parameter of rados_striper_trunc yue longguang
2018-02-02 19:20 ` Yehuda Sadeh-Weinraub
2018-02-05 4:39 ` yue longguang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.