From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59CF6C07E95 for ; Fri, 2 Jul 2021 20:04:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9196461405 for ; Fri, 2 Jul 2021 20:04:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9196461405 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CDFA88296F; Fri, 2 Jul 2021 22:04:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Q2fhMTcs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F3A27829B9; Fri, 2 Jul 2021 22:04:54 +0200 (CEST) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5FF66828A4 for ; Fri, 2 Jul 2021 22:04:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wr1-x436.google.com with SMTP id f14so13436947wrs.6 for ; Fri, 02 Jul 2021 13:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sKpm7MMCEx8lyUBD47ETuxNC9DOsq9731KruKqrjs8o=; b=Q2fhMTcshxBaWnEwSEsBdl0+9oWmXH6Jn3QfOEN+zW+BtKZ7yXuBCMuDPklffP5k93 gfCr8Md9XqyBtV9MMhteBE7KUKyd9MlT0/wcU9mshlIIRv5yfqr7ovS9zSVztOTfBDv7 VXna9sC61J1A6lh9AMqL8RnjPb2Jsv8JC+xYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sKpm7MMCEx8lyUBD47ETuxNC9DOsq9731KruKqrjs8o=; b=cHxT3sNwazprKCI1ZgiUNxrNjSeX333JYCosVwQkAnzbBhnkFm45XBagtPs+3tsx+q MbbX80vYHH4BO8CCufAKWE9Jxn7TKD+o7DDgoTT748u/xoExX8uJaVIXXmJMne+F9uIA v4VyrnQ1Dkz89irw7IoQzztztlvm9sAl/p3bAXHmK4IU2qAFhefs82qHQkZ8JiO3omwi ZjfH/EV5V3VQ2KLrFmvhGtY/oenq9R8qE3NEHZxEWKy+wgJXHQ4xHTUeLZjV4yMSX8vm knJCo2T+6klykLrbwy4KU+EAh5jyWURGCG3fl4IbTCt7XkJdVvEQcg4zFT6K4Osgm5Uy Ir5Q== X-Gm-Message-State: AOAM531s5CFOrq3uursxjAYRNpb0rbdFV/yO6UO5Vr3S2nnh9lxuFnXC zQMO4pIZpLC1+QMHCF0dHHt9A/h5tCIDuUlIb1kNJQ== X-Google-Smtp-Source: ABdhPJzwvgdgQGPQVJ3viFo/GSjm9GhSPBwcIfve5Le0zHUZARExkX6rdb2JGg2kjy3iv5p7W6D5L4kaXuc8mHGTfiw= X-Received: by 2002:adf:ef87:: with SMTP id d7mr1486815wro.204.1625256291656; Fri, 02 Jul 2021 13:04:51 -0700 (PDT) MIME-Version: 1.0 References: <20210702183620.1542680-1-sjg@chromium.org> <5613820c4bba3707@bloch.sibelius.xs4all.nl> In-Reply-To: <5613820c4bba3707@bloch.sibelius.xs4all.nl> From: Simon Glass Date: Fri, 2 Jul 2021 14:04:40 -0600 Message-ID: Subject: Re: [PATCH v2 0/9] efi: Various tidy-ups and drop the default To: Mark Kettenis Cc: U-Boot Mailing List , Ilias Apalodimas , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Heinrich Schuchardt , Alex Graf , Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Mark, On Fri, 2 Jul 2021 at 13:50, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Fri, 2 Jul 2021 12:36:11 -0600 > > > > It has come to light that EFI_LOADER adds an extraordinary amount of > > code to U-Boot. For example, with nokia_rx51 the size delta is about > > 90KB. About 170 boards explicitly disable the option, but is is clear > > that many more could, thus saving image size and boot time. > > > > The current situation is affecting U-Boot's image as a svelt bootloader. > > > > EFI_LOADER is required by EBBR, a new boot standard which aims to > > bring in UEFI protocols to U-Boot. But EBRR is not required for > > booting. U-Boot already provides support for FIT, the 'bootm' command > > and a suitable hand-off to Linux. EBRR has made the decision to create > > a parallel infrastructure, e.g. does not use FIT, nor U-Boot's signing > > infrastructure. > > > > EBBR should be truly optional, enabled only by boards that use it. Most > > don't use it but it is enabled anyway. The default boot path should be > > one that makes use of the existing U-Boot support. > > > > To try to retify this situation, this series adds a new Kconfig option > > for EBBR so that the naming is more explicit. Then EFI_LOADER is updated > > to depend on it. > > > > The final patch makes EBBR optional. For now, only sandbox enables EBBR. > > Other boards can be added as needed, presumably by distributions that > > require it. Another approach would be to add 'CONFIG_EBBR=y' to the > > .config before building, in the build system. That might be more friendly > > to U-Boot users. > > > > This series also fixes a minor issue noticed during testing. > > I don't understand why you're pushing this series in a form that > still disables EFI_LOADER by default after last weeks discussions. I moved the change to non-default to the last patch. Even if that is not a good idea, the rest of the series stands. But more specifically to your question, I have not seen any discussion about the size issues identified. Nor has there been any comment on my suggestion in the cover letter for distros to define CONFIG_EBBR themselves when building U-Boot. I still think turning it off by default makes sense given the current situation. Regards, Simon