From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Fri, 12 Jun 2015 15:23:47 -0600 Subject: [U-Boot] [PATCH] fastboot: Dynamic controller index for usb_gadget_handle_interrupts In-Reply-To: References: <1432460464-4915-1-git-send-email-contact@paulk.fr> <20150525165043.080409bb@amdc2363> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Paul, On 7 June 2015 at 08:48, Simon Glass wrote: > On 25 May 2015 at 08:50, Lukasz Majewski wrote: >> Hi Paul, >> >>> Since we're now using a dynamic controller index for fastboot too, >>> usb_gadget_handle_interrupts should be using it instead of 0 (despite >>> the fact that it's currently not being used at all in the musb-new >>> implementation). >>> >>> Signed-off-by: Paul Kocialkowski >>> --- >>> common/cmd_fastboot.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c >>> index 86fbddf..b9d1c8c 100644 >>> --- a/common/cmd_fastboot.c >>> +++ b/common/cmd_fastboot.c >>> @@ -47,7 +47,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, >>> int argc, char *const argv[]) break; >>> if (ctrlc()) >>> break; >>> - usb_gadget_handle_interrupts(0); >>> + usb_gadget_handle_interrupts(controller_index); >>> } >>> >>> ret = CMD_RET_SUCCESS; >> >> Reviewed-by: Lukasz Majewski > > This is in my queue and looks like a fix, so I'm picking it up. > > Applied to u-boot-x86, thanks! Unfortunately in my final build test this breaks a number of boards, including: am335x_boneblack_vboot common/cmd_fastboot.c:36:32: error: ?controller_index? undeclared (first use in this function) usb_gadget_handle_interrupts(controller_index); Can you please take a look and respin it? For now I've dropped it from u-boot-x86. Regards, Simon