From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680043.outbound.protection.outlook.com [40.107.68.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8EE0E6E420 for ; Mon, 29 Mar 2021 14:05:10 +0000 (UTC) From: "Pillai, Aurabindo" Date: Mon, 29 Mar 2021 14:05:07 +0000 Message-ID: Content-Language: en-US MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH] tests/amdgpu: Add test description for amd_abm List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1977265789==" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Siqueira, Rodrigo" , Aurabindo Pillai Cc: "igt-dev@lists.freedesktop.org" List-ID: --===============1977265789== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CH0PR12MB528433F12819F7AEB3BEB89C8B7E9CH0PR12MB5284namp_" --_000_CH0PR12MB528433F12819F7AEB3BEB89C8B7E9CH0PR12MB5284namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - Internal Distribution Only] Hi Siqueira, Sorry about the change id, posted a v2 -- Thanks & Regards, Aurabindo Pillai ________________________________ From: Siqueira, Rodrigo Sent: Monday, March 29, 2021 9:44 AM To: Aurabindo Pillai Cc: igt-dev@lists.freedesktop.org; Pillai, Aurabindo Subject: Re: [PATCH] tests/amdgpu: Add test description for amd_abm Hi Aurabindo, On 03/29, Aurabindo Pillai wrote: > From: Aurabindo Pillai > > Add overall test description for amd_abm > > Change-Id: I4baa52ea66189688b12a82befbbd842ba3d3a24d We don't need this Change-id in IGT. Aside from the above comment, everything LGTM. Reviewed-by: Rodrigo Siqueira Let me know if you need help for applying this change in IGT. Thanks Siqueira > Signed-off-by: Aurabindo Pillai > --- > tests/amdgpu/amd_abm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c > index 0505f17e..a1e48533 100644 > --- a/tests/amdgpu/amd_abm.c > +++ b/tests/amdgpu/amd_abm.c > @@ -32,6 +32,8 @@ > #include > #include > > +IGT_TEST_DESCRIPTION("Tests Adaptive Backlight Modulation on supported h= ardware"); > + > #define BACKLIGHT_PATH "/sys/class/backlight/amdgpu_bl0" > > typedef struct data { > -- > 2.31.0 > -- Rodrigo Siqueira https://siqueira.tech --_000_CH0PR12MB528433F12819F7AEB3BEB89C8B7E9CH0PR12MB5284namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - Internal Distribution Only]


Hi Siqueira,

Sorry about the change id, posted a v2

--

Thanks & Regards,
Aurabindo Pillai


From: Siqueira, Rodrigo
Sent: Monday, March 29, 2021 9:44 AM
To: Aurabindo Pillai
Cc: igt-dev@lists.freedesktop.org; Pillai, Aurabindo
Subject: Re: [PATCH] tests/amdgpu: Add test description for amd_abm

Hi Aurabindo,

On 03/29, Aurabindo Pillai wrote:
> From: Aurabindo Pillai <aurabindo.pillai@amd.com>
>
> Add overall test description for amd_abm
>
> Change-Id: I4baa52ea66189688b12a82befbbd842ba3d3a24d

We don't need this Change-id in IGT.

Aside from the above comment, everything LGTM.

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

Let me know if you need help for applying this change in IGT.

Thanks
Siqueira

> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
>  tests/amdgpu/amd_abm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
> index 0505f17e..a1e48533 100644
> --- a/tests/amdgpu/amd_abm.c
> +++ b/tests/amdgpu/amd_abm.c
> @@ -32,6 +32,8 @@
>  #include <fcntl.h>
>  #include <time.h>

> +IGT_TEST_DESCRIPTION("Tests Adaptive Backlight Modulation on sup= ported hardware");
> +
>  #define BACKLIGHT_PATH "/sys/class/backlight/amdgpu_bl0&quo= t;

>  typedef struct data {
> --
> 2.31.0
>

--
Rodrigo Siqueira
https://siqueira.tech
--_000_CH0PR12MB528433F12819F7AEB3BEB89C8B7E9CH0PR12MB5284namp_-- --===============1977265789== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev --===============1977265789==--