From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDAF5C4338F for ; Fri, 30 Jul 2021 19:25:48 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 35BA060F01 for ; Fri, 30 Jul 2021 19:25:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 35BA060F01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B30040040; Fri, 30 Jul 2021 21:25:47 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id A294D4003F; Fri, 30 Jul 2021 21:25:45 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16UJLWxd002462; Fri, 30 Jul 2021 12:25:45 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by mx0b-0016f401.pphosted.com with ESMTP id 3a456tuhjq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jul 2021 12:25:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ea9oJvUn3VYYSp3+BxpXbbZrMlocK2Oybf+WqJUkJ05RsRib0Il0tzZl8r7K6O30hYSa9zHak8tKivb9LzaD7kztvJ38qfQy1fugjnEFvWBLXt7H8ZuM4jBrpfqYW67HtzjhB4OU1Oc9ATKS5TevARXTtWb15WCH4zzrfMqMqDoKA8IEwebCN05HC4EnUWzhdvBWaNxPWi+QKP5aV50LJsPJgfvoO1DqLjRvjpEdvnzEExLRrTLXubeb4VHMZAzto+L51GfN49d5lMUf7kDKQhFvOoKiX9R8E3U0TDNcdUQHUrv8Frae6sW/QX333c3SmvdTvU6Bub9ZRAd53uyoBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oaZkU+n/UkQkg+szNMIEAfaOhbpl8RAe51xHApl4FoI=; b=k6WjPwkC5Rxrhi9VuRDJ8HeW2wkHWAU5/xq8XVhr6ikB1xT/9NVmzsk3IY/miH3TkZPRj10ABV4uUadPM13eq+mCVOhWoLrb0R9rMb+qLGWLZpBm3bmP2tbagGUtGABqWSh88KVzC1nsTKtkvlOZBvu92LblA8flw82ZfLcq/MdPCpz79h5ZLdziEgQCLYm5HDJRIncVf097i0t5C/8NA+WVzug4eskXi2wYjvOrJZSniHt/ZOBkO5Ny6D0s0HPt392na54duO1T9OyQRb78EnJzlY/zEyzg7dlQSiK5F8AEFIAmtzfHMc1syfJ1acUdmb+QoLDMEzesDox/Y4U82g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oaZkU+n/UkQkg+szNMIEAfaOhbpl8RAe51xHApl4FoI=; b=e3kWwwMfsnTppsFKnfM9E3ORCStlr14EBQu6TfXjdGw2bBK2jFQQVMVfI51cAq9fHiPgQJ4gTp5vvB1BCDikgGrqHl7GnWp/grO1qHCQAjfoOC9pjQFHOErZkKZSrHF3QNzSIUDyhP6xZS2yX2LKe7lZXJdZo3Mr+irPH/RWrgY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4810.namprd18.prod.outlook.com (2603:10b6:303:ed::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.19; Fri, 30 Jul 2021 19:25:42 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557%7]) with mapi id 15.20.4373.025; Fri, 30 Jul 2021 19:25:42 +0000 From: Akhil Goyal To: "dev@dpdk.org" CC: Anoob Joseph , "ciara.power@intel.com" , "zhihongx.peng@intel.com" , "stable@dpdk.org" Thread-Topic: [PATCH] crypto/octeontx: fix heap use after free Thread-Index: AQHXhW8ebNuz0KX6HESSrOzLmyXCa6tb5kPA Date: Fri, 30 Jul 2021 19:25:42 +0000 Message-ID: References: <20210730181703.529468-1-gakhil@marvell.com> In-Reply-To: <20210730181703.529468-1-gakhil@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08860d28-7e8f-45de-90ba-08d9538fd243 x-ms-traffictypediagnostic: CO1PR18MB4810: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lju336v2xtIAMHYWyjNmMEOh21UnY16YI+PMtwNG1qAAA985wjmN8rNfp0dQYOsLs2ne/YqUFLjyCw3+wiqCzkAJIlSjDBeUNBmR0p0Jg1eQJPnBuZ8oUCs6MsDgzdCQRM+U3NPQcjaODBM+9BiGd7HqMpqJgROIrjaehM9TRkkBfJByTfRQrR6c7cNu1TUr756GgewR26TkmuEsHF6RzAv9s2hEQhlPAdEDwEHU5hk2vdKOFfNRDLnGsQNdPbRcYFqpz7J7Xtpp/qdmbNFAX1QbFyluHEns+3Gf2Z4IlO/Xia0NVYfaUoqQGofO2gNfITYXBD7N9sB9a82PkP4dH9dAltf42eNoR2q63w1pDRfyONQokL2DXUsAaCwnEcBR8iro4/dlUEv4tj9Iul3950cqiAAOhxxZKQiJydovjOLXfVGox0+/6rHIzLqpaBBZZpAgYKbVvqBb9LKqwWIR5yL0M8nvUVQV00jqfQhp6K7qpJSv5gG0wt+KOQHito8y2wnWWc8n5+X9qWzbhRzItDwvleWtgRXIFotMGDYj9jKppjwiRT//sKherf2FG4TIakdiF6lnFsd2DPT2k6/MVdeVnDU9s7YQHAdmE9aJb4ul8Z/AyQ65eqR2lXiO7zYIab9BAa064eEwZFwKVxF7p8GeJN1dcF/aQNDSeplZlZIIfG9EJ8kr1H4U3T1Vp6S0dCc+8topMI3ci54OfI/YfQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(7696005)(6916009)(33656002)(186003)(86362001)(26005)(5660300002)(316002)(8676002)(76116006)(52536014)(8936002)(38070700005)(9686003)(55016002)(4744005)(55236004)(122000001)(66476007)(66946007)(6506007)(54906003)(38100700002)(66556008)(66446008)(64756008)(508600001)(71200400001)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1J1q3FEeJUSjlvjEc9D5GxdupniQmQtrLiUySX19peuX/eUQ2F1pamxpeJZT?= =?us-ascii?Q?n+uE7XWWdleKt+uwRb9tgwXQz8dJ6mytX8G0SYYahbpRs5YQmGWG2Nzw5vRs?= =?us-ascii?Q?d2xRx4j0tGc5xZQqbGtVEsWXJfjU0XCBYQGZ7wZoMdmVKRHLFKG2MXOPlpah?= =?us-ascii?Q?81E8+9yrCwx46lIyrQ5H5wa3NGuDQHZGCeXytlgZYWWMYWZZ2Cke4/TSBJqd?= =?us-ascii?Q?vYPeCA4r054E0VRdjMiPQkMSiCQfxwquW/s8VZSluPggTAXLjNc0nmKvwhVE?= =?us-ascii?Q?//Jc7BmE3v0gYPMpvI9LihBEqWqVI+ulKPlL5J/CzR/YvqJ75WFL0S2Ws8gf?= =?us-ascii?Q?QFtxximsMKIyyl5xhrrit7ClXSA/TA8ZSyKMTHvfJGu+80j4bpxovXdVKHmV?= =?us-ascii?Q?XizlP3pk7ITDJWpRa5vUJbUvvx6aKpD6usaCkGVDw7mPfpKMF56KFTzgZr7w?= =?us-ascii?Q?T8mwawbt2dUxoDxjAFyCLuPpVfEajtJbqpkx8Vu8ClzkkyzAsmCyBcr+VJNX?= =?us-ascii?Q?Ta8OgKwJfDSGl9f8QFiFgvj0QjqoCZ6uu92QKcFhT5XMyetPRAuV/iMPkoq5?= =?us-ascii?Q?DEMkR+PbzKJF5N10R0DRhf7I9mvAHZlyIB7G/USNZ8eX8TvKcdVO6DbImfS4?= =?us-ascii?Q?uNvAdFfw5IgXXohQoZjLL52IeKVm3U2jG/STlMUxKq3bC27PBC88IxZoFC+k?= =?us-ascii?Q?nXTBqHSr2lKCwmMzhZpLleG/rTeKXh2EN21jVAWIIzsGoEAz/B0LQQyDtD5r?= =?us-ascii?Q?PtMEXqr/MeNwRuD+4Sk4whB+Bhlt3nmOJO3kzu90NMbLOkDdgauPU6mgjEHN?= =?us-ascii?Q?XmO2VbsgGhBq/rgWoHnG14FoK3H8dd77dMaw8K+pqtRw7ZmRW2oHMxZX2px1?= =?us-ascii?Q?ZDR0fkwKveoUzj+0hfJuAD0zZ/ttgVCkM+/i7J69A9EZZUfT3OjgcmRUu6iE?= =?us-ascii?Q?yXoYij22urJ3n5KmefQ6zoJ7QR6YN/sZopwL8B3IdYzFFoWFnRibFk1GmWn1?= =?us-ascii?Q?i8Giw0Ns0+lOaAiW2MBIfIOt4KvWPWUcFH3KTsoPzYBX1bL8JYmNTLdd2twK?= =?us-ascii?Q?/WPjfwNsIaRHZjOUZnUyMiZT32rSbEEiHHV4u4nD4X8nZ8hnHTmbk+t7WPdg?= =?us-ascii?Q?VBHIgtSw3FlZid54L19tbnmlIs/qr8pba0qmHHQimJpThf5/azDdMYpV/629?= =?us-ascii?Q?bbUKhSKHs0wm7hLJtO9yyzSh6Yw7REoeDSyo4dDZU5VblwIgNMGJX5Ww2RNX?= =?us-ascii?Q?E8SnO3KVuJgWbqpzdUdqOsaVDvmXnpkf1CyH4J0XnPj2HlmMuoOr/11udJyK?= =?us-ascii?Q?EMQfnVanaEL/BUHQT9nsaoYa?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08860d28-7e8f-45de-90ba-08d9538fd243 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2021 19:25:42.0756 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SxReuknsgFxgmR896V46bDRQUypwOEb1fuUk7A99Gcl7FI2Pz3VTus03UEgFWVa3wd8CJwrSpOJ0+wYs1ZrYMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4810 X-Proofpoint-GUID: -p2HrYotWZ5R8xTrcBYdSIv4SVafmNgL X-Proofpoint-ORIG-GUID: -p2HrYotWZ5R8xTrcBYdSIv4SVafmNgL X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-30_11:2021-07-30, 2021-07-30 signatures=0 Subject: Re: [dpdk-dev] [PATCH] crypto/octeontx: fix heap use after free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [PATCH] crypto/octeontx: fix heap use after free >=20 > When the PMD is removed, rte_cryptodev_pmd_release_device > is called which frees cryptodev->data, and then tries to free > cryptodev->data->dev_private, which causes the heap use > after free issue. >=20 > A temporary pointer is set before the free of cryptodev->data, > which can then be used afterwards to free dev_private. >=20 > Fixes: bfe2ae495ee2 ("crypto/octeontx: add PMD skeleton") > Cc: stable@dpdk.org >=20 > Reported-by: ZhihongX Peng > Signed-off-by: Akhil Goyal Applied to dpdk-next-crypto