From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 963F6E00C44; Wed, 2 Sep 2015 02:16:37 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [134.134.136.24 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 2ECA6E009EC for ; Wed, 2 Sep 2015 02:16:34 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 02 Sep 2015 02:16:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,452,1437462000"; d="scan'208";a="553717117" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by FMSMGA003.fm.intel.com with ESMTP; 02 Sep 2015 02:16:32 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 2 Sep 2015 10:16:30 +0100 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.144]) by irsmsx111.ger.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0224.002; Wed, 2 Sep 2015 10:16:31 +0100 From: "Barros Pena, Belen" To: "Reyna, David L (Wind River)" Thread-Topic: [Toaster] [review-request][PATCH] 8126 Messages are missing when "IMAGE_FSTYPES" field is not properly edited Thread-Index: AdDlUtvqImKPGQA8TfCGx6xOKtB8kwADTD+A Date: Wed, 2 Sep 2015 09:16:29 +0000 Message-ID: References: <5E53D14CE4667A45B9A06760DE5D13D082655701@ALA-MBA.corp.ad.wrs.com> In-Reply-To: <5E53D14CE4667A45B9A06760DE5D13D082655701@ALA-MBA.corp.ad.wrs.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.4.150722 x-originating-ip: [10.237.224.30] MIME-Version: 1.0 Cc: "toaster@yoctoproject.org" Subject: Re: [review-request][PATCH] 8126 Messages are missing when "IMAGE_FSTYPES" field is not properly edited X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2015 09:16:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: <6F6D1BC74B5DCC468F1C655C4B55ACDF@intel.com> Content-Transfer-Encoding: quoted-printable On 02/09/2015 08:44, "Reyna, David" wrote: >Hi Bel=E9n, > >Please find the patch for 8126 here: > > dreyna/project_fstypes_8126 Hi David, This is looking fairly good. I've only run across one problem. This is how to reproduce: 1. Click the 'change' icon for IMAGE_FSTYPES 2. Deselect all values: the 'save' button becomes disabled and the message asking you to select at least one image type appears. This is the expected behaviour 3. Now, click the 'cancel' link. The IMAGE_FSTYPES value stays the way it was before you clicked the 'change' icon. This is once more the correct behaviour 4. Now click the 'change' icon again. There are image types selected, but the message 'You must select at least one image type' still shows, and the 'Save' button is disabled. This is not the correct behaviour. As long as there is at least one checkbox ticked you should see no message and the 'save' button should be enabled. If you make a change (untick a box), the validation kicks in and things return to the correct state. Sounds like we need to check the selected values whenever the 'change' icon is clicked Thanks! Bel=E9n > >Note: for the message 'label' the I insert and then show when there are >no matches, it is guaranteed not to pollute the database because it can >never be in the checked state. > >- David >