From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 44FB1E00D0E; Wed, 2 Sep 2015 08:58:29 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [134.134.136.20 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 0F152E00ADB for ; Wed, 2 Sep 2015 08:58:25 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 02 Sep 2015 08:58:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,454,1437462000"; d="scan'208";a="637182582" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga003.jf.intel.com with ESMTP; 02 Sep 2015 08:58:24 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.144]) by IRSMSX153.ger.corp.intel.com ([169.254.9.13]) with mapi id 14.03.0224.002; Wed, 2 Sep 2015 16:58:22 +0100 From: "Barros Pena, Belen" To: "Reyna, David L (Wind River)" Thread-Topic: [Toaster] [review-request][PATCH] 8126 Messages are missing when "IMAGE_FSTYPES" field is not properly edited Thread-Index: AdDlUtvqImKPGQA8TfCGx6xOKtB8kwADTD+AAAt515AAAo8hgA== Date: Wed, 2 Sep 2015 15:58:21 +0000 Message-ID: References: <5E53D14CE4667A45B9A06760DE5D13D082655701@ALA-MBA.corp.ad.wrs.com> <5E53D14CE4667A45B9A06760DE5D13D082655F65@ALA-MBA.corp.ad.wrs.com> In-Reply-To: <5E53D14CE4667A45B9A06760DE5D13D082655F65@ALA-MBA.corp.ad.wrs.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.4.150722 x-originating-ip: [10.237.224.30] MIME-Version: 1.0 Cc: "toaster@yoctoproject.org" Subject: Re: [review-request][PATCH] 8126 Messages are missing when "IMAGE_FSTYPES" field is not properly edited X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2015 15:58:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable On 02/09/2015 15:46, "Reyna, David" wrote: >Hi Bel=E9n, > >Thank you for the observation. > >I have updated "dreyna/project_fstypes_8126" to address that issue, and >the code now always pre-initializes the warning message element so that >the previous value is not dangling. yep: this seems to behave as expected now. Thanks! I've also realised that the base branch seems a bit old. Could you rebase and resubmit? Cheers Bel=E9n > >- David > > >> -----Original Message----- >> From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com] >> Sent: Wednesday, September 02, 2015 2:16 AM >> To: Reyna, David >> Cc: toaster@yoctoproject.org >> Subject: Re: [Toaster] [review-request][PATCH] 8126 Messages are missing >> when "IMAGE_FSTYPES" field is not properly edited >> >> >> >> On 02/09/2015 08:44, "Reyna, David" wrote: >> >> >Hi Bel=E9n, >> > >> >Please find the patch for 8126 here: >> > >> > dreyna/project_fstypes_8126 >> >> Hi David, >> >> This is looking fairly good. I've only run across one problem. This is >>how >> to reproduce: >> >> 1. Click the 'change' icon for IMAGE_FSTYPES >> >> 2. Deselect all values: the 'save' button becomes disabled and the >>message >> asking you to select at least one image type appears. This is the >>expected >> behaviour >> >> 3. Now, click the 'cancel' link. The IMAGE_FSTYPES value stays the way >>it >> was before you clicked the 'change' icon. This is once more the correct >> behaviour >> >> 4. Now click the 'change' icon again. There are image types selected, >>but >> the message 'You must select at least one image type' still shows, and >>the >> 'Save' button is disabled. This is not the correct behaviour. As long as >> there is at least one checkbox ticked you should see no message and the >> 'save' button should be enabled. If you make a change (untick a box), >>the >> validation kicks in and things return to the correct state. Sounds like >>we >> need to check the selected values whenever the 'change' icon is clicked >> >> Thanks! >> >> Bel=E9n >> >> > >> >Note: for the message 'label' the I insert and then show when there are >> >no matches, it is guaranteed not to pollute the database because it can >> >never be in the checked state. >> > >> >- David >> > >> >