From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756118AbbFPOIn (ORCPT ); Tue, 16 Jun 2015 10:08:43 -0400 Received: from mail-db3on0115.outbound.protection.outlook.com ([157.55.234.115]:17309 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754173AbbFPOIg convert rfc822-to-8bit (ORCPT ); Tue, 16 Jun 2015 10:08:36 -0400 From: "Abdul, Hussain (H.)" To: Ian Abbott , "gregkh@linuxfoundation.org" CC: "hsweeten@visionengravers.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Ravindran, Madhusudhanan (M.)" , "Dighe, Niranjan (N.)" Subject: Re: [PATCH] Staging: comedi: Simplify a trivial if-return sequence Thread-Topic: [PATCH] Staging: comedi: Simplify a trivial if-return sequence Thread-Index: AQHQqAoqVcs9guwYVku5gHKoMl7Xaw== Date: Tue, 16 Jun 2015 14:08:33 +0000 Message-ID: References: <1434441401-13894-1-git-send-email-habdul@visteon.com> <5580209A.1050205@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mev.co.uk; dkim=none (message not signed) header.d=none; x-originating-ip: [74.112.164.117] x-microsoft-exchange-diagnostics: 1;DB5PR06MB1110;3:FLYhlMyTDr/Ld/ZhjCCZ+pULD/gsg3YJQNWQgh0qa7khjt8dO9A9VIi3Gp7eVBetWOmklBiMBnnCXOpWHG03Q0R4WFBBoxKCu18hEGQ/Jwa6RWsjfamrkCrrjbE4iJ902Il2E5IL3aKmh/DdF4na/Q==;10:l/OdzlFICN8d2W1Jqr0ma0Ite9zRe1CwHVrtboObu8KejEKTye8LBA8VHTy9jzsq1HNzjUeB5KoHpgW97aGlE11+KT26VQCS1je7qZShqaI=;6:lg8dFUouCWiNXKvax5cLZ65YS1au+mmNHx9U+1BpNQFYGHoqUavM0HurHU2tWuaK x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1110; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:DB5PR06MB1110;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1110; x-forefront-prvs: 06098A2863 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(164054003)(24454002)(479174004)(51704005)(5890100001)(5003600100002)(2501003)(87936001)(19580405001)(19580395003)(46102003)(86362001)(575784001)(2656002)(106116001)(189998001)(54356999)(33656002)(76176999)(50986999)(40100003)(2900100001)(77096005)(102836002)(74316001)(5002640100001)(62966003)(77156002)(5001770100001)(5001960100002)(107886002)(92566002)(76576001)(66066001)(122556002)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR06MB1110;H:DB5PR06MB1112.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2015 14:08:33.5034 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR06MB1110 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 16 June 2015 06:42 PM, Ian Abbott wrote: > On 16/06/15 08:58, Abdul, Hussain (H.) wrote: >> From: Abdul Hussain >> >> This patch simplify a trivial if-return sequence. Possibly combine with >> a preceding function call. >> >> Signed-off-by: Abdul Hussain >> --- >> drivers/staging/comedi/drivers/dac02.c | 6 +----- >> drivers/staging/comedi/drivers/daqboard2000.c | 6 +----- >> drivers/staging/comedi/drivers/dmm32at.c | 6 +----- >> drivers/staging/comedi/drivers/fl512.c | 6 +----- >> drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +----- >> drivers/staging/comedi/drivers/s626.c | 6 +----- >> 6 files changed, 6 insertions(+), 30 deletions(-) >> > Ideally, this should be split into separate patches. > > [snip] >> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c >> index 611b0a3..0fe40c2 100644 >> --- a/drivers/staging/comedi/drivers/daqboard2000.c >> +++ b/drivers/staging/comedi/drivers/daqboard2000.c >> @@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev, >> return result; >> >> s = &dev->subdevices[2]; >> - result = subdev_8255_init(dev, s, daqboard2000_8255_cb, >> + return subdev_8255_init(dev, s, daqboard2000_8255_cb, >> dioP2ExpansionIO8Bit); > That 'dioP2ExpansionIO8Bit' line could do with being un-indented by a > couple of spaces so it still lines up with the 'dev' on the preceding line. > Ian, Split and sent as separate patches with the above change. Thanks, Abdul