All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* Bad header guard in alsa-lib
@ 2018-07-06 13:54 Guillaume Blanc
  2018-07-06 15:09 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Guillaume Blanc @ 2018-07-06 13:54 UTC (permalink / raw
  To: alsa-devel@alsa-project.org

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]


Hello,
While building alsa-lib, I got a redefinition error caused by a bad header guard in pcm_plugin.h.
I assume this is a mistake and not a weird include trick, attached is a patch to fix this.
Best regards,
Guillaume Blanc

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-header-guard-in-pcm_plugin.h.patch --]
[-- Type: text/x-patch; name="0001-Fix-header-guard-in-pcm_plugin.h.patch", Size: 566 bytes --]

From 8e643b7e007074807b83f27d88d02ea367d2c3b7 Mon Sep 17 00:00:00 2001
From: Guillaume Blanc <guillaume.blanc@parrot.com>
Date: Fri, 6 Jul 2018 15:22:06 +0200
Subject: [PATCH - alsa-lib 1/1] Fix header guard in pcm_plugin.h

Signed-off-by: Guillaume Blanc <guillaume.blanc@parrot.com>

diff --git a/include/pcm_plugin.h b/include/pcm_plugin.h
index ad14e7b..3061205 100644
--- a/include/pcm_plugin.h
+++ b/include/pcm_plugin.h
@@ -30,6 +30,7 @@
  */
 
 #ifndef __ALSA_PCM_PLUGIN_H
+#define __ALSA_PCM_PLUGIN_H
 
 /**
  * \defgroup PCM_Plugins PCM Plugins
-- 
1.9.1


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Bad header guard in alsa-lib
  2018-07-06 13:54 Bad header guard in alsa-lib Guillaume Blanc
@ 2018-07-06 15:09 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2018-07-06 15:09 UTC (permalink / raw
  To: Guillaume Blanc; +Cc: alsa-devel@alsa-project.org

On Fri, 06 Jul 2018 15:54:07 +0200,
Guillaume Blanc wrote:
> 
> 
> Hello,
> While building alsa-lib, I got a redefinition error caused by a bad header guard in pcm_plugin.h.
> I assume this is a mistake and not a weird include trick, attached is a patch to fix this.

Applied, thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-06 15:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-06 13:54 Bad header guard in alsa-lib Guillaume Blanc
2018-07-06 15:09 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.