From: "Y.b. Lu" <yangbo.lu@nxp.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"mptcp@lists.linux.dev" <mptcp@lists.linux.dev>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
Shuah Khan <shuah@kernel.org>, Michal Kubecek <mkubecek@suse.cz>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Rui Sousa <rui.sousa@nxp.com>,
Sebastien Laveze <sebastien.laveze@nxp.com>
Subject: RE: [net-next, v3, 02/10] ptp: support ptp physical/virtual clocks conversion
Date: Fri, 25 Jun 2021 11:09:38 +0000 [thread overview]
Message-ID: <DB7PR04MB5017347E573293D98A60FB30F8069@DB7PR04MB5017.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DB7PR04MB5017355B61A31D61340A52A3F8099@DB7PR04MB5017.eurprd04.prod.outlook.com>
Hi Richard,
> -----Original Message-----
> From: Y.b. Lu
> Sent: 2021年6月22日 18:35
> To: Richard Cochran <richardcochran@gmail.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-kselftest@vger.kernel.org; mptcp@lists.linux.dev; David S . Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Mat Martineau
> <mathew.j.martineau@linux.intel.com>; Matthieu Baerts
> <matthieu.baerts@tessares.net>; Shuah Khan <shuah@kernel.org>; Michal
> Kubecek <mkubecek@suse.cz>; Florian Fainelli <f.fainelli@gmail.com>;
> Andrew Lunn <andrew@lunn.ch>; Rui Sousa <rui.sousa@nxp.com>; Sebastien
> Laveze <sebastien.laveze@nxp.com>
> Subject: RE: [net-next, v3, 02/10] ptp: support ptp physical/virtual clocks
> conversion
>
> Hi Richard,
>
> > -----Original Message-----
> > From: Richard Cochran <richardcochran@gmail.com>
> > Sent: 2021年6月18日 2:28
> > To: Y.b. Lu <yangbo.lu@nxp.com>
> > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> > linux-kselftest@vger.kernel.org; mptcp@lists.linux.dev; David S .
> > Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Mat
> > Martineau <mathew.j.martineau@linux.intel.com>; Matthieu Baerts
> > <matthieu.baerts@tessares.net>; Shuah Khan <shuah@kernel.org>; Michal
> > Kubecek <mkubecek@suse.cz>; Florian Fainelli <f.fainelli@gmail.com>;
> > Andrew Lunn <andrew@lunn.ch>; Rui Sousa <rui.sousa@nxp.com>;
> Sebastien
> > Laveze <sebastien.laveze@nxp.com>
> > Subject: Re: [net-next, v3, 02/10] ptp: support ptp physical/virtual
> > clocks conversion
> >
> > On Tue, Jun 15, 2021 at 05:45:09PM +0800, Yangbo Lu wrote:
> >
> > > diff --git a/drivers/ptp/ptp_private.h b/drivers/ptp/ptp_private.h
> > > index 3f388d63904c..6949afc9d733 100644
> > > --- a/drivers/ptp/ptp_private.h
> > > +++ b/drivers/ptp/ptp_private.h
> > > @@ -46,6 +46,9 @@ struct ptp_clock {
> > > const struct attribute_group *pin_attr_groups[2];
> > > struct kthread_worker *kworker;
> > > struct kthread_delayed_work aux_work;
> > > + u8 n_vclocks;
> >
> > Hm, type is u8, but ...
> >
> > > + struct mutex n_vclocks_mux; /* protect concurrent n_vclocks access */
> > > + bool vclock_flag;
> > > };
> > >
> >
> > > #define info_to_vclock(d) container_of((d), struct ptp_vclock,
> > > info) diff --git a/include/uapi/linux/ptp_clock.h
> > > b/include/uapi/linux/ptp_clock.h index 1d108d597f66..4b933dc1b81b
> > > 100644
> > > --- a/include/uapi/linux/ptp_clock.h
> > > +++ b/include/uapi/linux/ptp_clock.h
> > > @@ -69,6 +69,11 @@
> > > */
> > > #define PTP_PEROUT_V1_VALID_FLAGS (0)
> > >
> > > +/*
> > > + * Max number of PTP virtual clocks per PTP physical clock */
> > > +#define PTP_MAX_VCLOCKS 20
> >
> > Only 20 clocks are allowed? Why?
>
> Initially I think vclock can be used for ptp multiple domains synchronization.
> Since the PTP domainValue is u8, u8 vclock number is large enough.
> This is not a good idea to hard-code a PTP_MAX_VCLOCKS value. But it looks a
> little crazy to create numbers of vclocks via one command (echo n >
> /sys/class/ptp/ptp0/n_vclocks).
> Maybe a typo creates hundreds of vclocks we don’t need.
> Do you think we should be care about setting a limitation of vclock number?
> Any suggestion for implementation?
> Thanks.
I sent v4. I removed the u8 limitation for vclocks number, using unsigned int instead.
I introduced max_vclocks attribute which could be re-configured.
Please help to review.
Thanks.
>
> >
> > Thanks,
> > Richard
next prev parent reply other threads:[~2021-06-25 11:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 9:45 [net-next, v3, 00/10] ptp: support virtual clocks and timestamping Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 01/10] ptp: add ptp virtual clock driver framework Yangbo Lu
2021-06-17 17:32 ` Richard Cochran
2021-06-22 10:17 ` Y.b. Lu
2021-06-15 9:45 ` [net-next, v3, 02/10] ptp: support ptp physical/virtual clocks conversion Yangbo Lu
2021-06-17 17:42 ` Richard Cochran
2021-06-22 10:18 ` Y.b. Lu
2021-06-17 18:27 ` Richard Cochran
2021-06-22 10:35 ` Y.b. Lu
2021-06-25 11:09 ` Y.b. Lu [this message]
2021-06-19 4:06 ` Richard Cochran
2021-06-22 10:39 ` Y.b. Lu
2021-06-15 9:45 ` [net-next, v3, 03/10] ptp: track available ptp vclocks information Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 04/10] ptp: add kernel API ptp_get_vclocks_index() Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 05/10] ethtool: add a new command for getting PHC virtual clocks Yangbo Lu
2021-06-15 19:49 ` Jakub Kicinski
2021-06-22 10:10 ` Y.b. Lu
2021-06-15 23:24 ` Michal Kubecek
2021-06-22 10:10 ` Y.b. Lu
2021-06-15 9:45 ` [net-next, v3, 06/10] ptp: add kernel API ptp_convert_timestamp() Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 07/10] net: sock: extend SO_TIMESTAMPING for PHC binding Yangbo Lu
2021-06-16 1:00 ` Mat Martineau
2021-06-22 10:14 ` Y.b. Lu
2021-06-16 10:27 ` kernel test robot
2021-06-16 10:27 ` kernel test robot
2021-06-16 10:39 ` kernel test robot
2021-06-16 10:39 ` kernel test robot
2021-06-15 9:45 ` [net-next, v3, 08/10] net: socket: support hardware timestamp conversion to PHC bound Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 09/10] selftests/net: timestamping: support binding PHC Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 10/10] MAINTAINERS: add entry for PTP virtual clock driver Yangbo Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR04MB5017347E573293D98A60FB30F8069@DB7PR04MB5017.eurprd04.prod.outlook.com \
--to=yangbo.lu@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mkubecek@suse.cz \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=rui.sousa@nxp.com \
--cc=sebastien.laveze@nxp.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.