From: "Y.b. Lu" <yangbo.lu@nxp.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"mptcp@lists.linux.dev" <mptcp@lists.linux.dev>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
Shuah Khan <shuah@kernel.org>, Michal Kubecek <mkubecek@suse.cz>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Rui Sousa <rui.sousa@nxp.com>,
Sebastien Laveze <sebastien.laveze@nxp.com>
Subject: RE: [net-next, v3, 02/10] ptp: support ptp physical/virtual clocks conversion
Date: Tue, 22 Jun 2021 10:39:25 +0000 [thread overview]
Message-ID: <DB7PR04MB501756892A5B773671ABD044F8099@DB7PR04MB5017.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210619040623.GA14326@localhost>
Hi Richard,
> -----Original Message-----
> From: Richard Cochran <richardcochran@gmail.com>
> Sent: 2021年6月19日 12:06
> To: Y.b. Lu <yangbo.lu@nxp.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-kselftest@vger.kernel.org; mptcp@lists.linux.dev; David S . Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Mat Martineau
> <mathew.j.martineau@linux.intel.com>; Matthieu Baerts
> <matthieu.baerts@tessares.net>; Shuah Khan <shuah@kernel.org>; Michal
> Kubecek <mkubecek@suse.cz>; Florian Fainelli <f.fainelli@gmail.com>;
> Andrew Lunn <andrew@lunn.ch>; Rui Sousa <rui.sousa@nxp.com>; Sebastien
> Laveze <sebastien.laveze@nxp.com>
> Subject: Re: [net-next, v3, 02/10] ptp: support ptp physical/virtual clocks
> conversion
>
> On Tue, Jun 15, 2021 at 05:45:09PM +0800, Yangbo Lu wrote:
>
> > diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c index
> > a780435331c8..78414b3e16dd 100644
> > --- a/drivers/ptp/ptp_clock.c
> > +++ b/drivers/ptp/ptp_clock.c
> > @@ -76,6 +76,11 @@ static int ptp_clock_settime(struct posix_clock
> > *pc, const struct timespec64 *tp {
> > struct ptp_clock *ptp = container_of(pc, struct ptp_clock, clock);
> >
> > + if (ptp_guaranteed_pclock(ptp)) {
>
> Can we please invent a more descriptive name for this method?
> The word "guaranteed" suggests much more.
>
> > + pr_err("ptp: virtual clock in use, guarantee physical clock free
> > +running\n");
>
> This is good: ^^^^^^^^^^^^^^^^^^^^^^^^^
> You can drop this part:
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> So, please rename ptp_guaranteed_pclock() to ptp_vclock_in_use();
>
Thank you. Will convert to that.
> > + return -EBUSY;
> > + }
> > +
> > return ptp->info->settime64(ptp->info, tp); }
>
>
> > diff --git a/drivers/ptp/ptp_private.h b/drivers/ptp/ptp_private.h
> > index 3f388d63904c..6949afc9d733 100644
> > --- a/drivers/ptp/ptp_private.h
> > +++ b/drivers/ptp/ptp_private.h
> > @@ -46,6 +46,9 @@ struct ptp_clock {
> > const struct attribute_group *pin_attr_groups[2];
> > struct kthread_worker *kworker;
> > struct kthread_delayed_work aux_work;
> > + u8 n_vclocks;
>
> Why not use "unsigned int" type? I don't see a need to set an artificial limit.
Please see my explain in another email thread. Thanks.
>
> > + struct mutex n_vclocks_mux; /* protect concurrent n_vclocks access */
> > + bool vclock_flag;
>
> "flag" is vague. How about "is_virtual_clock" instead?
That's better. Will use it. Thank you.
>
> > };
> >
> > #define info_to_vclock(d) container_of((d), struct ptp_vclock, info)
> > @@ -75,6 +78,18 @@ static inline int queue_cnt(struct
> timestamp_event_queue *q)
> > return cnt < 0 ? PTP_MAX_TIMESTAMPS + cnt : cnt; }
> >
> > +/*
> > + * Guarantee physical clock to stay free running, if ptp virtual
> > +clocks
> > + * on it are in use.
> > + */
> > +static inline bool ptp_guaranteed_pclock(struct ptp_clock *ptp) {
> > + if (!ptp->vclock_flag && ptp->n_vclocks)
>
> Need to take mutex for n_vclocks to prevent load tearing.
>
> > + return true;
> > +
> > + return false;
> > +}
> > +
> > /*
> > * see ptp_chardev.c
> > */
>
> > @@ -148,6 +149,90 @@ static ssize_t pps_enable_store(struct device
> > *dev, } static DEVICE_ATTR(pps_enable, 0220, NULL,
> > pps_enable_store);
> >
> > +static int unregister_vclock(struct device *dev, void *data) {
> > + struct ptp_clock *ptp = dev_get_drvdata(dev);
> > + struct ptp_clock_info *info = ptp->info;
> > + struct ptp_vclock *vclock;
> > + u8 *num = data;
> > +
> > + vclock = info_to_vclock(info);
> > + dev_info(dev->parent, "delete virtual clock ptp%d\n",
> > + vclock->clock->index);
> > +
> > + ptp_vclock_unregister(vclock);
> > + (*num)--;
> > +
> > + /* For break. Not error. */
> > + if (*num == 0)
> > + return -EINVAL;
> > +
> > + return 0;
> > +}
> > +
> > +static ssize_t n_vclocks_show(struct device *dev,
> > + struct device_attribute *attr, char *page) {
> > + struct ptp_clock *ptp = dev_get_drvdata(dev);
> > +
> > + return snprintf(page, PAGE_SIZE-1, "%d\n", ptp->n_vclocks);
>
> Take mutex.
Will take mutex everywhere to access it.
>
> > +}
> > +
> > +static ssize_t n_vclocks_store(struct device *dev,
> > + struct device_attribute *attr,
> > + const char *buf, size_t count) {
> > + struct ptp_clock *ptp = dev_get_drvdata(dev);
> > + struct ptp_vclock *vclock;
> > + int err = -EINVAL;
> > + u8 num, i;
> > +
> > + if (kstrtou8(buf, 0, &num))
> > + goto out;
> > +
> > + if (num > PTP_MAX_VCLOCKS) {
> > + dev_err(dev, "max value is %d\n", PTP_MAX_VCLOCKS);
> > + goto out;
> > + }
> > +
> > + if (mutex_lock_interruptible(&ptp->n_vclocks_mux))
> > + return -ERESTARTSYS;
> > +
> > + /* Need to create more vclocks */
> > + if (num > ptp->n_vclocks) {
> > + for (i = 0; i < num - ptp->n_vclocks; i++) {
> > + vclock = ptp_vclock_register(ptp);
> > + if (!vclock) {
> > + mutex_unlock(&ptp->n_vclocks_mux);
> > + goto out;
> > + }
> > +
> > + dev_info(dev, "new virtual clock ptp%d\n",
> > + vclock->clock->index);
> > + }
> > + }
> > +
> > + /* Need to delete vclocks */
> > + if (num < ptp->n_vclocks) {
> > + i = ptp->n_vclocks - num;
> > + device_for_each_child_reverse(dev, &i,
> > + unregister_vclock);
> > + }
> > +
> > + if (num == 0)
> > + dev_info(dev, "only physical clock in use now\n");
> > + else
> > + dev_info(dev, "guarantee physical clock free running\n");
> > +
> > + ptp->n_vclocks = num;
> > + mutex_unlock(&ptp->n_vclocks_mux);
> > +
> > + return count;
> > +out:
> > + return err;
> > +}
> > +static DEVICE_ATTR_RW(n_vclocks);
> > +
> > static struct attribute *ptp_attrs[] = {
> > &dev_attr_clock_name.attr,
> >
>
>
> > diff --git a/include/uapi/linux/ptp_clock.h
> > b/include/uapi/linux/ptp_clock.h index 1d108d597f66..4b933dc1b81b
> > 100644
> > --- a/include/uapi/linux/ptp_clock.h
> > +++ b/include/uapi/linux/ptp_clock.h
> > @@ -69,6 +69,11 @@
> > */
> > #define PTP_PEROUT_V1_VALID_FLAGS (0)
> >
> > +/*
> > + * Max number of PTP virtual clocks per PTP physical clock */
> > +#define PTP_MAX_VCLOCKS 20
>
> Why limit this to twenty clocks?
Please see my explain in another email thread. Thanks.
>
> Thanks,
> Richard
next prev parent reply other threads:[~2021-06-22 10:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 9:45 [net-next, v3, 00/10] ptp: support virtual clocks and timestamping Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 01/10] ptp: add ptp virtual clock driver framework Yangbo Lu
2021-06-17 17:32 ` Richard Cochran
2021-06-22 10:17 ` Y.b. Lu
2021-06-15 9:45 ` [net-next, v3, 02/10] ptp: support ptp physical/virtual clocks conversion Yangbo Lu
2021-06-17 17:42 ` Richard Cochran
2021-06-22 10:18 ` Y.b. Lu
2021-06-17 18:27 ` Richard Cochran
2021-06-22 10:35 ` Y.b. Lu
2021-06-25 11:09 ` Y.b. Lu
2021-06-19 4:06 ` Richard Cochran
2021-06-22 10:39 ` Y.b. Lu [this message]
2021-06-15 9:45 ` [net-next, v3, 03/10] ptp: track available ptp vclocks information Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 04/10] ptp: add kernel API ptp_get_vclocks_index() Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 05/10] ethtool: add a new command for getting PHC virtual clocks Yangbo Lu
2021-06-15 19:49 ` Jakub Kicinski
2021-06-22 10:10 ` Y.b. Lu
2021-06-15 23:24 ` Michal Kubecek
2021-06-22 10:10 ` Y.b. Lu
2021-06-15 9:45 ` [net-next, v3, 06/10] ptp: add kernel API ptp_convert_timestamp() Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 07/10] net: sock: extend SO_TIMESTAMPING for PHC binding Yangbo Lu
2021-06-16 1:00 ` Mat Martineau
2021-06-22 10:14 ` Y.b. Lu
2021-06-16 10:27 ` kernel test robot
2021-06-16 10:27 ` kernel test robot
2021-06-16 10:39 ` kernel test robot
2021-06-16 10:39 ` kernel test robot
2021-06-15 9:45 ` [net-next, v3, 08/10] net: socket: support hardware timestamp conversion to PHC bound Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 09/10] selftests/net: timestamping: support binding PHC Yangbo Lu
2021-06-15 9:45 ` [net-next, v3, 10/10] MAINTAINERS: add entry for PTP virtual clock driver Yangbo Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR04MB501756892A5B773671ABD044F8099@DB7PR04MB5017.eurprd04.prod.outlook.com \
--to=yangbo.lu@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mkubecek@suse.cz \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=rui.sousa@nxp.com \
--cc=sebastien.laveze@nxp.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.