From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Haifei Luo <haifeil@nvidia.com>,
"matan@nvidia.com" <matan@nvidia.com>,
"orika@nvidia.com" <orika@nvidia.com>,
"viacheslavo@nvidia.com" <viacheslavo@nvidia.com>,
"Li, Xiaoyun" <xiaoyun.li@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"rasland@nvidia.com" <rasland@nvidia.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add CLI for action meter color
Date: Tue, 11 May 2021 12:34:08 +0000 [thread overview]
Message-ID: <DM6PR11MB279603D51F64B11AAF43DF53EB539@DM6PR11MB2796.namprd11.prod.outlook.com> (raw)
In-Reply-To: <c34ad552-b919-5ecf-1646-92f75f6f9c54@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Tuesday, May 11, 2021 12:35 PM
> To: Haifei Luo <haifeil@nvidia.com>; matan@nvidia.com; orika@nvidia.com;
> viacheslavo@nvidia.com; Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; rasland@nvidia.com; Singh,
> Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: Re: [PATCH v2] app/testpmd: add CLI for action meter color
>
> On 5/11/2021 10:28 AM, Haifei Luo wrote:
> > Currently action RTE_FLOW_ACTION_TYPE_METER_COLOR is defined.
> > Add the CLI for this action in meter policy: color type (types)
> > There are three types: green, yellow and red.
> >
> > Example for the new policy meter CLIs:
> > add port meter policy 0 1 g_actions color type green / end y_actions
> > color type yellow / end r_actions color type red / end
> >
> > In the above command, the action type is
> RTE_FLOW_ACTION_TYPE_METER_COLOR,
> > the meter policy action list: green -> green, yellow -> yellow, red -> red.
> >
> > V2: rebase the latest code.
> >
> > Signed-off-by: Haifei Luo <haifeil@nvidia.com>
> > Acked-by: Ori Kam <orika@nvidia.com>
>
>
> cc'ed Jasvinder & Cristian for review.
>
> This patch is not a fix but adding support for testing new meter action type,
> so
> I assume it can be postponed to next release if missing review from
> maintainers.
Hi Ferruh,
This patch looks good to me, but I think it should be reviewed and acked by Xiaoyun, the testpmd maintainer, who is already in the To: list?
Regards,
Cristian
next prev parent reply other threads:[~2021-05-11 12:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 14:10 [dpdk-dev] [PATCH] app/testpmd: support meter color action in policy Haifei Luo
2021-04-30 12:50 ` Ferruh Yigit
2021-05-03 12:11 ` Dumitrescu, Cristian
2021-05-05 15:42 ` Ori Kam
2021-05-11 9:28 ` [dpdk-dev] [PATCH v2] app/testpmd: add CLI for action meter color Haifei Luo
2021-05-11 11:35 ` Ferruh Yigit
2021-05-11 12:34 ` Dumitrescu, Cristian [this message]
2021-05-11 13:20 ` Ferruh Yigit
2021-05-12 19:54 ` Dumitrescu, Cristian
2021-05-11 19:22 ` Ferruh Yigit
2021-05-12 1:41 ` Haifei Luo
2021-05-12 7:03 ` Haifei Luo
2021-05-12 7:02 ` [dpdk-dev] [PATCH v3] " Haifei Luo
2021-05-12 8:33 ` Ferruh Yigit
2021-05-12 10:49 ` [dpdk-dev] [PATCH v4] " Haifei Luo
2021-05-12 11:40 ` Ferruh Yigit
2021-05-12 12:08 ` Ferruh Yigit
2021-05-12 12:19 ` [dpdk-dev] [PATCH v5] " Haifei Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB279603D51F64B11AAF43DF53EB539@DM6PR11MB2796.namprd11.prod.outlook.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haifeil@nvidia.com \
--cc=jasvinder.singh@intel.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.