All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] drm/amd/display: remove "setting DIG_MODE twice" workaround
@ 2019-11-04 16:06 ` Liu, Zhan
  0 siblings, 0 replies; 8+ messages in thread
From: Liu, Zhan @ 2019-11-04 16:06 UTC (permalink / raw
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Wu, Hersen, Liu, Zhan

[Why]
The root cause of Navi14 HDMI pink screen issue has been found.
There is no need to set DIG_MODE twice anymore.

[How]
Remove "setting DIG_MODE" twice workaround.

Signed-off-by: Zhan Liu <zhan.liu@amd.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc_link.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index cc94c1a73daa..12ba6fdf89b7 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -3027,15 +3027,6 @@ void core_link_enable_stream(
                                        CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,
                                        COLOR_DEPTH_UNDEFINED);

-               /* This second call is needed to reconfigure the DIG
-                * as a workaround for the incorrect value being applied
-                * from transmitter control.
-                */
-               if (!dc_is_virtual_signal(pipe_ctx->stream->signal))
-                       stream->link->link_enc->funcs->setup(
-                               stream->link->link_enc,
-                               pipe_ctx->stream->signal);
-
 #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
                if (pipe_ctx->stream->timing.flags.DSC) {
                        if (dc_is_dp_signal(pipe_ctx->stream->signal) ||
--
2.21.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

• * [PATCH] drm/amd/display: remove "setting DIG_MODE twice" workaround
  @ 2019-11-04 16:06 ` Liu, Zhan
    0 siblings, 0 replies; 8+ messages in thread
  From: Liu, Zhan @ 2019-11-04 16:06 UTC (permalink / raw
    To: amd-gfx@lists.freedesktop.org, Wu, Hersen, Liu, Zhan
  
  [Why]
  The root cause of Navi14 HDMI pink screen issue has been found.
  There is no need to set DIG_MODE twice anymore.
  
  [How]
  Remove "setting DIG_MODE" twice workaround.
  
  Signed-off-by: Zhan Liu <zhan.liu@amd.com>
  ---
   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 9 ---------
   1 file changed, 9 deletions(-)
  
  diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
  index cc94c1a73daa..12ba6fdf89b7 100644
  --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
  +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
  @@ -3027,15 +3027,6 @@ void core_link_enable_stream(
                                          CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,
                                          COLOR_DEPTH_UNDEFINED);
  
  -               /* This second call is needed to reconfigure the DIG
  -                * as a workaround for the incorrect value being applied
  -                * from transmitter control.
  -                */
  -               if (!dc_is_virtual_signal(pipe_ctx->stream->signal))
  -                       stream->link->link_enc->funcs->setup(
  -                               stream->link->link_enc,
  -                               pipe_ctx->stream->signal);
  -
   #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
                  if (pipe_ctx->stream->timing.flags.DSC) {
                          if (dc_is_dp_signal(pipe_ctx->stream->signal) ||
  --
  2.21.0
  _______________________________________________
  amd-gfx mailing list
  amd-gfx@lists.freedesktop.org
  https://lists.freedesktop.org/mailman/listinfo/amd-gfx
  
  ^ permalink raw reply related	[flat|nested] 8+ messages in thread

• [parent not found: <DM6PR12MB3466E5EF19CE8BBD78AC6BBE9E7F0-lmeGfMZKVrFD9+oK+SxdZAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]

• • * Re: [PATCH] drm/amd/display: remove "setting DIG_MODE twice" workaround
    @ 2019-11-04 16:52     ` Kazlauskas, Nicholas
      0 siblings, 0 replies; 8+ messages in thread
    From: Kazlauskas, Nicholas @ 2019-11-04 16:52 UTC (permalink / raw
      To: Liu, Zhan,
    	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
    	Wu, Hersen
    
    On 2019-11-04 11:06 a.m., Liu, Zhan wrote:
    > [Why]
    > The root cause of Navi14 HDMI pink screen issue has been found.
    > There is no need to set DIG_MODE twice anymore.
    > 
    > [How]
    > Remove "setting DIG_MODE" twice workaround.
    > 
    > Signed-off-by: Zhan Liu <zhan.liu@amd.com>
    
    Please use git to revert the commit instead:
    
    eg.
    
    git revert <SHA>
    
    Then add the reasoning to the revert commit message.
    
    Thanks,
    
    Nicholas Kazlauskas
    
    > ---
    >   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 9 ---------
    >   1 file changed, 9 deletions(-)
    > 
    > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
    > index cc94c1a73daa..12ba6fdf89b7 100644
    > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
    > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
    > @@ -3027,15 +3027,6 @@ void core_link_enable_stream(
    >                                          CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,
    >                                          COLOR_DEPTH_UNDEFINED);
    > 
    > -               /* This second call is needed to reconfigure the DIG
    > -                * as a workaround for the incorrect value being applied
    > -                * from transmitter control.
    > -                */
    > -               if (!dc_is_virtual_signal(pipe_ctx->stream->signal))
    > -                       stream->link->link_enc->funcs->setup(
    > -                               stream->link->link_enc,
    > -                               pipe_ctx->stream->signal);
    > -
    >   #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
    >                  if (pipe_ctx->stream->timing.flags.DSC) {
    >                          if (dc_is_dp_signal(pipe_ctx->stream->signal) ||
    > --
    > 2.21.0
    > _______________________________________________
    > amd-gfx mailing list
    > amd-gfx@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
    > 
    
    _______________________________________________
    amd-gfx mailing list
    amd-gfx@lists.freedesktop.org
    https://lists.freedesktop.org/mailman/listinfo/amd-gfx
    
    ^ permalink raw reply	[flat|nested] 8+ messages in thread

  • • * Re: [PATCH] drm/amd/display: remove "setting DIG_MODE twice" workaround
      @ 2019-11-04 16:52     ` Kazlauskas, Nicholas
        0 siblings, 0 replies; 8+ messages in thread
      From: Kazlauskas, Nicholas @ 2019-11-04 16:52 UTC (permalink / raw
        To: Liu, Zhan, amd-gfx@lists.freedesktop.org, Wu, Hersen
      
      On 2019-11-04 11:06 a.m., Liu, Zhan wrote:
      > [Why]
      > The root cause of Navi14 HDMI pink screen issue has been found.
      > There is no need to set DIG_MODE twice anymore.
      > 
      > [How]
      > Remove "setting DIG_MODE" twice workaround.
      > 
      > Signed-off-by: Zhan Liu <zhan.liu@amd.com>
      
      Please use git to revert the commit instead:
      
      eg.
      
      git revert <SHA>
      
      Then add the reasoning to the revert commit message.
      
      Thanks,
      
      Nicholas Kazlauskas
      
      > ---
      >   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 9 ---------
      >   1 file changed, 9 deletions(-)
      > 
      > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
      > index cc94c1a73daa..12ba6fdf89b7 100644
      > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
      > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
      > @@ -3027,15 +3027,6 @@ void core_link_enable_stream(
      >                                          CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,
      >                                          COLOR_DEPTH_UNDEFINED);
      > 
      > -               /* This second call is needed to reconfigure the DIG
      > -                * as a workaround for the incorrect value being applied
      > -                * from transmitter control.
      > -                */
      > -               if (!dc_is_virtual_signal(pipe_ctx->stream->signal))
      > -                       stream->link->link_enc->funcs->setup(
      > -                               stream->link->link_enc,
      > -                               pipe_ctx->stream->signal);
      > -
      >   #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
      >                  if (pipe_ctx->stream->timing.flags.DSC) {
      >                          if (dc_is_dp_signal(pipe_ctx->stream->signal) ||
      > --
      > 2.21.0
      > _______________________________________________
      > amd-gfx mailing list
      > amd-gfx@lists.freedesktop.org
      > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
      > 
      
      _______________________________________________
      amd-gfx mailing list
      amd-gfx@lists.freedesktop.org
      https://lists.freedesktop.org/mailman/listinfo/amd-gfx
      
      ^ permalink raw reply	[flat|nested] 8+ messages in thread

    • [parent not found: <9d0a0e07-f68a-8e93-3003-f19ca056b2ff-5C7GfCeVMHo@public.gmane.org>]

    • • * RE: [PATCH] drm/amd/display: remove "setting DIG_MODE twice" workaround
        @ 2019-11-04 19:49         ` Liu, Zhan
          0 siblings, 0 replies; 8+ messages in thread
        From: Liu, Zhan @ 2019-11-04 19:49 UTC (permalink / raw
          To: Kazlauskas, Nicholas,
        	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
        	Wu, Hersen
        
        Thank you Nick for the advice. I just reverted the original commit.
        
        Zhan
        
        > -----Original Message-----
        > From: Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>
        > Sent: 2019/November/04, Monday 11:53 AM
        > To: Liu, Zhan <Zhan.Liu@amd.com>; amd-gfx@lists.freedesktop.org; Wu,
        > Hersen <hersenxs.wu@amd.com>
        > Subject: Re: [PATCH] drm/amd/display: remove "setting DIG_MODE twice"
        > workaround
        > 
        > On 2019-11-04 11:06 a.m., Liu, Zhan wrote:
        > > [Why]
        > > The root cause of Navi14 HDMI pink screen issue has been found.
        > > There is no need to set DIG_MODE twice anymore.
        > >
        > > [How]
        > > Remove "setting DIG_MODE" twice workaround.
        > >
        > > Signed-off-by: Zhan Liu <zhan.liu@amd.com>
        > 
        > Please use git to revert the commit instead:
        > 
        > eg.
        > 
        > git revert <SHA>
        > 
        > Then add the reasoning to the revert commit message.
        > 
        > Thanks,
        > 
        > Nicholas Kazlauskas
        > 
        > > ---
        > >   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 9 ---------
        > >   1 file changed, 9 deletions(-)
        > >
        > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
        > b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
        > > index cc94c1a73daa..12ba6fdf89b7 100644
        > > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
        > > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
        > > @@ -3027,15 +3027,6 @@ void core_link_enable_stream(
        > >                                          CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,
        > >                                          COLOR_DEPTH_UNDEFINED);
        > >
        > > -               /* This second call is needed to reconfigure the DIG
        > > -                * as a workaround for the incorrect value being applied
        > > -                * from transmitter control.
        > > -                */
        > > -               if (!dc_is_virtual_signal(pipe_ctx->stream->signal))
        > > -                       stream->link->link_enc->funcs->setup(
        > > -                               stream->link->link_enc,
        > > -                               pipe_ctx->stream->signal);
        > > -
        > >   #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
        > >                  if (pipe_ctx->stream->timing.flags.DSC) {
        > >                          if (dc_is_dp_signal(pipe_ctx->stream->signal) ||
        > > --
        > > 2.21.0
        > > _______________________________________________
        > > amd-gfx mailing list
        > > amd-gfx@lists.freedesktop.org
        > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
        > >
        
        _______________________________________________
        amd-gfx mailing list
        amd-gfx@lists.freedesktop.org
        https://lists.freedesktop.org/mailman/listinfo/amd-gfx
        
        ^ permalink raw reply	[flat|nested] 8+ messages in thread

      • • * RE: [PATCH] drm/amd/display: remove "setting DIG_MODE twice" workaround
          @ 2019-11-04 19:49         ` Liu, Zhan
            0 siblings, 0 replies; 8+ messages in thread
          From: Liu, Zhan @ 2019-11-04 19:49 UTC (permalink / raw
            To: Kazlauskas, Nicholas, amd-gfx@lists.freedesktop.org, Wu, Hersen
          
          Thank you Nick for the advice. I just reverted the original commit.
          
          Zhan
          
          > -----Original Message-----
          > From: Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>
          > Sent: 2019/November/04, Monday 11:53 AM
          > To: Liu, Zhan <Zhan.Liu@amd.com>; amd-gfx@lists.freedesktop.org; Wu,
          > Hersen <hersenxs.wu@amd.com>
          > Subject: Re: [PATCH] drm/amd/display: remove "setting DIG_MODE twice"
          > workaround
          > 
          > On 2019-11-04 11:06 a.m., Liu, Zhan wrote:
          > > [Why]
          > > The root cause of Navi14 HDMI pink screen issue has been found.
          > > There is no need to set DIG_MODE twice anymore.
          > >
          > > [How]
          > > Remove "setting DIG_MODE" twice workaround.
          > >
          > > Signed-off-by: Zhan Liu <zhan.liu@amd.com>
          > 
          > Please use git to revert the commit instead:
          > 
          > eg.
          > 
          > git revert <SHA>
          > 
          > Then add the reasoning to the revert commit message.
          > 
          > Thanks,
          > 
          > Nicholas Kazlauskas
          > 
          > > ---
          > >   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 9 ---------
          > >   1 file changed, 9 deletions(-)
          > >
          > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
          > b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
          > > index cc94c1a73daa..12ba6fdf89b7 100644
          > > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
          > > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
          > > @@ -3027,15 +3027,6 @@ void core_link_enable_stream(
          > >                                          CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,
          > >                                          COLOR_DEPTH_UNDEFINED);
          > >
          > > -               /* This second call is needed to reconfigure the DIG
          > > -                * as a workaround for the incorrect value being applied
          > > -                * from transmitter control.
          > > -                */
          > > -               if (!dc_is_virtual_signal(pipe_ctx->stream->signal))
          > > -                       stream->link->link_enc->funcs->setup(
          > > -                               stream->link->link_enc,
          > > -                               pipe_ctx->stream->signal);
          > > -
          > >   #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
          > >                  if (pipe_ctx->stream->timing.flags.DSC) {
          > >                          if (dc_is_dp_signal(pipe_ctx->stream->signal) ||
          > > --
          > > 2.21.0
          > > _______________________________________________
          > > amd-gfx mailing list
          > > amd-gfx@lists.freedesktop.org
          > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
          > >
          
          _______________________________________________
          amd-gfx mailing list
          amd-gfx@lists.freedesktop.org
          https://lists.freedesktop.org/mailman/listinfo/amd-gfx
          
          ^ permalink raw reply	[flat|nested] 8+ messages in thread

        • [parent not found: <DM6PR12MB34661BBB5BF6989CF63389D19E7F0-lmeGfMZKVrFD9+oK+SxdZAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]

        • • * Re: [PATCH] drm/amd/display: remove "setting DIG_MODE twice" workaround
            @ 2019-11-04 20:02             ` Kazlauskas, Nicholas
              0 siblings, 0 replies; 8+ messages in thread
            From: Kazlauskas, Nicholas @ 2019-11-04 20:02 UTC (permalink / raw
              To: Liu, Zhan,
            	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
            	Wu, Hersen
            
            On 2019-11-04 2:49 p.m., Liu, Zhan wrote:
            > Thank you Nick for the advice. I just reverted the original commit.
            > 
            > Zhan
            
            The revert still needs code review.
            
            Nicholas Kazlauskas
            
            > 
            >> -----Original Message-----
            >> From: Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>
            >> Sent: 2019/November/04, Monday 11:53 AM
            >> To: Liu, Zhan <Zhan.Liu@amd.com>; amd-gfx@lists.freedesktop.org; Wu,
            >> Hersen <hersenxs.wu@amd.com>
            >> Subject: Re: [PATCH] drm/amd/display: remove "setting DIG_MODE twice"
            >> workaround
            >>
            >> On 2019-11-04 11:06 a.m., Liu, Zhan wrote:
            >>> [Why]
            >>> The root cause of Navi14 HDMI pink screen issue has been found.
            >>> There is no need to set DIG_MODE twice anymore.
            >>>
            >>> [How]
            >>> Remove "setting DIG_MODE" twice workaround.
            >>>
            >>> Signed-off-by: Zhan Liu <zhan.liu@amd.com>
            >>
            >> Please use git to revert the commit instead:
            >>
            >> eg.
            >>
            >> git revert <SHA>
            >>
            >> Then add the reasoning to the revert commit message.
            >>
            >> Thanks,
            >>
            >> Nicholas Kazlauskas
            >>
            >>> ---
            >>>    drivers/gpu/drm/amd/display/dc/core/dc_link.c | 9 ---------
            >>>    1 file changed, 9 deletions(-)
            >>>
            >>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
            >> b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
            >>> index cc94c1a73daa..12ba6fdf89b7 100644
            >>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
            >>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
            >>> @@ -3027,15 +3027,6 @@ void core_link_enable_stream(
            >>>                                           CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,
            >>>                                           COLOR_DEPTH_UNDEFINED);
            >>>
            >>> -               /* This second call is needed to reconfigure the DIG
            >>> -                * as a workaround for the incorrect value being applied
            >>> -                * from transmitter control.
            >>> -                */
            >>> -               if (!dc_is_virtual_signal(pipe_ctx->stream->signal))
            >>> -                       stream->link->link_enc->funcs->setup(
            >>> -                               stream->link->link_enc,
            >>> -                               pipe_ctx->stream->signal);
            >>> -
            >>>    #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
            >>>                   if (pipe_ctx->stream->timing.flags.DSC) {
            >>>                           if (dc_is_dp_signal(pipe_ctx->stream->signal) ||
            >>> --
            >>> 2.21.0
            >>> _______________________________________________
            >>> amd-gfx mailing list
            >>> amd-gfx@lists.freedesktop.org
            >>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
            >>>
            > 
            
            _______________________________________________
            amd-gfx mailing list
            amd-gfx@lists.freedesktop.org
            https://lists.freedesktop.org/mailman/listinfo/amd-gfx
            
            ^ permalink raw reply	[flat|nested] 8+ messages in thread

          • • * Re: [PATCH] drm/amd/display: remove "setting DIG_MODE twice" workaround
              @ 2019-11-04 20:02             ` Kazlauskas, Nicholas
                0 siblings, 0 replies; 8+ messages in thread
              From: Kazlauskas, Nicholas @ 2019-11-04 20:02 UTC (permalink / raw
                To: Liu, Zhan, amd-gfx@lists.freedesktop.org, Wu, Hersen
              
              On 2019-11-04 2:49 p.m., Liu, Zhan wrote:
              > Thank you Nick for the advice. I just reverted the original commit.
              > 
              > Zhan
              
              The revert still needs code review.
              
              Nicholas Kazlauskas
              
              > 
              >> -----Original Message-----
              >> From: Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>
              >> Sent: 2019/November/04, Monday 11:53 AM
              >> To: Liu, Zhan <Zhan.Liu@amd.com>; amd-gfx@lists.freedesktop.org; Wu,
              >> Hersen <hersenxs.wu@amd.com>
              >> Subject: Re: [PATCH] drm/amd/display: remove "setting DIG_MODE twice"
              >> workaround
              >>
              >> On 2019-11-04 11:06 a.m., Liu, Zhan wrote:
              >>> [Why]
              >>> The root cause of Navi14 HDMI pink screen issue has been found.
              >>> There is no need to set DIG_MODE twice anymore.
              >>>
              >>> [How]
              >>> Remove "setting DIG_MODE" twice workaround.
              >>>
              >>> Signed-off-by: Zhan Liu <zhan.liu@amd.com>
              >>
              >> Please use git to revert the commit instead:
              >>
              >> eg.
              >>
              >> git revert <SHA>
              >>
              >> Then add the reasoning to the revert commit message.
              >>
              >> Thanks,
              >>
              >> Nicholas Kazlauskas
              >>
              >>> ---
              >>>    drivers/gpu/drm/amd/display/dc/core/dc_link.c | 9 ---------
              >>>    1 file changed, 9 deletions(-)
              >>>
              >>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
              >> b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
              >>> index cc94c1a73daa..12ba6fdf89b7 100644
              >>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
              >>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
              >>> @@ -3027,15 +3027,6 @@ void core_link_enable_stream(
              >>>                                           CONTROLLER_DP_TEST_PATTERN_VIDEOMODE,
              >>>                                           COLOR_DEPTH_UNDEFINED);
              >>>
              >>> -               /* This second call is needed to reconfigure the DIG
              >>> -                * as a workaround for the incorrect value being applied
              >>> -                * from transmitter control.
              >>> -                */
              >>> -               if (!dc_is_virtual_signal(pipe_ctx->stream->signal))
              >>> -                       stream->link->link_enc->funcs->setup(
              >>> -                               stream->link->link_enc,
              >>> -                               pipe_ctx->stream->signal);
              >>> -
              >>>    #ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
              >>>                   if (pipe_ctx->stream->timing.flags.DSC) {
              >>>                           if (dc_is_dp_signal(pipe_ctx->stream->signal) ||
              >>> --
              >>> 2.21.0
              >>> _______________________________________________
              >>> amd-gfx mailing list
              >>> amd-gfx@lists.freedesktop.org
              >>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
              >>>
              > 
              
              _______________________________________________
              amd-gfx mailing list
              amd-gfx@lists.freedesktop.org
              https://lists.freedesktop.org/mailman/listinfo/amd-gfx
              
              ^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-11-04 20:02 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-04 16:06 [PATCH] drm/amd/display: remove "setting DIG_MODE twice" workaround Liu, Zhan
2019-11-04 16:06 ` Liu, Zhan
     [not found] ` <DM6PR12MB3466E5EF19CE8BBD78AC6BBE9E7F0-lmeGfMZKVrFD9+oK+SxdZAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-11-04 16:52   ` Kazlauskas, Nicholas
2019-11-04 16:52     ` Kazlauskas, Nicholas
     [not found]     ` <9d0a0e07-f68a-8e93-3003-f19ca056b2ff-5C7GfCeVMHo@public.gmane.org>
2019-11-04 19:49       ` Liu, Zhan
2019-11-04 19:49         ` Liu, Zhan
     [not found]         ` <DM6PR12MB34661BBB5BF6989CF63389D19E7F0-lmeGfMZKVrFD9+oK+SxdZAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-11-04 20:02           ` Kazlauskas, Nicholas
2019-11-04 20:02             ` Kazlauskas, Nicholas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.