From: "Bhatt, Jigar" <jigar.bhatt@intel.com>
To: "Gupta, Anshuman" <anshuman.gupta@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Cc: "Varide, Nischal" <nischal.varide@intel.com>,
"Shankar, Uma" <uma.shankar@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t RFC] tests/i915/i915_pm_dc: Fix DC9 test
Date: Thu, 5 Aug 2021 04:01:37 +0000 [thread overview]
Message-ID: <DM8PR11MB5608AA460CAB3B055D9B3393FDF29@DM8PR11MB5608.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ac9b2064c690417c8c0ef6cab1ff55e6@intel.com>
Hi Anshuman,
-----Original Message-----
From: Gupta, Anshuman <anshuman.gupta@intel.com>
Sent: Wednesday, August 4, 2021 11:21 AM
To: Bhatt, Jigar <jigar.bhatt@intel.com>; igt-dev@lists.freedesktop.org
Cc: Varide, Nischal <nischal.varide@intel.com>; Shankar, Uma <uma.shankar@intel.com>
Subject: RE: [PATCH i-g-t RFC] tests/i915/i915_pm_dc: Fix DC9 test
> -----Original Message-----
> From: Bhatt, Jigar <jigar.bhatt@intel.com>
> Sent: Thursday, July 29, 2021 6:50 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Bhatt, Jigar <jigar.bhatt@intel.com>; Varide, Nischal
> <nischal.varide@intel.com>; Gupta, Anshuman
> <anshuman.gupta@intel.com>; Shankar, Uma <uma.shankar@intel.com>
> Subject: [PATCH i-g-t RFC] tests/i915/i915_pm_dc: Fix DC9 test
>
Please use the standard patch header format.
> 1. Currently, check_dc9 is being called with reference
> (previous) counter being read after dpms_off call.
> At this time, already the counter is 0.
> We need to read the counter before dpms_off is called so that it holds
> the previous value which had incremented while testing shallow states (DC5 or DC6).
>
> 2. Check for a condition dc counter to be reset along with system
> should in runtime suspend state :
> currect_dc < prev_dc && i915 runtime status == SUSPENDED.
> If above condition pass, test is passed otherwise test is failed.
>
> 3. adding dc9_dpms_off()
>
> Signed-off-by: Jigar Bhatt <jigar.bhatt@intel.com>
> ---
> tests/i915/i915_pm_dc.c | 25 +++++++++++++++++++------
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
> diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index
> 9d0a15d81..a6fddb617 100644
> --- a/tests/i915/i915_pm_dc.c
> +++ b/tests/i915/i915_pm_dc.c
> @@ -358,6 +358,15 @@ static void dpms_off(data_t *data)
> (IGT_RUNTIME_PM_STATUS_SUSPENDED));
> }
>
> +static void dc9_dpms_off(data_t *data) { for (int i = 0; i <
> +data->display.n_outputs; i++) {
> +kmstest_set_connector_dpms(data->drm_fd,
> + data-
> >display.outputs[i].config.connector,
> + DRM_MODE_DPMS_OFF);
> +}
> +}
> +
> static void dpms_on(data_t *data)
> {
> for (int i = 0; i < data->display.n_outputs; i++) { @@ -400,8 +409,11
> @@ static bool check_dc9(uint32_t debugfs_fd, int prev_dc, bool dc6_supported, int
> * so we rely on dc5/dc6 counter reset to check if display engine was
> in DC9.
> */
> return igt_wait(dc6_supported ? read_dc_counter(debugfs_fd,
> CHECK_DC6) <
> -prev_dc : read_dc_counter(debugfs_fd, CHECK_DC5) < -prev_dc, seconds,
> 100);
> +prev_dc &&
> +
> igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Don't use igt_wait_for_pm_status here , it waits for 10 seconds internally.
We just need i915 runtime pm status and that should check against suspended.
This will waste may CI cycles.
Br,
Anshuman
If we are not using this igt_wait_for_status then it will check status only one time and mostly it has active status.
and after dpms_off it will take some time to be suspended that's why this igt_wait_for_status has
max 10 sec wait loop if status == SUSPENDED then it will automatically getting out of waiting time(10 sec).
If we only depend on i915 runtime status after immediate DPMS_OFF then it will take some milliseconds for getting SUSPENDED.
Thanks and Regards,
Jigar Bhatt
> +: read_dc_counter(debugfs_fd, CHECK_DC5) < prev_dc
> &&
> +
> igt_wait_for_pm_status(IGT_RUNTIME_STATUS_PM_SUSPENDED)
> +, seconds, 100);
> }
>
> static void setup_dc9_dpms(data_t *data, int prev_dc, bool
> dc6_supported) @@ -418,15 +430,16 @@ static void setup_dc9_dpms(data_t
> *data, int prev_dc, bool dc6_supported) static void
> test_dc9_dpms(data_t *data) { bool dc6_supported;
> +int prev_dc;
>
> require_dc_counter(data->debugfs_fd, CHECK_DC5); dc6_supported =
> support_dc6(data->debugfs_fd); setup_dc9_dpms(data, dc6_supported ?
> read_dc_counter(data-
> >debugfs_fd, CHECK_DC6) :
> read_dc_counter(data->debugfs_fd, CHECK_DC5), dc6_supported);
> -dpms_off(data); -igt_assert_f(check_dc9(data->debugfs_fd,
> dc6_supported ?
> -read_dc_counter(data->debugfs_fd,
> CHECK_DC6) :
> -read_dc_counter(data->debugfs_fd,
> CHECK_DC5),
> +prev_dc = dc6_supported ? read_dc_counter(data->debugfs_fd,
> CHECK_DC6) :
> +read_dc_counter(data->debugfs_fd, CHECK_DC5); dc9_dpms_off(data);
> +igt_assert_f(check_dc9(data->debugfs_fd, prev_dc,
> dc6_supported, 3000), "Not in DC9\n"); dpms_on(data); }
> --
> 2.25.1
next prev parent reply other threads:[~2021-08-05 4:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 13:20 [igt-dev] [PATCH i-g-t RFC] tests/i915/i915_pm_dc: Fix DC9 test Jigar Bhatt
2021-07-29 13:24 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
2021-07-29 14:26 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2021-08-04 5:51 ` [igt-dev] [PATCH i-g-t RFC] " Gupta, Anshuman
2021-08-05 4:01 ` Bhatt, Jigar [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-29 14:41 Jigar Bhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB5608AA460CAB3B055D9B3393FDF29@DM8PR11MB5608.namprd11.prod.outlook.com \
--to=jigar.bhatt@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=nischal.varide@intel.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.