From: "Khor, Swee Aun" <swee.aun.khor@intel.com>
To: Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: "Romli, Khairul Anuar" <khairul.anuar.romli@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Kasireddy, Vivek" <vivek.kasireddy@intel.com>
Subject: RE: [PATCH] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option
Date: Wed, 16 Jun 2021 01:28:08 +0000 [thread overview]
Message-ID: <DM8PR11MB57179B0933C04DD48CA487FCAF0F9@DM8PR11MB5717.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87o8c8wkwn.fsf@dusky.pond.sub.org>
Thanks for review and feedback. I shall rework those in v2.
Regards,
SweeAun
-----Original Message-----
From: Markus Armbruster <armbru@redhat.com>
Sent: Monday, June 14, 2021 11:01 PM
To: Eric Blake <eblake@redhat.com>
Cc: Khor, Swee Aun <swee.aun.khor@intel.com>; Romli, Khairul Anuar <khairul.anuar.romli@intel.com>; qemu-devel@nongnu.org; Kasireddy, Vivek <vivek.kasireddy@intel.com>
Subject: Re: [PATCH] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option
Eric Blake <eblake@redhat.com> writes:
> On Mon, Jun 14, 2021 at 04:05:42PM +0800, sweeaun wrote:
>> -display gtk,monitor-num=<value>
>>
>> Signed-off-by: sweeaun <swee.aun.khor@intel.com>
>> ---
>> qapi/ui.json | 3 ++-
>> qemu-options.hx | 2 +-
>> ui/gtk.c | 15 +++++++++++++++
>> 3 files changed, 18 insertions(+), 2 deletions(-)
>>
>> diff --git a/qapi/ui.json b/qapi/ui.json index 1052ca9c38..c3363c7ad5
>> 100644
>> --- a/qapi/ui.json
>> +++ b/qapi/ui.json
>> @@ -1041,7 +1041,8 @@
>> ##
>> { 'struct' : 'DisplayGTK',
>> 'data' : { '*grab-on-hover' : 'bool',
>> - '*zoom-to-fit' : 'bool' } }
>> + '*zoom-to-fit' : 'bool',
>> + '*monitor-num' : 'int' } }
>
> Missing documentation of the new member. Also, get rid of the tab damage.
Suggest to name it either @monitor-number or @monitor (because what else than the number could 'int' be?)
prev parent reply other threads:[~2021-06-16 1:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 8:05 [PATCH] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option sweeaun
2021-06-14 14:11 ` Eric Blake
2021-06-14 15:00 ` Markus Armbruster
2021-06-16 1:28 ` Khor, Swee Aun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB57179B0933C04DD48CA487FCAF0F9@DM8PR11MB5717.namprd11.prod.outlook.com \
--to=swee.aun.khor@intel.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=khairul.anuar.romli@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.