From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v6 08/10] hash: remove duplicated code
Date: Tue, 16 Jun 2015 10:31:58 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897272BC0FD@IRSMSX108.ger.corp.intel.com>
References: <1432289771-12799-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1433949927-14767-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1433949927-14767-9-git-send-email-pablo.de.lara.guarch@intel.com>
 <1675380.IejOcZZ0JH@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id E3AC211C5
 for <dev@dpdk.org>; Tue, 16 Jun 2015 12:32:01 +0200 (CEST)
In-Reply-To: <1675380.IejOcZZ0JH@xps13>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, June 16, 2015 10:33 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 08/10] hash: remove duplicated code
>=20
> The following patch is needed and will be squashed to fix some doxygen
> issues:
>=20
> --- a/lib/librte_hash/rte_jhash.h
> +++ b/lib/librte_hash/rte_jhash.h
> @@ -306,13 +306,13 @@ rte_jhash2(const uint32_t *k, uint32_t length,
> uint32_t initval)
>   * with seeds. If you pass in (*pb)=3D0, the output (*pc) will be
>   * the same as the return value from rte_jhash.
>   *
> - * @param k
> + * @param key
>   *   Key to calculate hash of.
>   * @param length
>   *   Length of key in bytes.
>   * @param pc
>   *   IN: seed OUT: primary hash value.
> - * @param pc
> + * @param pb
>   *   IN: second seed OUT: secondary hash value.
>   */
>  static inline void
> @@ -464,7 +464,7 @@ rte_jhash_2hashes(const void *key, uint32_t length,
> uint32_t *pc, uint32_t *pb)
>   *   Length of key in units of 4 bytes.
>   * @param pc
>   *   IN: seed OUT: primary hash value.
> - * @param pc
> + * @param pb
>   *   IN: second seed OUT: secondary hash value.
>   */
>  static inline void

Thanks for spotting this!
Are you going to do it yourself or you want me to do it and send a v7?

Pablo