From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v4] Fixes following error on gcc 4.4.7:
Date: Wed, 9 Dec 2015 14:01:54 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C868946@IRSMSX108.ger.corp.intel.com>
References: <1449659374-78252-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1449663630-83289-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <C37D651A908B024F974696C65296B57B4BB83A5F@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: "Xie, Huawei" <huawei.xie@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id AD97B568B
 for <dev@dpdk.org>; Wed,  9 Dec 2015 15:02:18 +0100 (CET)
In-Reply-To: <C37D651A908B024F974696C65296B57B4BB83A5F@SHSMSX103.ccr.corp.intel.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Xie, Huawei
> Sent: Wednesday, December 09, 2015 1:29 PM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Cc: yuanhan.liu@linux.intel.com
> Subject: Re: [PATCH v4] Fixes following error on gcc 4.4.7:
>=20
> On 12/9/2015 8:20 PM, De Lara Guarch, Pablo wrote:
> > make: Entering directory `/tmp/dpdk-tmp/examples/vhost'
> >   CC main.o
> [...]
> > -	rte_ring_sc_dequeue(vpool->ring, (void **)&mbuf);
> > +	rte_ring_sc_dequeue(vpool->ring, (void *)mbuf);
> Here we are expecting the address of &mbuf, not mbuf, which is NULL.
> >  	if (unlikely(mbuf =3D=3D NULL)) {
> >  		LOG_DEBUG(VHOST_DATA,
> >  			"(%"PRIu64") in attach_rxmbuf_zcp: "
> > @@ -1801,7 +1801,7 @@ virtio_tx_route_zcp(struct virtio_net *dev,
> struct rte_mbuf *m,
> >
> >  	/* Allocate an mbuf and populate the structure. */
> >  	vpool =3D &vpool_array[MAX_QUEUES + vmdq_rx_q];
> > -	rte_ring_sc_dequeue(vpool->ring, (void **)&mbuf);
> > +	rte_ring_sc_dequeue(vpool->ring, (void *)mbuf);
> Same as above.
> >  	if (unlikely(mbuf =3D=3D NULL)) {
> >  		struct vhost_virtqueue *vq =3D dev->virtqueue[VIRTIO_TXQ];
> >  		RTE_LOG(ERR, VHOST_DATA,

Right, I will revert to v3 (and fix the title as well, sorry about that).