* [git:media_tree/devel] [media] v4l: omap3isp: Fix sub-device power management code
@ 2015-06-18 21:03 Mauro Carvalho Chehab
0 siblings, 0 replies; only message in thread
From: Mauro Carvalho Chehab @ 2015-06-18 21:03 UTC (permalink / raw
To: linuxtv-commits; +Cc: stable, Sakari Ailus, Laurent Pinchart
This is an automatic generated email to let you know that the following patch were queued at the
http://git.linuxtv.org/cgit.cgi/media_tree.git tree:
Subject: [media] v4l: omap3isp: Fix sub-device power management code
Author: Sakari Ailus <sakari.ailus@iki.fi>
Date: Fri Jun 12 20:06:23 2015 -0300
Commit 813f5c0ac5cc ("media: Change media device link_notify behaviour")
modified the media controller link setup notification API and updated the
OMAP3 ISP driver accordingly. As a side effect it introduced a bug by
turning power on after setting the link instead of before. This results in
sub-devices not being powered down in some cases when they should be. Fix
it.
Fixes: 813f5c0ac5cc [media] media: Change media device link_notify behaviour
Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Cc: stable@vger.kernel.org # since v3.10
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/platform/omap3isp/isp.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---
http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?id=c85e0031e41925194e2a27df6926533bbe59292a
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index d1334bb..12be830 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -829,14 +829,14 @@ static int isp_pipeline_link_notify(struct media_link *link, u32 flags,
int ret;
if (notification == MEDIA_DEV_NOTIFY_POST_LINK_CH &&
- !(link->flags & MEDIA_LNK_FL_ENABLED)) {
+ !(flags & MEDIA_LNK_FL_ENABLED)) {
/* Powering off entities is assumed to never fail. */
isp_pipeline_pm_power(source, -sink_use);
isp_pipeline_pm_power(sink, -source_use);
return 0;
}
- if (notification == MEDIA_DEV_NOTIFY_POST_LINK_CH &&
+ if (notification == MEDIA_DEV_NOTIFY_PRE_LINK_CH &&
(flags & MEDIA_LNK_FL_ENABLED)) {
ret = isp_pipeline_pm_power(source, sink_use);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-18 21:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-18 21:03 [git:media_tree/devel] [media] v4l: omap3isp: Fix sub-device power management code Mauro Carvalho Chehab
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.