From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16F72C3F6B0 for ; Thu, 28 Jul 2022 08:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235310AbiG1I6S (ORCPT ); Thu, 28 Jul 2022 04:58:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235306AbiG1I6J (ORCPT ); Thu, 28 Jul 2022 04:58:09 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2124.outbound.protection.outlook.com [40.107.117.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0442D655AD; Thu, 28 Jul 2022 01:58:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YtdM/ZgphjuSak81Xq4Ethp7VS4a33xqAzgtVAKtNyHn5iaNsdI12vnCIDG18ELVsAapXKjhgpQcMr1jXd1HzpbaGg4joST1KKa5DKrOICjnQSzm6pFoKvJ8D+iGlJPETJV8qKe5n6z1mkqZgCNXkprXZWEqD38ar909+uAnm+zxryEQugRTfxKW/kmMiHcXv361cQFfZR8u7m+uhamnfNObtlIg1tLvG2+TZEf47gvVt4Dmj34QHRro+11W7bnWt6kYKssooZMY7p1gAspeuWQiN/U6u9zD3tom8SekVzYgqvwB3yyoERTwEDsnSabkYkJD0dhMdtZqTaSfRSySNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vay0XhwiTD5V4wLJQAJxw6NUobD6jAUEid8hzsJZSj0=; b=Gy5AgnO+hhAf/zYdTdZhq6gB+Dql0WKVKse2S37pB1pLo1IPdHPYKQVjWDw/H1aZaKPK/fD3WINnmQeeE8lu7CRbE2vqD0lNn3b8J4C1hh2XQJ69/nrF0aP9kXB0mSRvifKLGMuhYN65G881zTAVnzAC3IlxHq3Ig9igtf4aEnIAMmM+Ol1sx9UbZizGCaBvScPnGgwI9BHdP521WbDzJhZtkPQrUAt3lmgvcVaV4H5+Arkt7XgcxUWEEcKkisxleczIYRE/FYLFpf5HNjVA9sSqBYhjKIEnPg7Svb3pE8kL0h3TWOxzUqjNnadG3CEDDsJiocHzCHuQW6PSZveA9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vay0XhwiTD5V4wLJQAJxw6NUobD6jAUEid8hzsJZSj0=; b=ZSiYtwtneAVh2yADnmC9Sy/ubI4T8b52iG/g77dIWBmfyPWoDy1S7SDfWE6sROL1QbXJI2Mr9E3CMDrqf/K3Xyu/Kg4fKJD08E5kcvIWQkrDan9xUCssirOLaDlA9l8upjsF2Dp2JPUjBdUvClxJJtavle7ieEi9If5em5lWFKcXyiYRuZMx1vPJuR5/Ieog2VoAJNuxWjPHnu3O7PxycLJuuBb0XTMBVczKgWpl+xeUF4Cv/d+MJUbuVnVcAiJJnYd/CcdqkVF1syN9WlbxpRo4d4hBopkxH7ipqj/6zXjX/LLvWNiYjREWTfMj1QXzXZjnGUU6+cQABPTY3XZzeA== Received: from HK0PR06MB3202.apcprd06.prod.outlook.com (2603:1096:203:87::17) by PS1PR06MB2661.apcprd06.prod.outlook.com (2603:1096:803:4d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.23; Thu, 28 Jul 2022 08:58:01 +0000 Received: from HK0PR06MB3202.apcprd06.prod.outlook.com ([fe80::24f5:c509:397f:4859]) by HK0PR06MB3202.apcprd06.prod.outlook.com ([fe80::24f5:c509:397f:4859%3]) with mapi id 15.20.5482.006; Thu, 28 Jul 2022 08:58:01 +0000 From: Neal Liu To: Dhananjay Phadke , Corentin Labbe , Christophe JAILLET , Randy Dunlap , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Johnny Huang CC: "linux-aspeed@lists.ozlabs.org" , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , BMC-SW Subject: RE: [PATCH v8 5/5] crypto: aspeed: add HACE crypto driver Thread-Topic: [PATCH v8 5/5] crypto: aspeed: add HACE crypto driver Thread-Index: AQHYoOPJ5May1K1qXkuPttWyN9P6sK2RHkqAgAB0CjCAAb+RAIAACJiw Date: Thu, 28 Jul 2022 08:58:01 +0000 Message-ID: References: <20220726113448.2964968-1-neal_liu@aspeedtech.com> <20220726113448.2964968-6-neal_liu@aspeedtech.com> <9d6beefe-9974-22f8-750c-68c9acb707ab@linux.microsoft.com> <450dee2f-63bf-51a7-730e-b780b594c1c5@linux.microsoft.com> In-Reply-To: <450dee2f-63bf-51a7-730e-b780b594c1c5@linux.microsoft.com> Accept-Language: en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ce1a4ce-0583-4111-589a-08da7077469c x-ms-traffictypediagnostic: PS1PR06MB2661:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qqeWB6Qw5aLdYhOxjKcnxw2e/lPT8MaURUBsuhQh8Lev/kjta2tfOWprONbAfUUGfLBvMIcgFUG7lsN62Q5RPdA4hF+onx4Zf7IIXE9euktLkM1oyYoBsW9wWXUtrJSM2fOuyqoo4s5habzGHpS+yhEiOcKvnbyjudiGZPMku9bCf7yxv60tzAGJv1dG++tnp5KF0ggL93elQF9S00DaNBgKhspuWYjj8LY6S48WdgDhGuR1+JArpP+VOBDTRIeyGzVQEm/e4W3Ujpu9z7EtPrid71Mr5gipjszWY9ld9UJ9atAY8Rsty/0PD/97JjdY/fG/S3NOCfgwzxo782eV5SZvqH9FZD5VR4RZUlf/zjNSPP9N4Zt7kGKEXXTn+Mehljse2rdZKrAwmbLvJ1/1kM+Uv0E7FByS6331BBpVjSaXyTrmzbJ8fUXwDvTwC51EE1u023y4v3k6SL2w/FSUn4RIFnzFKmG9aUOLsKvw0i0ZesgthPzr+txdsUZh6AVWZSoZwrvJym+n+Vy8OV3S4wPJ5rtYy+2juVJYiYEKdykO1YvXa9JhqRwSJ1KJHcvTL/VDMcE5jvc+awurKq0TIzDkcBOMD7Bp/8sEEQb9h26/lMMXWWgvkse2KeDpDhhAJr0MILzuUf3hbwejKlb3gYr840gLPDb/13tV+a4jXP2WvWdnYJl1Lu0uki+aXgf414gJE0/8CYHpzFznjlOWG9GIJxfKjWXZsAiusixDjFVdrpOQ7AF6rvSJtPe526N7/xuTTVkUZT82ZlQOA6raRuGuwvxHvOYb+4jOgs+wwbDauJx2QwepxkNFSHOXijBVG2bt/rde5nj9l29tYRCKOg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HK0PR06MB3202.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39840400004)(376002)(136003)(366004)(396003)(346002)(64756008)(8676002)(122000001)(66556008)(4326008)(316002)(33656002)(7696005)(76116006)(66446008)(66946007)(8936002)(38100700002)(921005)(66476007)(38070700005)(186003)(54906003)(2906002)(478600001)(110136005)(71200400001)(9686003)(55016003)(41300700001)(53546011)(86362001)(26005)(7416002)(52536014)(6506007)(107886003)(5660300002)(6636002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S3I0blEzOFBtRzBLZ3lXOTRYY0ZSNE1panRlbmx3bzRJV3JDNUsxY3NhWU1W?= =?utf-8?B?TzdQU1F5ZzAwUElJRWpxb216Z0NMV2lFbjdVcXhBa2J0UTZsUmVqckprTldJ?= =?utf-8?B?TXpZZGpXZysrcjQya2lWVEZNQ0wvOGJSZEFOUmdza3NzZGJXMVk3QjVHVVBl?= =?utf-8?B?RFQvUVBvWVBVK212T3BBUmlrajQ2RWMvcFdnTHpSQitWZWpwQ0d3YXlTcXAy?= =?utf-8?B?eXE3T1k1K1RidnJNS3BVU0FDRzd1MTJvcVNCc1YwUjBpQ1ZzcFNWbnMvNkhX?= =?utf-8?B?bVE3RFBWajVhbDRCK29YZWZRM0JvRi9MRmk1V2kyN2xQM0VoNkphaXExU1BZ?= =?utf-8?B?ek01NFN6OVAxSW5aSG43ZlI0d0JzZG83MFNYSGJCWkF1UlZXcXN6bmxBREdj?= =?utf-8?B?MmVsNERKTXZlQktGejZiVXVsTTFYZVFaeHFVWVJPMGVmM2lUTTcwb1hSZGtE?= =?utf-8?B?SDVRYU4yV0xqN2Y3RHBwZTZMUzJmOGs0alhWc3A1TmFLNmtnMEVYM2ZUbFM5?= =?utf-8?B?QWRrVlZ3OTB0QjVGdlhEY0NiRzhTWUt4azVTMWhkV29DWkNjbk0yaExGbXNS?= =?utf-8?B?L25UbVNUVm15UmErV2dGUEhYUEN5QlZSNFRxN0FJMFB3dlNocXZRT29qWHFr?= =?utf-8?B?SEZ6MVcrWEpyOXkzbEdBUGUxeldWVnB1NEdtSlZSMG8xQ1J0NmNoRWhBcllL?= =?utf-8?B?aTFrWGFyZWtwWGZjTkZsYUcybVpETENmMG02bnVLSm9CU0o3RFN4Ny9zc3Jw?= =?utf-8?B?RnF2VE9JUmNEYkNuVFcwc3g2V1Jia3hrdEYxRWVWTnFXc2IzQ3MzUEZySHAy?= =?utf-8?B?bUxoWlNIRDlzVWttb1VOb1lKTE9vSC9EWHNlNjRZU0dRZDZhTDh5NFRoNitJ?= =?utf-8?B?VlcyemFFaGprUnNKT0M3QmYrSW5PN3NoSjBFdVh2TSsyOExSZ09uWm1Lbnlr?= =?utf-8?B?NzA5UXczTlFxZnJ3djdkYkd3QkFVUWU5UDRsRzRva2pPa0xNUVpBL0R3d3B5?= =?utf-8?B?MDNWcWptTlhRTWVCc1RhK2ZDNEltQXJoejE1b3kwblhJUWZqZmNqdkl2MTFs?= =?utf-8?B?cFNQWlZMM1B6QzlUTkZLd3BIUmdEMWF5RjJvMzZpVHFBZGtpUGsyeEt2Qkxo?= =?utf-8?B?bWFnNTBMZ1gyRWdzem0vMzIyNzdEVnFsMndYTEhRaElIeFJtZXh0MWtHem5y?= =?utf-8?B?Y3JFdTNwTFlxb2h6dGN1NWVEc1NFZG9OUUNrWWFscmVHOU5lWEUyNDBJRHpU?= =?utf-8?B?bDEyWUNmN1pKenRLR3FyZ3BIMGtkU08yZXpZbGFDQ01iUVVYcXhnZUVWOXFB?= =?utf-8?B?N2JWam9PS0NlbExHVE5idEt0aHN6WUQ5Z1p4UW5PNzJEbGt6RGdEM2Z6R2xw?= =?utf-8?B?bE1yTWFQb2I2aC9VMUFuWmRJaGN5SWZzRWM2TlhtWXVRbDF1cW8yV3NySlJh?= =?utf-8?B?WWoraXo4VTBrbi9keUdvMEE5VVBhbEw2eGFrczZaMkVSeDJiNGlWemo0VmJT?= =?utf-8?B?Q01sSy9xNU5sNDF3ZFBUazl4cngvN0hTanVZZGk2QUJXa1ZFSnVCanFBNHYx?= =?utf-8?B?d3ZlYWp5WmRyY1JSRjBCR0pKcWtueStPamVhanNIYkxZYXNtU3F2OWd1WTV6?= =?utf-8?B?S0hyc0ZtcDZKTE9TY1hzWVJnS05CdS8xWitjZjVRTUVCTklvWlltK3hpcmQv?= =?utf-8?B?TXpib2RWM2E3NWI2RnRuZFZGMnBnVHlNQ01BVjZuMlMwZFo5cXE5cXRUTVpC?= =?utf-8?B?ZHZuY3Fkb0VaL0d1N09QbnYwcWZwSDFIeldNYzRJWW9nUjUyVTJaQlBRb3VB?= =?utf-8?B?NjlROWt2K1VRMGw5S0l5OThEUER5cm9CSTRwS1VmQ3M3MG9VMk1HL2V5YTlQ?= =?utf-8?B?YnpTemc0YzZMa1R4VjRkNFYwanczUmxROHZmYiswaUVNOCt5SXJDY1FrTnU4?= =?utf-8?B?Q09hMHgyM29YVGNkbXlUa2djV3dnK0wyKzAyY045RlFpUWkzQWgwK1dxQ1Zx?= =?utf-8?B?aFNNN1hFWW5ZSVdpWFR5T0R1bUw5eFFlbFMvV0MzaDFZNkJKbitpTi9JNW5H?= =?utf-8?B?ZWlIbksrSkFiK1hLRFVidU9NL1pYbWVtSGc2UUx1TE9FWGhUTVZMbGZVRG9G?= =?utf-8?Q?K87z6wcU6g/G7FDYiQrz0agC2?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ce1a4ce-0583-4111-589a-08da7077469c X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2022 08:58:01.3948 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7U2J4fRk0JQUaqooYEpyRc8uQg16+gmkUO1+c01jTWyQlMhaWK5YHMGx4DPy+B0yzjObW6gqi4wZ50xoPkewTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB2661 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PiBPbiA3LzI2LzIwMjIgMTA6MzEgUE0sIE5lYWwgTGl1IHdyb3RlOg0KPiA+PiBXaHkgYXJlIHNl cGFyYXRlIG9wdGlvbnMgcmVxdWlyZWQgZm9yIGhhc2ggYW5kIGNyeXB0byBhbGdvcml0aG1zLCBp Zg0KPiA+PiBoYWNlIGlzIG9ubHkgaHcgY3J5cHRvIG9uIHRoZSBTb0NzPw0KPiA+Pg0KPiA+PiBM b29rcyBsaWtlIHRoYXQncyByZXF1aXJpbmcgdW5uZWNlc3NhcnkgX193ZWFrIHJlZ2lzdGVyIC8g dW5yZWdpc3Rlcg0KPiA+PiBmdW5jdGlvbnMgW3NlZSBiZWxvd10uDQo+ID4+DQo+ID4+IENvdWxk bid0IGp1c3QgdHdvIG9wdGlvbnMgQ09ORklHX0NSWVBUT19ERVZfQVNQRUVEIGFuZA0KPiA+PiBD T05GSUdfQ1JZUFRPX0RFVl9BU1BFRURfREVCVUcgYmUgc2ltcGxlciB0byBzZXQgZm9yIGRvd25z dHJlYW0NCj4gPj4gZGVmY29uZmlncz8NCj4gPiBJIHdvdWxkIGxpa2UgdG8gc2VwYXJhdGUgZGlm ZmVyZW50IGFsZ29yaXRobXMgYnkgZGlmZmVyZW50IG9wdGlvbnMgZm9yIG1vcmUNCj4gY29udmVu aWVudCBmb3IgZnVydGhlciB1c2UgYW5kIGRlYnVnLg0KPiA+IFdlIGFsc28gaGF2ZSBSU0EgZW5n aW5lIG5hbWVkIEFDUlksIGFuZCB3b3VsZCB1cHN0cmVhbSBvbmNlIGhhc2ggJg0KPiBjcnlwdG8g YmVpbmcgYWNjZXB0ZWQuDQo+ID4gU28gY29tYmluZWQgdGhlbSBpbnRvIG9uZSBvcHRpb24gc2Vl bXMgbm90IGEgZ29vZCBjaG9pY2UgZm9yIG11bHRpcGxlIGh3DQo+IGNyeXB0bywgZG8geW91IGFn cmVlPw0KPiANCj4gTm90IHN1cmUgd2hhdCdzIHRoZSB1c2UgY2FzZSBvZiBqdXN0IGVuYWJsaW5n IGNyeXB0byBvciBoYXNoIHNlcGFyYXRlbHkgb3V0IG9mDQo+IHNhbWUgSFcgZW5naW5lIGFuZCBl c3AuIHdoZW4gdGhlcmUncyBubyBhbHRlcm5hdGl2ZSBhY2NlbCBhdmFpbGFibGUsIGJ1dA0KPiB0 aGF0J3MgZmluZS4NCj4gDQo+IElmIEFSQ1kgaXMgZGlmZmVyZW50IEhXIGVuZ2luZSAoaW50ZXJm YWNlKSB0aGVuIGhhdmluZyBzZXBhcmF0ZSBjb25maWcgc291bmRzDQo+IGxvZ2ljYWwuDQo+IA0K PiBNdWx0aXBseWluZyBERUJVRyBjb25maWdzIHNlZW1zIHVubmVjZXNzYXJ5IHRob3VnaC4gV2l0 aCBkeW5hbWljIGRlYnVnDQo+IGFueSBvZiB0aGUgZGV2X2RiZyBjb3VsZCBiZSB0dXJuZWQgb24u IFN1Z2dlc3QgdXNpbmcgc2luZ2xlIG9uZSBmb3IgdGhlDQo+IG1vZHVsZSwgaWYgbm90IGRyb3Ag aXQgYWx0b2dldGhlci4gRm9sbG93aW5nIGNvZGUgaXMgc3RpbGwgbm90IGNvdmVyZWQgYnkgS2Nv bmZpZywNCj4gaXQgaW4gY29tbW9uIGNvZGUuDQo+IA0KPiAgPiArI2lmZGVmIEFTUEVFRF9IQUNF X0RFQlVHDQo+ICA+ICsjZGVmaW5lIEhBQ0VfREJHKGQsIGZtdCwgLi4uKQlcDQo+ICA+ICsJZGV2 X2luZm8oKGQpLT5kZXYsICIlcygpICIgZm10LCBfX2Z1bmNfXywgIyNfX1ZBX0FSR1NfXykNCj4g ID4gKyNlbHNlDQo+ICA+ICsjZGVmaW5lIEhBQ0VfREJHKGQsIGZtdCwgLi4uKQlcDQo+ICA+ICsJ ZGV2X2RiZygoZCktPmRldiwgIiVzKCkgIiBmbXQsIF9fZnVuY19fLCAjI19fVkFfQVJHU19fKQ0K PiAgPiArI2VuZGlmDQo+IA0KPiBSZWdhcmRzLA0KPiBEaGFuYW5qYXkNCg0KT2theSwgSSdsbCBs ZXZlcmFnZSB5b3VyIHN1Z2dlc3Rpb24gd2l0aCBkaWZmZXJlbnQgY3J5cHRvIGFsZ29zIG9wdGlv bnMgYW5kIDEgZGVidWcgb3B0aW9uIGZvciBhbGwgbW9kdWxlcy4NClRoYW5rcyAhDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BD07C04A68 for ; Thu, 28 Jul 2022 08:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YRkOuTnm3RSuNpkmpJiWV6pg1P7QcTNkAirXikZIuTw=; b=PNOBZggZidG191 YHo5zxdLoZ/cwJ/r8JjE4IwTHJiC2WiJzp1ZJ4Z2uHre2Zee2rs/qnvH8s3wz1XnFVClDdj56sqKv W0gWSlbLJJx+szHBVsJLTN+/v7a+7WqLd6j0q3r4CPylNlAD9ZGLoZsKckZtgilg2oUAJuzPIKzX8 JQbczQYI9wJW8H16mbQxxKxV5OGlFJ1X+LIb0Wd6WmsXBVLnIT8gkTWTVXN/ccffPvn8BiQu1mBTB KyMfqtisHXcOTv45QW7RhDh8t5uv4KEwMZevQFahQqYWxvS5k8rsxk5w4pp6P3rZVx9cOwMHRh5r6 G/XozV+FZofcduKkwMIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGzLS-0060zD-9G; Thu, 28 Jul 2022 08:58:14 +0000 Received: from mail-tyzapc01on2137.outbound.protection.outlook.com ([40.107.117.137] helo=APC01-TYZ-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGzLP-0060v4-ND for linux-arm-kernel@lists.infradead.org; Thu, 28 Jul 2022 08:58:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YtdM/ZgphjuSak81Xq4Ethp7VS4a33xqAzgtVAKtNyHn5iaNsdI12vnCIDG18ELVsAapXKjhgpQcMr1jXd1HzpbaGg4joST1KKa5DKrOICjnQSzm6pFoKvJ8D+iGlJPETJV8qKe5n6z1mkqZgCNXkprXZWEqD38ar909+uAnm+zxryEQugRTfxKW/kmMiHcXv361cQFfZR8u7m+uhamnfNObtlIg1tLvG2+TZEf47gvVt4Dmj34QHRro+11W7bnWt6kYKssooZMY7p1gAspeuWQiN/U6u9zD3tom8SekVzYgqvwB3yyoERTwEDsnSabkYkJD0dhMdtZqTaSfRSySNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vay0XhwiTD5V4wLJQAJxw6NUobD6jAUEid8hzsJZSj0=; b=Gy5AgnO+hhAf/zYdTdZhq6gB+Dql0WKVKse2S37pB1pLo1IPdHPYKQVjWDw/H1aZaKPK/fD3WINnmQeeE8lu7CRbE2vqD0lNn3b8J4C1hh2XQJ69/nrF0aP9kXB0mSRvifKLGMuhYN65G881zTAVnzAC3IlxHq3Ig9igtf4aEnIAMmM+Ol1sx9UbZizGCaBvScPnGgwI9BHdP521WbDzJhZtkPQrUAt3lmgvcVaV4H5+Arkt7XgcxUWEEcKkisxleczIYRE/FYLFpf5HNjVA9sSqBYhjKIEnPg7Svb3pE8kL0h3TWOxzUqjNnadG3CEDDsJiocHzCHuQW6PSZveA9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vay0XhwiTD5V4wLJQAJxw6NUobD6jAUEid8hzsJZSj0=; b=ZSiYtwtneAVh2yADnmC9Sy/ubI4T8b52iG/g77dIWBmfyPWoDy1S7SDfWE6sROL1QbXJI2Mr9E3CMDrqf/K3Xyu/Kg4fKJD08E5kcvIWQkrDan9xUCssirOLaDlA9l8upjsF2Dp2JPUjBdUvClxJJtavle7ieEi9If5em5lWFKcXyiYRuZMx1vPJuR5/Ieog2VoAJNuxWjPHnu3O7PxycLJuuBb0XTMBVczKgWpl+xeUF4Cv/d+MJUbuVnVcAiJJnYd/CcdqkVF1syN9WlbxpRo4d4hBopkxH7ipqj/6zXjX/LLvWNiYjREWTfMj1QXzXZjnGUU6+cQABPTY3XZzeA== Received: from HK0PR06MB3202.apcprd06.prod.outlook.com (2603:1096:203:87::17) by PS1PR06MB2661.apcprd06.prod.outlook.com (2603:1096:803:4d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.23; Thu, 28 Jul 2022 08:58:01 +0000 Received: from HK0PR06MB3202.apcprd06.prod.outlook.com ([fe80::24f5:c509:397f:4859]) by HK0PR06MB3202.apcprd06.prod.outlook.com ([fe80::24f5:c509:397f:4859%3]) with mapi id 15.20.5482.006; Thu, 28 Jul 2022 08:58:01 +0000 From: Neal Liu To: Dhananjay Phadke , Corentin Labbe , Christophe JAILLET , Randy Dunlap , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Johnny Huang CC: "linux-aspeed@lists.ozlabs.org" , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , BMC-SW Subject: RE: [PATCH v8 5/5] crypto: aspeed: add HACE crypto driver Thread-Topic: [PATCH v8 5/5] crypto: aspeed: add HACE crypto driver Thread-Index: AQHYoOPJ5May1K1qXkuPttWyN9P6sK2RHkqAgAB0CjCAAb+RAIAACJiw Date: Thu, 28 Jul 2022 08:58:01 +0000 Message-ID: References: <20220726113448.2964968-1-neal_liu@aspeedtech.com> <20220726113448.2964968-6-neal_liu@aspeedtech.com> <9d6beefe-9974-22f8-750c-68c9acb707ab@linux.microsoft.com> <450dee2f-63bf-51a7-730e-b780b594c1c5@linux.microsoft.com> In-Reply-To: <450dee2f-63bf-51a7-730e-b780b594c1c5@linux.microsoft.com> Accept-Language: en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ce1a4ce-0583-4111-589a-08da7077469c x-ms-traffictypediagnostic: PS1PR06MB2661:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qqeWB6Qw5aLdYhOxjKcnxw2e/lPT8MaURUBsuhQh8Lev/kjta2tfOWprONbAfUUGfLBvMIcgFUG7lsN62Q5RPdA4hF+onx4Zf7IIXE9euktLkM1oyYoBsW9wWXUtrJSM2fOuyqoo4s5habzGHpS+yhEiOcKvnbyjudiGZPMku9bCf7yxv60tzAGJv1dG++tnp5KF0ggL93elQF9S00DaNBgKhspuWYjj8LY6S48WdgDhGuR1+JArpP+VOBDTRIeyGzVQEm/e4W3Ujpu9z7EtPrid71Mr5gipjszWY9ld9UJ9atAY8Rsty/0PD/97JjdY/fG/S3NOCfgwzxo782eV5SZvqH9FZD5VR4RZUlf/zjNSPP9N4Zt7kGKEXXTn+Mehljse2rdZKrAwmbLvJ1/1kM+Uv0E7FByS6331BBpVjSaXyTrmzbJ8fUXwDvTwC51EE1u023y4v3k6SL2w/FSUn4RIFnzFKmG9aUOLsKvw0i0ZesgthPzr+txdsUZh6AVWZSoZwrvJym+n+Vy8OV3S4wPJ5rtYy+2juVJYiYEKdykO1YvXa9JhqRwSJ1KJHcvTL/VDMcE5jvc+awurKq0TIzDkcBOMD7Bp/8sEEQb9h26/lMMXWWgvkse2KeDpDhhAJr0MILzuUf3hbwejKlb3gYr840gLPDb/13tV+a4jXP2WvWdnYJl1Lu0uki+aXgf414gJE0/8CYHpzFznjlOWG9GIJxfKjWXZsAiusixDjFVdrpOQ7AF6rvSJtPe526N7/xuTTVkUZT82ZlQOA6raRuGuwvxHvOYb+4jOgs+wwbDauJx2QwepxkNFSHOXijBVG2bt/rde5nj9l29tYRCKOg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HK0PR06MB3202.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39840400004)(376002)(136003)(366004)(396003)(346002)(64756008)(8676002)(122000001)(66556008)(4326008)(316002)(33656002)(7696005)(76116006)(66446008)(66946007)(8936002)(38100700002)(921005)(66476007)(38070700005)(186003)(54906003)(2906002)(478600001)(110136005)(71200400001)(9686003)(55016003)(41300700001)(53546011)(86362001)(26005)(7416002)(52536014)(6506007)(107886003)(5660300002)(6636002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S3I0blEzOFBtRzBLZ3lXOTRYY0ZSNE1panRlbmx3bzRJV3JDNUsxY3NhWU1W?= =?utf-8?B?TzdQU1F5ZzAwUElJRWpxb216Z0NMV2lFbjdVcXhBa2J0UTZsUmVqckprTldJ?= =?utf-8?B?TXpZZGpXZysrcjQya2lWVEZNQ0wvOGJSZEFOUmdza3NzZGJXMVk3QjVHVVBl?= =?utf-8?B?RFQvUVBvWVBVK212T3BBUmlrajQ2RWMvcFdnTHpSQitWZWpwQ0d3YXlTcXAy?= =?utf-8?B?eXE3T1k1K1RidnJNS3BVU0FDRzd1MTJvcVNCc1YwUjBpQ1ZzcFNWbnMvNkhX?= =?utf-8?B?bVE3RFBWajVhbDRCK29YZWZRM0JvRi9MRmk1V2kyN2xQM0VoNkphaXExU1BZ?= =?utf-8?B?ek01NFN6OVAxSW5aSG43ZlI0d0JzZG83MFNYSGJCWkF1UlZXcXN6bmxBREdj?= =?utf-8?B?MmVsNERKTXZlQktGejZiVXVsTTFYZVFaeHFVWVJPMGVmM2lUTTcwb1hSZGtE?= =?utf-8?B?SDVRYU4yV0xqN2Y3RHBwZTZMUzJmOGs0alhWc3A1TmFLNmtnMEVYM2ZUbFM5?= =?utf-8?B?QWRrVlZ3OTB0QjVGdlhEY0NiRzhTWUt4azVTMWhkV29DWkNjbk0yaExGbXNS?= =?utf-8?B?L25UbVNUVm15UmErV2dGUEhYUEN5QlZSNFRxN0FJMFB3dlNocXZRT29qWHFr?= =?utf-8?B?SEZ6MVcrWEpyOXkzbEdBUGUxeldWVnB1NEdtSlZSMG8xQ1J0NmNoRWhBcllL?= =?utf-8?B?aTFrWGFyZWtwWGZjTkZsYUcybVpETENmMG02bnVLSm9CU0o3RFN4Ny9zc3Jw?= =?utf-8?B?RnF2VE9JUmNEYkNuVFcwc3g2V1Jia3hrdEYxRWVWTnFXc2IzQ3MzUEZySHAy?= =?utf-8?B?bUxoWlNIRDlzVWttb1VOb1lKTE9vSC9EWHNlNjRZU0dRZDZhTDh5NFRoNitJ?= =?utf-8?B?VlcyemFFaGprUnNKT0M3QmYrSW5PN3NoSjBFdVh2TSsyOExSZ09uWm1Lbnlr?= =?utf-8?B?NzA5UXczTlFxZnJ3djdkYkd3QkFVUWU5UDRsRzRva2pPa0xNUVpBL0R3d3B5?= =?utf-8?B?MDNWcWptTlhRTWVCc1RhK2ZDNEltQXJoejE1b3kwblhJUWZqZmNqdkl2MTFs?= =?utf-8?B?cFNQWlZMM1B6QzlUTkZLd3BIUmdEMWF5RjJvMzZpVHFBZGtpUGsyeEt2Qkxo?= =?utf-8?B?bWFnNTBMZ1gyRWdzem0vMzIyNzdEVnFsMndYTEhRaElIeFJtZXh0MWtHem5y?= =?utf-8?B?Y3JFdTNwTFlxb2h6dGN1NWVEc1NFZG9OUUNrWWFscmVHOU5lWEUyNDBJRHpU?= =?utf-8?B?bDEyWUNmN1pKenRLR3FyZ3BIMGtkU08yZXpZbGFDQ01iUVVYcXhnZUVWOXFB?= =?utf-8?B?N2JWam9PS0NlbExHVE5idEt0aHN6WUQ5Z1p4UW5PNzJEbGt6RGdEM2Z6R2xw?= =?utf-8?B?bE1yTWFQb2I2aC9VMUFuWmRJaGN5SWZzRWM2TlhtWXVRbDF1cW8yV3NySlJh?= =?utf-8?B?WWoraXo4VTBrbi9keUdvMEE5VVBhbEw2eGFrczZaMkVSeDJiNGlWemo0VmJT?= =?utf-8?B?Q01sSy9xNU5sNDF3ZFBUazl4cngvN0hTanVZZGk2QUJXa1ZFSnVCanFBNHYx?= =?utf-8?B?d3ZlYWp5WmRyY1JSRjBCR0pKcWtueStPamVhanNIYkxZYXNtU3F2OWd1WTV6?= =?utf-8?B?S0hyc0ZtcDZKTE9TY1hzWVJnS05CdS8xWitjZjVRTUVCTklvWlltK3hpcmQv?= =?utf-8?B?TXpib2RWM2E3NWI2RnRuZFZGMnBnVHlNQ01BVjZuMlMwZFo5cXE5cXRUTVpC?= =?utf-8?B?ZHZuY3Fkb0VaL0d1N09QbnYwcWZwSDFIeldNYzRJWW9nUjUyVTJaQlBRb3VB?= =?utf-8?B?NjlROWt2K1VRMGw5S0l5OThEUER5cm9CSTRwS1VmQ3M3MG9VMk1HL2V5YTlQ?= =?utf-8?B?YnpTemc0YzZMa1R4VjRkNFYwanczUmxROHZmYiswaUVNOCt5SXJDY1FrTnU4?= =?utf-8?B?Q09hMHgyM29YVGNkbXlUa2djV3dnK0wyKzAyY045RlFpUWkzQWgwK1dxQ1Zx?= =?utf-8?B?aFNNN1hFWW5ZSVdpWFR5T0R1bUw5eFFlbFMvV0MzaDFZNkJKbitpTi9JNW5H?= =?utf-8?B?ZWlIbksrSkFiK1hLRFVidU9NL1pYbWVtSGc2UUx1TE9FWGhUTVZMbGZVRG9G?= =?utf-8?Q?K87z6wcU6g/G7FDYiQrz0agC2?= MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ce1a4ce-0583-4111-589a-08da7077469c X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2022 08:58:01.3948 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7U2J4fRk0JQUaqooYEpyRc8uQg16+gmkUO1+c01jTWyQlMhaWK5YHMGx4DPy+B0yzjObW6gqi4wZ50xoPkewTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB2661 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220728_015811_806127_5200E6C0 X-CRM114-Status: GOOD ( 20.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On 7/26/2022 10:31 PM, Neal Liu wrote: > >> Why are separate options required for hash and crypto algorithms, if > >> hace is only hw crypto on the SoCs? > >> > >> Looks like that's requiring unnecessary __weak register / unregister > >> functions [see below]. > >> > >> Couldn't just two options CONFIG_CRYPTO_DEV_ASPEED and > >> CONFIG_CRYPTO_DEV_ASPEED_DEBUG be simpler to set for downstream > >> defconfigs? > > I would like to separate different algorithms by different options for more > convenient for further use and debug. > > We also have RSA engine named ACRY, and would upstream once hash & > crypto being accepted. > > So combined them into one option seems not a good choice for multiple hw > crypto, do you agree? > > Not sure what's the use case of just enabling crypto or hash separately out of > same HW engine and esp. when there's no alternative accel available, but > that's fine. > > If ARCY is different HW engine (interface) then having separate config sounds > logical. > > Multiplying DEBUG configs seems unnecessary though. With dynamic debug > any of the dev_dbg could be turned on. Suggest using single one for the > module, if not drop it altogether. Following code is still not covered by Kconfig, > it in common code. > > > +#ifdef ASPEED_HACE_DEBUG > > +#define HACE_DBG(d, fmt, ...) \ > > + dev_info((d)->dev, "%s() " fmt, __func__, ##__VA_ARGS__) > > +#else > > +#define HACE_DBG(d, fmt, ...) \ > > + dev_dbg((d)->dev, "%s() " fmt, __func__, ##__VA_ARGS__) > > +#endif > > Regards, > Dhananjay Okay, I'll leverage your suggestion with different crypto algos options and 1 debug option for all modules. Thanks ! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel