All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kostyrka <andreas@mtg.co.at>
To: Linux LVM Mailinglist <linux-lvm@msede.com>
Subject: [linux-lvm] LVM 0.7: optimization bug
Date: Sat, 25 Sep 1999 00:49:15 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.10.9909250041580.8042-100000@gatekeeper.zwax.mtg.co.at> (raw)

Hi!

I've found some buggy assumptions (in my case, like that I do have
16 loop devices. RH6 comes with loop0-loop7).

The following patch fixes this:
diff -uNr LVM.org/0.7/tools/lib/pv_read_all_pv.c
LVM/0.7/tools/lib/pv_read_all_pv.c
--- LVM.org/0.7/tools/lib/pv_read_all_pv.c      Mon Jul 12 23:21:26 1999
+++ LVM/0.7/tools/lib/pv_read_all_pv.c  Sat Sep 25 03:19:51 1999
@@ -99,13 +99,6 @@
          debug ( "pv_read_all_pv -- calling pv_read with \"%s\"\n",
                   dev_name);
 #endif
-         if ( ( tst = open ( dev_name, O_RDONLY)) == -1) {
-            if ( MAJOR ( dir_cache[n].st_rdev) != MD_MAJOR &&
-                 MINOR ( dir_cache[n].st_rdev) % 16 == 0) {
-               n += 15;
-               continue;
-            }
-         } else close ( tst);
 
          pv_read_errno = 0;
          if ( ( ret = pv_read ( dev_name, &pv_tmp, &pv_read_errno)) == 0
||


Andreas
--
Andreas Kostyrka                     | andreas@mtg.co.at
phone: +43/1/7070750                 | phone: +43/676/4091256   
MTG Handelsges.m.b.H.                | fax:   +43/1/7065299
Raiffeisenstr. 16/9                  | 2320 Zwoelfaxing AUSTRIA        

                 reply	other threads:[~1999-09-24 22:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.10.9909250041580.8042-100000@gatekeeper.zwax.mtg.co.at \
    --to=andreas@mtg.co.at \
    --cc=linux-lvm@msede.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.