From: Gabriel Knezek <gabeknez@microsoft.com>
To: Kent Gibson <warthog618@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: RE: [EXTERNAL] Re: Potential bug in gpiolib-cdev.c in v1 notification about line info changes
Date: Wed, 16 Jun 2021 21:24:01 +0000 [thread overview]
Message-ID: <SN4PR2101MB073495FA53DFFDB024AB74CEDA0F9@SN4PR2101MB0734.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20210616104442.GA160816@sol>
>
> Looks like a bug to me too - well spotted :(.
>
> > We wanted to get your thoughts on if you feel this is actually a bug, or if we
> overlooked something.
> > We're proposing to fix this issue by memsetting the entire structure to zero
> before calling the conversion routine; if you agree that that's a valid
> approach, I'm happy to submit an official patch.
> >
>
> Go for it.
> I'd zero the padding in the conversion routine myself, but zeroing the whole
> struct in the same routine as the copy_to_user(), as you suggest, would more
> clearly demonstrate that it isn't leaking stack.
Sounds good. I'll send out the patch shortly.
Do you think I should CC: security@kernel.org on the patch?
Thanks.
-Gabe
next prev parent reply other threads:[~2021-06-16 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 18:57 Potential bug in gpiolib-cdev.c in v1 notification about line info changes Gabriel Knezek
2021-06-16 10:44 ` Kent Gibson
2021-06-16 21:24 ` Gabriel Knezek [this message]
2021-06-17 0:56 ` [EXTERNAL] " Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR2101MB073495FA53DFFDB024AB74CEDA0F9@SN4PR2101MB0734.namprd21.prod.outlook.com \
--to=gabeknez@microsoft.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.