All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* sysfs entries not created for temperature in adm1278
@ 2020-05-06 19:40 Manikandan E
  2020-05-07  0:06 ` Milton Miller II
  0 siblings, 1 reply; 2+ messages in thread
From: Manikandan E @ 2020-05-06 19:40 UTC (permalink / raw
  To: openbmc@lists.ozlabs.org

[-- Attachment #1: Type: text/plain, Size: 2001 bytes --]

Hi,


The adm1278 hwmon sysfs entries not created for temperature.

 root@yosemitev2:~# ls -l /sys/class/hwmon/hwmon4/
curr1_highest         curr_samples          in1_max_alarm         in2_label             in_samples            power1_label
curr1_input           device/               in1_min               in2_max               name                  power1_max
curr1_label           in1_highest           in1_min_alarm         in2_max_alarm         of_node/              power1_reset_history
curr1_max             in1_input             in1_reset_history     in2_min               power1_alarm          power_samples
curr1_max_alarm       in1_label             in2_highest           in2_min_alarm         power1_input          subsystem/
curr1_reset_history   in1_max               in2_input             in2_reset_history     power1_input_highest  uevent



Thanks
Mani.E
::DISCLAIMER::
________________________________
The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
________________________________

[-- Attachment #2: Type: text/html, Size: 4055 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re:  sysfs entries not created for temperature in adm1278
  2020-05-06 19:40 sysfs entries not created for temperature in adm1278 Manikandan E
@ 2020-05-07  0:06 ` Milton Miller II
  0 siblings, 0 replies; 2+ messages in thread
From: Milton Miller II @ 2020-05-07  0:06 UTC (permalink / raw
  To: Manikandan E; +Cc: openbmc@lists.ozlabs.org

On May 6, 2020 around 6:02PM in some timezone, Manikandan E  wrote:

> Hi, 
> 
>  
>  The adm1278 hwmon sysfs entries not created for temperature. 
>  root@yosemitev2:~# ls -l /sys/class/hwmon/hwmon4/
>  
>curr1_highest         curr_samples          in1_max_alarm
>in2_label             in_samples            power1_label
>  
>curr1_input           device/               in1_min
>in2_max               name                  power1_max
>  
>curr1_label           in1_highest           in1_min_alarm
>in2_max_alarm         of_node/              power1_reset_history
>  
>curr1_max             in1_input             in1_reset_history
>in2_min               power1_alarm          power_samples
>  
>curr1_max_alarm       in1_label             in2_highest
>in2_min_alarm         power1_input          subsystem/
>  
>curr1_reset_history   in1_max               in2_input
>in2_reset_history     power1_input_highest  uevent
>  


A quick look at the upstream driver says that it reads the 
power management config register at 0xd4 and enables what 
is there, but (1) it doesn't account that the register is 
16 bits on 1278 and (2) although the register is rw according 
to the datasheet the driver doesn't appear to have proviisons 
to configure it.

I'd suggest (1) unbindig the driver, writing the register,
and then try binding the driver again (or warm reboot) to see 
if this works around the issue, and 

(2) raise the issue with the upstream on the linux-hwmon 
mailing list (or read the wiki in MAINTAINTERS).  The 
driver is adm1275.

I'd suggest a binding that allows the config register to be
specified in the device tree but I am not familiar with the 
hwmon comunity or practice for similar.

Hope this helps
milton

Speaking only for myself.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-07  0:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-06 19:40 sysfs entries not created for temperature in adm1278 Manikandan E
2020-05-07  0:06 ` Milton Miller II

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.