From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE42C433DB for ; Mon, 15 Mar 2021 07:56:17 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AB0264E38 for ; Mon, 15 Mar 2021 07:56:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AB0264E38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D220B82C91; Mon, 15 Mar 2021 07:56:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i4UUMQp7JmKj; Mon, 15 Mar 2021 07:56:16 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id D99468347D; Mon, 15 Mar 2021 07:56:15 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 1DAB81BF317 for ; Mon, 15 Mar 2021 07:56:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0CCC54016F for ; Mon, 15 Mar 2021 07:56:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=linuxfoundation.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h9EjqwFnf8M0 for ; Mon, 15 Mar 2021 07:56:13 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp2.osuosl.org (Postfix) with ESMTPS id D06184013F for ; Mon, 15 Mar 2021 07:56:13 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D787264E12; Mon, 15 Mar 2021 07:56:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615794973; bh=osdF5qmTEUxcpJl4FEQ0M6fxE/JEHBv/lB5q6kUbatw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dWcRgyOj3/E4paueDASxMWAqjMW5+JR7dUmIznngZpofmklvV60rmnN64pCRABsLR LEP+K22Q0KoPRQ90Z6525FmrOUczeE2omMGCijIMTzVwREI20Z347nu++7AVrHb4xx Gt4w99enn9MiokquVkr7+kAul278eEJJCCluBqtE= Date: Mon, 15 Mar 2021 08:56:10 +0100 From: Greg KH To: zhaoxiao Subject: Re: [PATCH] staging: rtl8192u: remove extra lines Message-ID: References: <20210315072759.23107-1-zhaoxiao@uniontech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210315072759.23107-1-zhaoxiao@uniontech.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, serrazimone@gmail.com, lu@pplo.net, dan.carpenter@oracle.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, Mar 15, 2021 at 03:27:59PM +0800, zhaoxiao wrote: > Remove extra lines in many functions in r8192U_wx.c. > Signed-off-by: zhaoxiao You did mor than just remove extra lines :( Also we need an extra line right before your signed-off-by line, as checkpatch should have warned you about. Please fix up and resend. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,PDS_TONAME_EQ_TOLOCAL_SHORT, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04650C433E0 for ; Mon, 15 Mar 2021 07:56:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C50ED64E67 for ; Mon, 15 Mar 2021 07:56:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230242AbhCOH41 (ORCPT ); Mon, 15 Mar 2021 03:56:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:46458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230173AbhCOH4N (ORCPT ); Mon, 15 Mar 2021 03:56:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D787264E12; Mon, 15 Mar 2021 07:56:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615794973; bh=osdF5qmTEUxcpJl4FEQ0M6fxE/JEHBv/lB5q6kUbatw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dWcRgyOj3/E4paueDASxMWAqjMW5+JR7dUmIznngZpofmklvV60rmnN64pCRABsLR LEP+K22Q0KoPRQ90Z6525FmrOUczeE2omMGCijIMTzVwREI20Z347nu++7AVrHb4xx Gt4w99enn9MiokquVkr7+kAul278eEJJCCluBqtE= Date: Mon, 15 Mar 2021 08:56:10 +0100 From: Greg KH To: zhaoxiao Cc: straube.linux@gmail.com, lu@pplo.net, dan.carpenter@oracle.com, serrazimone@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192u: remove extra lines Message-ID: References: <20210315072759.23107-1-zhaoxiao@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315072759.23107-1-zhaoxiao@uniontech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 03:27:59PM +0800, zhaoxiao wrote: > Remove extra lines in many functions in r8192U_wx.c. > Signed-off-by: zhaoxiao You did mor than just remove extra lines :( Also we need an extra line right before your signed-off-by line, as checkpatch should have warned you about. Please fix up and resend. thanks, greg k-h