From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1EFFC433E6 for ; Fri, 12 Mar 2021 14:48:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B86A364F6A for ; Fri, 12 Mar 2021 14:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231741AbhCLOsY (ORCPT ); Fri, 12 Mar 2021 09:48:24 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:53974 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231727AbhCLOsT (ORCPT ); Fri, 12 Mar 2021 09:48:19 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lKj5K-00AXdN-5y; Fri, 12 Mar 2021 15:48:14 +0100 Date: Fri, 12 Mar 2021 15:48:14 +0100 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, pali@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Message-ID: References: <20210308153703.23097-1-kabel@kernel.org> <20210308153703.23097-4-kabel@kernel.org> <87czw4kath.fsf@BL-laptop> <20210312101027.1997ec75@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210312101027.1997ec75@kernel.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Mar 12, 2021 at 10:10:27AM +0100, Marek Behún wrote: > On Fri, 12 Mar 2021 09:58:34 +0100 > Gregory CLEMENT wrote: > > > Hello Marek, > > > > > From: Pali Rohár > > > > > > Move the turris-mox-rwtm firmware node from Turris MOX' device tree into > > > the generic armada-37xx.dtsi file. > > > > I disagree with this patch. This firmware is specific to Turris MOX so > > it is not something that should be exposed to all the Armada 3700 based > > boards. > > > > If you want you still can create an dtsi for this and include it when > > needed. > > > > Gregory > > Gregory, we are planning to send pull-request for TF-A documentation, > adding information that people can compile the firmware with CZ.NIC's > firmware. > > Since this firmware exposes HW random number generator, it is > possible that people will start using it for espressobin. > > In that case this won't be specific for Turris MOX anymore. Part of the problem is that it looks specific to the Turris MOX. But please help me understand the big picture first. How is the firmware distributed? Is the binary part of linux-firmware? How does it get loaded? Does the firmware contain anything which is specific to the Turris MOX? Could the hardware number generator part be split out into a more generic sounding name blob? Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3466AC433DB for ; Fri, 12 Mar 2021 14:49:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D06DB64FB3 for ; Fri, 12 Mar 2021 14:49:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D06DB64FB3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5Us4JtYH+w7kFbcl+fl9GaKYhreukaSu1pjsWYTzda8=; b=ArTe5n5dDZu35J+bGIIM8Q9L3 lxRh7nf7LHc4Dkvdb4iXtd+5DVjVW07aDrc4baw0g9OsH26fuNnSakhPjWiXtGJ68pBAXMrpW1r7O JzPHjmTbG0JIWv5NDc/0V0se95DVM53UhC1bOBlJIJoSoqv1nQfxCt2vw5jQ5mehidRRpwPNpch6u YigxdqSg14xKfEtgDe/O7nstzc0PKu9tAHMyiyjk2NnWUIBToKx10sir9lmaAZueFeGsP83KAHcc2 rJ/d2WwINVeOZXfNUEj6hB9KrmFKwGvZzbeJJY417EWhJp8W0wLKjMSaBppU6WI+g9RmdQk+7egcF vu+AMGFFA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKj5Q-00Bfvk-MA; Fri, 12 Mar 2021 14:48:20 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKj5M-00BfvN-5w for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 14:48:17 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lKj5K-00AXdN-5y; Fri, 12 Mar 2021 15:48:14 +0100 Date: Fri, 12 Mar 2021 15:48:14 +0100 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, pali@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Message-ID: References: <20210308153703.23097-1-kabel@kernel.org> <20210308153703.23097-4-kabel@kernel.org> <87czw4kath.fsf@BL-laptop> <20210312101027.1997ec75@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210312101027.1997ec75@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_144816_332732_618953CB X-CRM114-Status: GOOD ( 17.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 12, 2021 at 10:10:27AM +0100, Marek Beh=FAn wrote: > On Fri, 12 Mar 2021 09:58:34 +0100 > Gregory CLEMENT wrote: > = > > Hello Marek, > > = > > > From: Pali Roh=E1r > > > > > > Move the turris-mox-rwtm firmware node from Turris MOX' device tree i= nto > > > the generic armada-37xx.dtsi file. = > > = > > I disagree with this patch. This firmware is specific to Turris MOX so > > it is not something that should be exposed to all the Armada 3700 based > > boards. > > = > > If you want you still can create an dtsi for this and include it when > > needed. > > = > > Gregory > = > Gregory, we are planning to send pull-request for TF-A documentation, > adding information that people can compile the firmware with CZ.NIC's > firmware. > = > Since this firmware exposes HW random number generator, it is > possible that people will start using it for espressobin. > = > In that case this won't be specific for Turris MOX anymore. Part of the problem is that it looks specific to the Turris MOX. But please help me understand the big picture first. How is the firmware distributed? Is the binary part of linux-firmware? How does it get loaded? Does the firmware contain anything which is specific to the Turris MOX? Could the hardware number generator part be split out into a more generic sounding name blob? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel