From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31E67C433DB for ; Tue, 16 Mar 2021 13:47:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F15FB65064 for ; Tue, 16 Mar 2021 13:47:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231670AbhCPNqq (ORCPT ); Tue, 16 Mar 2021 09:46:46 -0400 Received: from mga02.intel.com ([134.134.136.20]:29714 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbhCPNq2 (ORCPT ); Tue, 16 Mar 2021 09:46:28 -0400 IronPort-SDR: j/A9zVAiG0/eWGhphrsHFssp0rpxneWYSOltF13emBkCAywqFp5h6nyqk0KBEPLdECak462UMB nPKvOl7GU5JQ== X-IronPort-AV: E=McAfee;i="6000,8403,9924"; a="176390304" X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="176390304" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 06:46:27 -0700 IronPort-SDR: RwuFoNRYinpobRJAsQFRDh3AQU3TvAAWAisBI6/B8rZ13aHdK5t+od5VkM58O8Tdm2cBTu7QK2 i0zFxRx8DQOw== X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="439152743" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 06:46:24 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lMA1e-00CyW2-5G; Tue, 16 Mar 2021 15:46:22 +0200 Date: Tue, 16 Mar 2021 15:46:22 +0200 From: Andy Shevchenko To: Henning Schild Cc: Claudius Heine , johannes hahn , Alessandro Zummo , Alexandre Belloni , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , open list , werner zeh , martin mantel , val krutov Subject: Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C Message-ID: References: <20210316100805.2630481-2-ch@denx.de> <20210316125251.64484b3a@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316125251.64484b3a@md1za8fc.ad001.siemens.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 16, 2021 at 12:52:51PM +0100, Henning Schild wrote: > Am Tue, 16 Mar 2021 13:30:36 +0200 > schrieb Andy Shevchenko : > > > On Tue, Mar 16, 2021 at 11:08:05AM +0100, Claudius Heine wrote: > > > From: Johannes Hahn > > > > > > This allows the RX6110 driver to be automatically assigned to the > > > right device on the I2C bus. > > > > Thanks for all effort! > > Reviewed-by: Andy Shevchenko > > after addressing the below comments. > > > > > Signed-off-by: Johannes Hahn > > > Signed-off-by: Claudius Heine > > > > > Signed-off-by: Henning Schild > > Claudius, just remove that. I guess just add yours and mention authors > in the code if they should receive some recognition. > > > +#ifdef CONFIG_ACPI > > > +static const struct acpi_device_id rx6110_i2c_acpi_match[] = { > > > + { "SECC6110", }, > > > + { }, Missed one thing, remove comma here. Terminator lines do not need a comma (and it's theoretically may confuse people or scripts while adding a new record to the array). > > > +}; > > > +MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match); > > > +#endif -- With Best Regards, Andy Shevchenko