From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2AC4C433E6 for ; Tue, 16 Mar 2021 11:33:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 729F264FED for ; Tue, 16 Mar 2021 11:33:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237164AbhCPLdW (ORCPT ); Tue, 16 Mar 2021 07:33:22 -0400 Received: from mga04.intel.com ([192.55.52.120]:22557 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbhCPLdJ (ORCPT ); Tue, 16 Mar 2021 07:33:09 -0400 IronPort-SDR: DjQD9wofQTQli23pTm4szS1nFzcPyrRgKXaz2iTOgB7ajDQh5A5x//TGldK/V6rdp9m3mG6QSj ifjc4/ioW42Q== X-IronPort-AV: E=McAfee;i="6000,8403,9924"; a="186864486" X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="186864486" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 04:33:07 -0700 IronPort-SDR: +FLr21BqECxarTkirLegY7xaD2nLrpkv8qvXUaLrakO45urtbEY25Oi2AJtcMUNWltaCQXFKdz 6J8EZnh9KRFA== X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="388436171" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 04:33:04 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lM7wb-00CwHo-PI; Tue, 16 Mar 2021 13:33:01 +0200 Date: Tue, 16 Mar 2021 13:33:01 +0200 From: Andy Shevchenko To: Claudius Heine Cc: johannes hahn , Alessandro Zummo , Alexandre Belloni , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , open list , werner zeh , henning schild , martin mantel , val krutov Subject: Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C Message-ID: References: <20210316100805.2630481-2-ch@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 16, 2021 at 01:30:36PM +0200, Andy Shevchenko wrote: > On Tue, Mar 16, 2021 at 11:08:05AM +0100, Claudius Heine wrote: > > From: Johannes Hahn > > > > This allows the RX6110 driver to be automatically assigned to the right > > device on the I2C bus. > > Thanks for all effort! > Reviewed-by: Andy Shevchenko > after addressing the below comments. > > > Signed-off-by: Johannes Hahn > > Signed-off-by: Claudius Heine > > > Signed-off-by: Henning Schild > > I think this is somehow confusing. Either you need to add Co-developed-by of > the corresponding people, or remove SoB (because of From line), i.o.w seems > like Co-dB tag is needed for Johannes or you and something should be done with > Henning's SoB. Since Johannes' name is in the From, then it seems okay for you (either you a co-developer, than a Co-dB tag, or a submitter, than it's okay to have no Co-dB tag). -- With Best Regards, Andy Shevchenko