From: Mike Rapoport <rppt@linux.ibm.com>
To: Jarvis Jiang <jarvis.w.jiang@gmail.com>
Cc: davem@davemloft.net, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-mm@kvack.org, cchen50@lenovo.com, mpearson@lenovo.com
Subject: Re: [PATCH] Add MHI bus support and driver for T99W175 5G modem
Date: Tue, 16 Mar 2021 15:30:40 +0200 [thread overview]
Message-ID: <YFCzAPkpqO7qslax@linux.ibm.com> (raw)
In-Reply-To: <20210316124237.3469-1-jarvis.w.jiang@gmail.com>
On Tue, Mar 16, 2021 at 05:42:37AM -0700, Jarvis Jiang wrote:
> T99W175 using MBIM or RmNet over PCIe interface with
> MHI protocol support.
> Ported from IPQ8072 platform, including MHI, MBIM, RmNet
>
> Supporting below PCI devices:
>
> PCI_DEVICE(0x17cb, 0x0300)
> PCI_DEVICE(0x17cb, 0x0301)
> PCI_DEVICE(0x17cb, 0x0302)
> PCI_DEVICE(0x17cb, 0x0303)
> PCI_DEVICE(0x17cb, 0x0304)
> PCI_DEVICE(0x17cb, 0x0305)
> PCI_DEVICE(0x17cb, 0x0306)
> PCI_DEVICE(0x105b, 0xe0ab)
> PCI_DEVICE(0x105b, 0xe0b0)
> PCI_DEVICE(0x105b, 0xe0b1)
> PCI_DEVICE(0x105b, 0xe0b3)
> PCI_DEVICE(0x1269, 0x00b3)
> PCI_DEVICE(0x03f0, 0x0a6c)
>
> Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>
> ---
> MAINTAINERS | 16 +
> drivers/bus/Kconfig | 1 +
> drivers/bus/Makefile | 3 +
> drivers/bus/mhi/Kconfig | 27 +
> drivers/bus/mhi/Makefile | 9 +
> drivers/bus/mhi/controllers/Kconfig | 13 +
> drivers/bus/mhi/controllers/Makefile | 2 +
> drivers/bus/mhi/controllers/mhi_arch_qti.c | 275 ++
> drivers/bus/mhi/controllers/mhi_qti.c | 970 +++++++
> drivers/bus/mhi/controllers/mhi_qti.h | 44 +
> drivers/bus/mhi/core/Makefile | 2 +
> drivers/bus/mhi/core/mhi_boot.c | 590 +++++
> drivers/bus/mhi/core/mhi_dtr.c | 223 ++
> drivers/bus/mhi/core/mhi_init.c | 1901 ++++++++++++++
> drivers/bus/mhi/core/mhi_internal.h | 826 ++++++
> drivers/bus/mhi/core/mhi_main.c | 2261 +++++++++++++++++
> drivers/bus/mhi/core/mhi_pm.c | 1158 +++++++++
> drivers/bus/mhi/devices/Kconfig | 43 +
> drivers/bus/mhi/devices/Makefile | 3 +
> drivers/bus/mhi/devices/mhi_netdev.c | 1830 +++++++++++++
> drivers/bus/mhi/devices/mhi_satellite.c | 1155 +++++++++
> drivers/bus/mhi/devices/mhi_uci.c | 802 ++++++
> drivers/net/ethernet/qualcomm/rmnet/Makefile | 2 +-
> .../ethernet/qualcomm/rmnet/rmnet_config.c | 131 +-
> .../ethernet/qualcomm/rmnet/rmnet_config.h | 110 +-
> .../qualcomm/rmnet/rmnet_descriptor.c | 1225 +++++++++
> .../qualcomm/rmnet/rmnet_descriptor.h | 152 ++
> .../ethernet/qualcomm/rmnet/rmnet_handlers.c | 321 ++-
> .../ethernet/qualcomm/rmnet/rmnet_handlers.h | 27 +-
> .../net/ethernet/qualcomm/rmnet/rmnet_map.h | 238 +-
> .../qualcomm/rmnet/rmnet_map_command.c | 304 ++-
> .../ethernet/qualcomm/rmnet/rmnet_map_data.c | 1029 +++++++-
> .../ethernet/qualcomm/rmnet/rmnet_private.h | 19 +-
> .../net/ethernet/qualcomm/rmnet/rmnet_trace.h | 250 ++
> .../net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 101 +-
> .../net/ethernet/qualcomm/rmnet/rmnet_vnd.h | 16 +-
> include/linux/ipc_logging.h | 291 +++
> include/linux/mhi.h | 743 ++++++
> include/linux/mod_devicetable.h | 22 +-
> include/linux/msm-bus.h | 214 ++
> include/linux/msm_pcie.h | 173 ++
> include/linux/netdevice.h | 18 +-
> include/uapi/linux/if_link.h | 4 +
> include/uapi/linux/msm_rmnet.h | 170 ++
> mm/memblock.c | 2 +
> net/core/dev.c | 192 +-
> 46 files changed, 17700 insertions(+), 208 deletions(-)
This is way too much for a single patch. Please split your changes into a
series of patches, with one logical change per patch. For instance, you can
start with adding skeleton infrastructure for MHI, then add particular
implementations for it, and on top you can add device drivers that rely on
MHI core.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-03-16 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 12:42 [PATCH] Add MHI bus support and driver for T99W175 5G modem Jarvis Jiang
2021-03-16 13:30 ` Mike Rapoport [this message]
2021-03-17 9:37 ` 蒋威
2021-03-16 21:37 ` Jakub Kicinski
2021-03-17 10:09 ` 蒋威
2021-03-18 8:45 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFCzAPkpqO7qslax@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cchen50@lenovo.com \
--cc=davem@davemloft.net \
--cc=jarvis.w.jiang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpearson@lenovo.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.