From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3043C433DB for ; Tue, 16 Mar 2021 16:56:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7321365111 for ; Tue, 16 Mar 2021 16:56:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236811AbhCPQ4O (ORCPT ); Tue, 16 Mar 2021 12:56:14 -0400 Received: from mga01.intel.com ([192.55.52.88]:48372 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229754AbhCPQzv (ORCPT ); Tue, 16 Mar 2021 12:55:51 -0400 IronPort-SDR: ox9jGUnwGrrK8FWwuzeicagX0SJ4oR/W06xko5VJk8BnpAp1bpVpCGCzWmwIpPyXWPJ3gzz/bF Ir64VwDz81SQ== X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="209237585" X-IronPort-AV: E=Sophos;i="5.81,254,1610438400"; d="scan'208";a="209237585" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 09:55:47 -0700 IronPort-SDR: 1ZnLvylQ4cDnB7HnwETShuxZVyI27yQerkVH4GnO+bQWzugyglMctYBvzI70MfgWX3r00ui2Z4 o7f/VFF9A4Bw== X-IronPort-AV: E=Sophos;i="5.81,254,1610438400"; d="scan'208";a="439189178" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 09:55:45 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lMCys-00D0oo-Gy; Tue, 16 Mar 2021 18:55:42 +0200 Date: Tue, 16 Mar 2021 18:55:42 +0200 From: Andy Shevchenko To: Claudius Heine Cc: johannes hahn , Alessandro Zummo , Alexandre Belloni , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , open list , werner zeh , henning schild , martin mantel , val krutov Subject: Re: [PATCH v4] rtc: rx6110: add ACPI bindings to I2C Message-ID: References: <20210316100805.2630481-1-ch@denx.de> <20210316144819.4130622-1-ch@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316144819.4130622-1-ch@denx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 16, 2021 at 03:48:18PM +0100, Claudius Heine wrote: > From: Johannes Hahn > > This allows the RX6110 driver to be automatically assigned to the right > device on the I2C bus. You missed given tag, when somebody sends you one, it's usually your responsibility to pick it up. Hint: install b4 tool (likely in your distro, at least Debian, Arch Linux have it) and run it against message ID of the version in question. It will gather all tags. For example, for this case, run % b4 am 20210316144819.4130622-1-ch@denx.de It will download mailbox suitable for `git am ...` you will read on the screen. Also, when send a new version, don't attach it to the old thread. It will confuse people and maybe even tools (i.o.w. don't supply message ID to be put to In-Reply-To header). So, repeat again my tag and see one fix to be performed below. Reviewed-by: From: Andy Shevchenko > Signed-off-by: Johannes Hahn > Co-developed-by: Claudius Heine > Signed-off-by: Claudius Heine > --- > drivers/rtc/rtc-rx6110.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c > index 79161d4c6ce4..2a06953c0a84 100644 > --- a/drivers/rtc/rtc-rx6110.c > +++ b/drivers/rtc/rtc-rx6110.c > @@ -447,6 +447,12 @@ static int rx6110_i2c_probe(struct i2c_client *client, > return rx6110_probe(rx6110, &client->dev); > } > > +static const struct acpi_device_id rx6110_i2c_acpi_match[] = { > + { "SECC6110" }, > + { } > +}; > +MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match); > + > static const struct i2c_device_id rx6110_i2c_id[] = { > { "rx6110", 0 }, > { } > @@ -456,6 +462,7 @@ MODULE_DEVICE_TABLE(i2c, rx6110_i2c_id); > static struct i2c_driver rx6110_i2c_driver = { > .driver = { > .name = RX6110_DRIVER_NAME, > + .acpi_match_table = ACPI_PTR(rx6110_i2c_acpi_match), Since you drop ifdeffery above, you have to drop ACPI_PTR() (besides that ACPI_PTR() requires acpi.h to be included). > }, > .probe = rx6110_i2c_probe, > .id_table = rx6110_i2c_id, > -- > 2.30.1 > -- With Best Regards, Andy Shevchenko