From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88859C433E6 for ; Wed, 17 Mar 2021 16:07:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DCCA64F40 for ; Wed, 17 Mar 2021 16:07:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232067AbhCQQG2 (ORCPT ); Wed, 17 Mar 2021 12:06:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:39060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232214AbhCQQFv (ORCPT ); Wed, 17 Mar 2021 12:05:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3AC1A64DD1; Wed, 17 Mar 2021 16:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615997150; bh=2mX2x5ADc//zk3Jiby2HBW7pn+4QY403j4U50sTDsg4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DldvU6MCTKzmqGKoETycSUe8uWg2ruILPLAvrLeJ+T7hSaPskFSGPmrr2+qKbVEqe /Na1EGOmqSkIPINagX84YXhZRs5fos6zDSws1nyLrA6YVHcsRPBIeGTbQuRRqYIyAt FHgHoZzsPFUltrajondL8eEQjb1+fGgWdwajx2nI= Date: Wed, 17 Mar 2021 17:05:48 +0100 From: Greg KH To: Bartosz Golaszewski Cc: Marek Vasut , LKML , "Stable # 4 . 20+" , Roman Guskov , Andy Shevchenko Subject: Re: [PATCH 5.10 081/290] gpiolib: Read "gpio-line-names" from a firmware node Message-ID: References: <20210315135541.921894249@linuxfoundation.org> <20210315135544.659848571@linuxfoundation.org> <6abd9dd3-e14b-f690-f967-15fb58dffae8@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 05:32:09PM +0100, Bartosz Golaszewski wrote: > On Mon, Mar 15, 2021 at 4:01 PM Marek Vasut wrote: > > > > On 3/15/21 2:52 PM, gregkh@linuxfoundation.org wrote: > > > From: Greg Kroah-Hartman > > > > > > From: Andy Shevchenko > > > > > > commit b41ba2ec54a70908067034f139aa23d0dd2985ce upstream. > > > > > > On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, > > > see arch/arm/boot/dts/stm32mp151.dtsi. The driver for > > > pin-controller@50002000 is in drivers/pinctrl/stm32/pinctrl-stm32.c > > > and iterates over all of its DT subnodes when registering each GPIO > > > bank gpiochip. Each gpiochip has: > > > > > > - gpio_chip.parent = dev, > > > where dev is the device node of the pin controller > > > - gpio_chip.of_node = np, > > > which is the OF node of the GPIO bank > > > > > > Therefore, dev_fwnode(chip->parent) != of_fwnode_handle(chip.of_node), > > > i.e. pin-controller@50002000 != pin-controller@50002000/gpio@5000*000. > > > > > > The original code behaved correctly, as it extracted the "gpio-line-names" > > > from of_fwnode_handle(chip.of_node) = pin-controller@50002000/gpio@5000*000. > > > > > > To achieve the same behaviour, read property from the firmware node. > > > > There seem to be some discussion going on around this patch, so please > > postpone backporting until that is settled. Same for v5.11 backport. I > > hope Andy/Bartosz agrees ? > > Yes, this patch broke at least the testing module and we're working to > determine if it breaks DT drivers too. Now dropped, thanks. greg k-h