From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D16C433B4 for ; Mon, 19 Apr 2021 04:50:08 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C62461077 for ; Mon, 19 Apr 2021 04:50:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C62461077 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atmark-techno.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6vZgjOWwCW1EpIHXA7ouDzKXOPY+3E3k9pUBOxHODA4=; b=UzA+vDFUTey34Qk+OmUi1X7ik MDcbT5H5/Yos0RAPKrZI194AdhtFZfhC8HIj+6/5AkB5BVxid+BF7G+zgxO+ES2yM2C17QvGTWwLf WPJZqc+LTv8wE/OchVnZYCGdA5mtsjDJbAXLDAIpcViZgKEI6kgJXrCXIppf4MWaI1qKhGVP8RGwD CkTwS2tSPXdd46eLm+H96/ILx/goQWxhralZznJ/5uRage4Ug8Z3xNASVqwHmWYrSG14yM9GspL8F TJL4XJ1i95K/HQys3FYDm7ARudqbt2a6P3iheslXvhTJWJF/PhwfBTI2eGuz3FIoqdbPM007LtyxH xzisCwQoA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYLr3-0096av-FH; Mon, 19 Apr 2021 04:49:49 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYLr1-0096aQ-IT for linux-mediatek@desiato.infradead.org; Mon, 19 Apr 2021 04:49:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nwmKkdj5vxFBpFK3bj8w7Gz2YNFOXfPhegLyPurLzW0=; b=wV/TTEDYBzsSRoayU+dGbq5nsb jYU7wWdJh1sotCXbDRKsoG0VOHND8QPR1AvkFR64AvTZg0MnmYTnb2oXP9zg8tpbiedWrKMChFwqv LpfueAY62SDbBjY8YYGo3Z6iGqZRwCHk4uVRkB68i26LeAPxL5zMRW01RMvfGN3OSlBl/m52ClJsQ rCbtrrvdryeQ4lHYqECDPIeCsoRBLgr97t32khFJNpMM5WJKmWWhBpIQpBjas3vMa87s/8oql6/ii CWKJybcJWRZu51g46djjPq4wW9j1DNHxm5WBVtmG7qpj0iZKJKiNFMfS7mnkhliLKZ7cyQOhyVBEQ t93sg1YA==; Received: from gw.atmark-techno.com ([13.115.124.170]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYLqr-00AzPL-RV for linux-mediatek@lists.infradead.org; Mon, 19 Apr 2021 04:49:46 +0000 Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) by gw.atmark-techno.com (Postfix) with ESMTPS id 14B48804C4 for ; Mon, 19 Apr 2021 13:49:32 +0900 (JST) Received: by mail-oo1-f70.google.com with SMTP id w13-20020a4ab6cd0000b02901eb16e42655so2319182ooo.11 for ; Sun, 18 Apr 2021 21:49:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nwmKkdj5vxFBpFK3bj8w7Gz2YNFOXfPhegLyPurLzW0=; b=oySHlNUnoZQOGPYddSafXO9RSb7nXP5AWt1Lr+eZAQx4wfX3/H5XWL5mBw4H0wgyNU jYPvQPRMUwrWMp/DiTH4t63FgHC0xImU5E7zgD5YExZbBdAAHcvqX7mvNtt/5SPzWeZl DbYluRfhToxKQ1aEcXq6nI8PhvfVKGv2YA9EUF+WYm/XsT4cgAmYCnUnH8doHlrDDu+E p5AgKwr/oLAM2qQByIUwdKKfyBgdBGTCvTBSO4M/beiYpG1XxPxIyaqS9UTTwZoAB1kq beZOSHbuAnqHR9Du/m0+l38nQ3iU1F/pvRPurf2Pa8fr2Kjki2uGHV/lCE9vZQLXsiu2 7oVg== X-Gm-Message-State: AOAM532xtxHK1O+K1NgncZIee+ykvaaMygqzuIoj8wvxnfRE4+0HMxPe d/s6GHUOcG2/pI95f+MZr/GFnpGRBePlJmCxms/RDGeGEJ9WW5cHmwJ7YR9HEvpv5JQ+xzojAmq uJWZpIekI5Tq/bPUBPS3BTx/E6gvxcYGIZWAO X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145518pjg.189.1618807761193; Sun, 18 Apr 2021 21:49:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxUh9TJ2x/K//IB2lTaeXhs2rGXIpLK5cuzzNIi1YdNWpQlLZsRv610IvzYjHsCM08ZYf1MA== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145444pjg.189.1618807760853; Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from pc-0115 (117.209.187.35.bc.googleusercontent.com. [35.187.209.117]) by smtp.gmail.com with ESMTPSA id l22sm13247239pjc.13.2021.04.18.21.49.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from martinet by pc-0115 with local (Exim 4.94) (envelope-from ) id 1lYLqX-0016Kg-U8; Mon, 19 Apr 2021 13:49:17 +0900 Date: Mon, 19 Apr 2021 13:49:07 +0900 From: Dominique MARTINET To: "Alice Guo (OSS)" Cc: gregkh@linuxfoundation.org, rafael@kernel.org, horia.geanta@nxp.com, aymen.sghaier@nxp.com, herbert@gondor.apana.org.au, davem@davemloft.net, tony@atomide.com, geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, vkoul@kernel.org, peter.ujfalusi@gmail.com, a.hajda@samsung.com, narmstrong@baylibre.com, robert.foss@linaro.org, airlied@linux.ie, daniel@ffwll.ch, khilman@baylibre.com, tomba@kernel.org, jyri.sarha@iki.fi, joro@8bytes.org, will@kernel.org, mchehab@kernel.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, kishon@ti.com, kuba@kernel.org, linus.walleij@linaro.org, Roy.Pledge@nxp.com, leoyang.li@nxp.com, ssantosh@kernel.org, matthias.bgg@gmail.com, edubezval@gmail.com, j-keerthy@ti.com, balbi@kernel.org, linux@prisktech.co.nz, stern@rowland.harvard.edu, wim@linux-watchdog.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-staging@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER Message-ID: References: <20210419042722.27554-1-alice.guo@oss.nxp.com> <20210419042722.27554-2-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210419042722.27554-2-alice.guo@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210418_214938_042135_1114E819 X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org First comment overall for the whole serie: Since it is the solution I had suggested when I reported the problem[1] I have no qualm on the approach, comments for individual patches follow. [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800: > From: Alice Guo > > In i.MX8M boards, the registration of SoC device is later than caam > driver which needs it. Caam driver needs soc_device_match to provide > -EPROBE_DEFER when no SoC device is registered and no > early_soc_dev_attr. This patch should be last in the set: you can't have soc_device_match return an error before its callers handle it. > Signed-off-by: Alice Guo As the one who reported the problem I would have been appreciated being at least added to Ccs... I only happened to notice you posted this by chance. There is also not a single Fixes tag -- I believe this commit should have Fixes: 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure how such tags should be handled in case of multiple patches fixing something. -- Dominique _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09BC6C433B4 for ; Mon, 19 Apr 2021 04:49:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C534E61090 for ; Mon, 19 Apr 2021 04:49:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230176AbhDSEuF (ORCPT ); Mon, 19 Apr 2021 00:50:05 -0400 Received: from gw.atmark-techno.com ([13.115.124.170]:55600 "EHLO gw.atmark-techno.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbhDSEuD (ORCPT ); Mon, 19 Apr 2021 00:50:03 -0400 Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by gw.atmark-techno.com (Postfix) with ESMTPS id 5E97C80539 for ; Mon, 19 Apr 2021 13:49:33 +0900 (JST) Received: by mail-oo1-f69.google.com with SMTP id h4-20020a4abb840000b02901e59b65fba8so5485126oop.5 for ; Sun, 18 Apr 2021 21:49:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nwmKkdj5vxFBpFK3bj8w7Gz2YNFOXfPhegLyPurLzW0=; b=retUXiAF04+Bn14zmF6m79+D6VvX4oZUxBGSkcybIgotcN/2fjVnQfBnd4itX3bLmm t71+xfkc4JSApBJIYniUc65AhkWwtMJFhEgAT5YwLBCemUjoJHM3LmwEqWC3TVPVpLYH wcpTTpbeFYyOYTUuE5mm4qLg2M2xzZPxlguaHALEVaaV3fGk0o675gnD+aEzMtXtxUiN PSaNnnkNtJySEckpLBiyZvc0aRgEDOSHo8SRV7vrFbsHfSwVGHnMJh/r6kohnFCrZbQS uY+Nep4Anhvy2a6OKr+o8t2A/r0T2ZZxniNXDJuYP4Faxd+yw9sB8JLxlljk6vIFc7I+ OC1A== X-Gm-Message-State: AOAM530vn6QIUfOYhtlPee1vzFD4ta5cH3ysvPFdGX7OwUQE9ZQFe1zb LYXomNI7nIh6QeZT84TLryG/qS4JCyG8G4DGshmL+qRsVvMh5/3lcI+44Pmengy0hXmV+13APa8 E8cKCAso1NI81LMdswckPtLpDp9km X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145489pjg.189.1618807761158; Sun, 18 Apr 2021 21:49:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxUh9TJ2x/K//IB2lTaeXhs2rGXIpLK5cuzzNIi1YdNWpQlLZsRv610IvzYjHsCM08ZYf1MA== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145444pjg.189.1618807760853; Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from pc-0115 (117.209.187.35.bc.googleusercontent.com. [35.187.209.117]) by smtp.gmail.com with ESMTPSA id l22sm13247239pjc.13.2021.04.18.21.49.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from martinet by pc-0115 with local (Exim 4.94) (envelope-from ) id 1lYLqX-0016Kg-U8; Mon, 19 Apr 2021 13:49:17 +0900 Date: Mon, 19 Apr 2021 13:49:07 +0900 From: Dominique MARTINET To: "Alice Guo (OSS)" Cc: gregkh@linuxfoundation.org, rafael@kernel.org, horia.geanta@nxp.com, aymen.sghaier@nxp.com, herbert@gondor.apana.org.au, davem@davemloft.net, tony@atomide.com, geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, vkoul@kernel.org, peter.ujfalusi@gmail.com, a.hajda@samsung.com, narmstrong@baylibre.com, robert.foss@linaro.org, airlied@linux.ie, daniel@ffwll.ch, khilman@baylibre.com, tomba@kernel.org, jyri.sarha@iki.fi, joro@8bytes.org, will@kernel.org, mchehab@kernel.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, kishon@ti.com, kuba@kernel.org, linus.walleij@linaro.org, Roy.Pledge@nxp.com, leoyang.li@nxp.com, ssantosh@kernel.org, matthias.bgg@gmail.com, edubezval@gmail.com, j-keerthy@ti.com, balbi@kernel.org, linux@prisktech.co.nz, stern@rowland.harvard.edu, wim@linux-watchdog.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-staging@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER Message-ID: References: <20210419042722.27554-1-alice.guo@oss.nxp.com> <20210419042722.27554-2-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210419042722.27554-2-alice.guo@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org First comment overall for the whole serie: Since it is the solution I had suggested when I reported the problem[1] I have no qualm on the approach, comments for individual patches follow. [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800: > From: Alice Guo > > In i.MX8M boards, the registration of SoC device is later than caam > driver which needs it. Caam driver needs soc_device_match to provide > -EPROBE_DEFER when no SoC device is registered and no > early_soc_dev_attr. This patch should be last in the set: you can't have soc_device_match return an error before its callers handle it. > Signed-off-by: Alice Guo As the one who reported the problem I would have been appreciated being at least added to Ccs... I only happened to notice you posted this by chance. There is also not a single Fixes tag -- I believe this commit should have Fixes: 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure how such tags should be handled in case of multiple patches fixing something. -- Dominique From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D66C433ED for ; Mon, 19 Apr 2021 04:49:52 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2ACA861077 for ; Mon, 19 Apr 2021 04:49:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2ACA861077 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atmark-techno.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IaPfOxbOBsDo1fGQ1GPNYcKzVGDrRFNhna9j725aBwc=; b=lXqQ8T2MQrtX4BvKEiGo8cQDZ A5nAD9aqtHVDcr7P0C+CPlM7IFG74wrZVJ5/6/SjHh7A76GR4xmbrG9ggb+/nnvik387X1uViEhmE 3RrJ/n8DK4CZpnbp8FHVxgTAK0SGNASgC2FQK6Qi7h3PpSwqIIPESLSQHWniRujgClW52KA+/zv62 u9FUYOFOjouU3U5CdPjCd71mlYmxrXXUpBcP9efb56GZXAPdLWvQmNvWFNx1xnJwEXzwudDcDP7FX WQg1Ee1scxtw36nWwq/RDtWCl9MkI5e1ygLFNltcf45FqirCydhm/uN2J9Qmcc+Uq7sCO+GV5CqD7 XCDYMXuNA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYLr0-0096aJ-3D; Mon, 19 Apr 2021 04:49:46 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYLqy-0096a8-P0 for linux-amlogic@desiato.infradead.org; Mon, 19 Apr 2021 04:49:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nwmKkdj5vxFBpFK3bj8w7Gz2YNFOXfPhegLyPurLzW0=; b=wV/TTEDYBzsSRoayU+dGbq5nsb jYU7wWdJh1sotCXbDRKsoG0VOHND8QPR1AvkFR64AvTZg0MnmYTnb2oXP9zg8tpbiedWrKMChFwqv LpfueAY62SDbBjY8YYGo3Z6iGqZRwCHk4uVRkB68i26LeAPxL5zMRW01RMvfGN3OSlBl/m52ClJsQ rCbtrrvdryeQ4lHYqECDPIeCsoRBLgr97t32khFJNpMM5WJKmWWhBpIQpBjas3vMa87s/8oql6/ii CWKJybcJWRZu51g46djjPq4wW9j1DNHxm5WBVtmG7qpj0iZKJKiNFMfS7mnkhliLKZ7cyQOhyVBEQ t93sg1YA==; Received: from gw.atmark-techno.com ([13.115.124.170]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYLqr-00AzPJ-Pn for linux-amlogic@lists.infradead.org; Mon, 19 Apr 2021 04:49:42 +0000 Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by gw.atmark-techno.com (Postfix) with ESMTPS id 99D7180570 for ; Mon, 19 Apr 2021 13:49:33 +0900 (JST) Received: by mail-ot1-f69.google.com with SMTP id u19-20020a9d4d930000b02902876395d43dso9223956otk.21 for ; Sun, 18 Apr 2021 21:49:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nwmKkdj5vxFBpFK3bj8w7Gz2YNFOXfPhegLyPurLzW0=; b=W4MI301dIWq4nhYz6CozFqUs6AkMNi3yfVb5Z5lVyuXqpCk7nqBtL9RXK53tHoJsft 7i+fmrCm4gnIKPAt0yySV1p3aC36712HvgkLpaEF/mnWikR3rDm8Lf70Ku9GbZASg+UR W87UIat0VIetw05Bv6ab2AhIjKFhhHhkw1p4m800f+tmAwzuDaf/zXGWg2VoDcTPjwXH SrWn5roBqH3AKEZA22e6Q2x4HhevxjLBhcf0R3y3oLdYp1967kO7qAVEsJoBIpviGy5E SSD9i8Kq2usKmvBd4UddBwtdgd/MhsT9gITeHEqSA9FuMZc/wPVYNC54Z3MDeqbMDoJZ O3Gw== X-Gm-Message-State: AOAM531MbM8YjM2Co9kz0aWgKwHvY3UZywxssXPJ3wU6RlIho3SjAZcG IljEDJWKnL4MjGwMwXQ3JrJnF71gjDKj0eVD9bUmXey0Y2SosLKszjcBUy3C7CT5pUkDJbKQGEl 6m4ZrsimsJ3zVvAGzH87B344UXidUJcNCx2M= X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145490pjg.189.1618807761145; Sun, 18 Apr 2021 21:49:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxUh9TJ2x/K//IB2lTaeXhs2rGXIpLK5cuzzNIi1YdNWpQlLZsRv610IvzYjHsCM08ZYf1MA== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145444pjg.189.1618807760853; Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from pc-0115 (117.209.187.35.bc.googleusercontent.com. [35.187.209.117]) by smtp.gmail.com with ESMTPSA id l22sm13247239pjc.13.2021.04.18.21.49.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from martinet by pc-0115 with local (Exim 4.94) (envelope-from ) id 1lYLqX-0016Kg-U8; Mon, 19 Apr 2021 13:49:17 +0900 Date: Mon, 19 Apr 2021 13:49:07 +0900 From: Dominique MARTINET To: "Alice Guo (OSS)" Cc: gregkh@linuxfoundation.org, rafael@kernel.org, horia.geanta@nxp.com, aymen.sghaier@nxp.com, herbert@gondor.apana.org.au, davem@davemloft.net, tony@atomide.com, geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, vkoul@kernel.org, peter.ujfalusi@gmail.com, a.hajda@samsung.com, narmstrong@baylibre.com, robert.foss@linaro.org, airlied@linux.ie, daniel@ffwll.ch, khilman@baylibre.com, tomba@kernel.org, jyri.sarha@iki.fi, joro@8bytes.org, will@kernel.org, mchehab@kernel.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, kishon@ti.com, kuba@kernel.org, linus.walleij@linaro.org, Roy.Pledge@nxp.com, leoyang.li@nxp.com, ssantosh@kernel.org, matthias.bgg@gmail.com, edubezval@gmail.com, j-keerthy@ti.com, balbi@kernel.org, linux@prisktech.co.nz, stern@rowland.harvard.edu, wim@linux-watchdog.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-staging@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER Message-ID: References: <20210419042722.27554-1-alice.guo@oss.nxp.com> <20210419042722.27554-2-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210419042722.27554-2-alice.guo@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210418_214937_978349_DC761AA0 X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org First comment overall for the whole serie: Since it is the solution I had suggested when I reported the problem[1] I have no qualm on the approach, comments for individual patches follow. [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800: > From: Alice Guo > > In i.MX8M boards, the registration of SoC device is later than caam > driver which needs it. Caam driver needs soc_device_match to provide > -EPROBE_DEFER when no SoC device is registered and no > early_soc_dev_attr. This patch should be last in the set: you can't have soc_device_match return an error before its callers handle it. > Signed-off-by: Alice Guo As the one who reported the problem I would have been appreciated being at least added to Ccs... I only happened to notice you posted this by chance. There is also not a single Fixes tag -- I believe this commit should have Fixes: 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure how such tags should be handled in case of multiple patches fixing something. -- Dominique _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7467CC433B4 for ; Mon, 19 Apr 2021 04:49:53 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8F2861157 for ; Mon, 19 Apr 2021 04:49:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8F2861157 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atmark-techno.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hhrM6fUVMMcqMADEPbC9isfgXip79IdpDTz0a+ktNfc=; b=dYiIzSdP8g1ff555kjbkZldVb hXxlUA+rj3uVTM5FpJ2SxBMoDmmwDlOCvIgW6Qdb4aLIH9kYKLqMJasqlHg+arLSHrsV8QVVUq/u/ 654TpN0AADtI/vE2djXe3Q28/3ZnEgcvz4v6tPD0I+npIH2hSBYQgVg2gB4K2ZySPXKdpSHYXmV5J h6OgJt3qd4g0NI4sdmwcVd9p7LpD5TAo4KeJphkkiU2ZVsMmoeK1n9e8Aow4fyDkn0LX47Ltk9Fvv wpNiWYGmVdbcH6/g3kMKEZug93tyYVTtAtcYzMVkkWtDvrQuESZnMKKK5v+thZso2ASUwehreSYYn Xw1cY6OXw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYLr4-0096bk-Of; Mon, 19 Apr 2021 04:49:50 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYLr1-0096aP-H0 for linux-phy@desiato.infradead.org; Mon, 19 Apr 2021 04:49:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nwmKkdj5vxFBpFK3bj8w7Gz2YNFOXfPhegLyPurLzW0=; b=wV/TTEDYBzsSRoayU+dGbq5nsb jYU7wWdJh1sotCXbDRKsoG0VOHND8QPR1AvkFR64AvTZg0MnmYTnb2oXP9zg8tpbiedWrKMChFwqv LpfueAY62SDbBjY8YYGo3Z6iGqZRwCHk4uVRkB68i26LeAPxL5zMRW01RMvfGN3OSlBl/m52ClJsQ rCbtrrvdryeQ4lHYqECDPIeCsoRBLgr97t32khFJNpMM5WJKmWWhBpIQpBjas3vMa87s/8oql6/ii CWKJybcJWRZu51g46djjPq4wW9j1DNHxm5WBVtmG7qpj0iZKJKiNFMfS7mnkhliLKZ7cyQOhyVBEQ t93sg1YA==; Received: from gw.atmark-techno.com ([13.115.124.170]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYLqr-00AzPK-Qo for linux-phy@lists.infradead.org; Mon, 19 Apr 2021 04:49:46 +0000 Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by gw.atmark-techno.com (Postfix) with ESMTPS id 45B7780534 for ; Mon, 19 Apr 2021 13:49:33 +0900 (JST) Received: by mail-oi1-f198.google.com with SMTP id r20-20020a0568080ab4b0290186e76a5ddaso753698oij.21 for ; Sun, 18 Apr 2021 21:49:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nwmKkdj5vxFBpFK3bj8w7Gz2YNFOXfPhegLyPurLzW0=; b=I/AG1lJ4sKg4KAqmO1fThkIesziTz+BOp+k4YXD4Rd2Y7V2lMD3+0o7I27RBPZYWId KsBZrC/r/y33mzUUKIvuyZDBe4o5GcmXJiFeB2NFO7DXOtONFnEXniEQ9NfXksTFIiMh zjCy3tv//WBdejZAH6lowSahA3wGnLEjuN8wyh9+bsm7RLdRUQIYdGvMVMO8V7NWwgQD RWAPxxvttpM4cYlwUK2nlQ0mTYAEUeoaihftLbTl6lfSiHNm/ClVPTcrEEE9VqSsGdDQ KR0c2IEQwk1mrF9KRx5hW1tHvarlDOXrrXwjZwOHuaBvAyVozdhDYSW+XH8N6fKxiale SPrw== X-Gm-Message-State: AOAM5317llHQc4wDcpo9CcyVbM9h1aSAxTwCUJprGCksJC1KrvZFBtw4 xYeNB2oSL8eQKf6+ZVTXSTB2LQwcOJRfGe9QsuWHzPgnP0NuAd1t6yNR1SsjoVmeBlXCm/rWrO4 rzMXjFE2YTgDY2LWuXr7lOc49YJ55Gg== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145500pjg.189.1618807761152; Sun, 18 Apr 2021 21:49:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxUh9TJ2x/K//IB2lTaeXhs2rGXIpLK5cuzzNIi1YdNWpQlLZsRv610IvzYjHsCM08ZYf1MA== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145444pjg.189.1618807760853; Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from pc-0115 (117.209.187.35.bc.googleusercontent.com. [35.187.209.117]) by smtp.gmail.com with ESMTPSA id l22sm13247239pjc.13.2021.04.18.21.49.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from martinet by pc-0115 with local (Exim 4.94) (envelope-from ) id 1lYLqX-0016Kg-U8; Mon, 19 Apr 2021 13:49:17 +0900 Date: Mon, 19 Apr 2021 13:49:07 +0900 From: Dominique MARTINET To: "Alice Guo (OSS)" Cc: gregkh@linuxfoundation.org, rafael@kernel.org, horia.geanta@nxp.com, aymen.sghaier@nxp.com, herbert@gondor.apana.org.au, davem@davemloft.net, tony@atomide.com, geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, vkoul@kernel.org, peter.ujfalusi@gmail.com, a.hajda@samsung.com, narmstrong@baylibre.com, robert.foss@linaro.org, airlied@linux.ie, daniel@ffwll.ch, khilman@baylibre.com, tomba@kernel.org, jyri.sarha@iki.fi, joro@8bytes.org, will@kernel.org, mchehab@kernel.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, kishon@ti.com, kuba@kernel.org, linus.walleij@linaro.org, Roy.Pledge@nxp.com, leoyang.li@nxp.com, ssantosh@kernel.org, matthias.bgg@gmail.com, edubezval@gmail.com, j-keerthy@ti.com, balbi@kernel.org, linux@prisktech.co.nz, stern@rowland.harvard.edu, wim@linux-watchdog.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-staging@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER Message-ID: References: <20210419042722.27554-1-alice.guo@oss.nxp.com> <20210419042722.27554-2-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210419042722.27554-2-alice.guo@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210418_214937_996836_081C2614 X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org First comment overall for the whole serie: Since it is the solution I had suggested when I reported the problem[1] I have no qualm on the approach, comments for individual patches follow. [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800: > From: Alice Guo > > In i.MX8M boards, the registration of SoC device is later than caam > driver which needs it. Caam driver needs soc_device_match to provide > -EPROBE_DEFER when no SoC device is registered and no > early_soc_dev_attr. This patch should be last in the set: you can't have soc_device_match return an error before its callers handle it. > Signed-off-by: Alice Guo As the one who reported the problem I would have been appreciated being at least added to Ccs... I only happened to notice you posted this by chance. There is also not a single Fixes tag -- I believe this commit should have Fixes: 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure how such tags should be handled in case of multiple patches fixing something. -- Dominique -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C33C433ED for ; Mon, 19 Apr 2021 06:24:19 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9DF560FDB for ; Mon, 19 Apr 2021 06:24:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9DF560FDB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atmark-techno.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FNxc11nKKz3c5S for ; Mon, 19 Apr 2021 16:24:17 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=atmark-techno.com (client-ip=13.115.124.170; helo=gw.atmark-techno.com; envelope-from=dominique.martinet@atmark-techno.com; receiver=) X-Greylist: delayed 531 seconds by postgrey-1.36 at boromir; Mon, 19 Apr 2021 14:58:29 AEST Received: from gw.atmark-techno.com (gw.atmark-techno.com [13.115.124.170]) by lists.ozlabs.org (Postfix) with ESMTP id 4FNvj16kj3z30Dk for ; Mon, 19 Apr 2021 14:58:28 +1000 (AEST) Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by gw.atmark-techno.com (Postfix) with ESMTPS id 8CF2C8056E for ; Mon, 19 Apr 2021 13:49:33 +0900 (JST) Received: by mail-ot1-f69.google.com with SMTP id u19-20020a9d4d930000b02902876395d43dso9223947otk.21 for ; Sun, 18 Apr 2021 21:49:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nwmKkdj5vxFBpFK3bj8w7Gz2YNFOXfPhegLyPurLzW0=; b=unMmiYjzbuRG94xtK4RZs4k21NvF0q7sNSGpiiEOeOe0wsWVJmPfZoZgZsWUUqatib lD6n9XzmZbsPnL425tDYpCgcL4bB2IbPnZpkcxlWX5S7emlgwmFq2gEvFRiLPCgLPL1y CIo71wnauhojFkRXcNCugYciBkwVtkMa+4ZwR9gzwOC3Gqf+0md2evO2RXfBtlPCgdmJ 8zXLqNnSCS685+gPtmsHJZXhAmBwyCNuLU9iH5z45TiTNjOKTANtn1ziPoH2d7gzTa/U 98ueXZVmpzMonzv6vG/AN75OjwSDuIZBmctxn7mnlGNEWIyNoZw06viTSkCKqgQKzSRG qeEQ== X-Gm-Message-State: AOAM532yspvr8u1RMshlFy1sA7Tt1idTBIgln1NAINWV32z0ePxZcHOp x6DXl7wyp+hGI/zq0n6f2Rz3Smhyk3FyOvPW6Yoi1sDSMZurdh8CTkJi9zmOtOjEqcmfMXXB7Mq 7T3TzORqgsGem9EWNgbwIL0ZKqu6tGQ== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145467pjg.189.1618807761124; Sun, 18 Apr 2021 21:49:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxUh9TJ2x/K//IB2lTaeXhs2rGXIpLK5cuzzNIi1YdNWpQlLZsRv610IvzYjHsCM08ZYf1MA== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145444pjg.189.1618807760853; Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from pc-0115 (117.209.187.35.bc.googleusercontent.com. [35.187.209.117]) by smtp.gmail.com with ESMTPSA id l22sm13247239pjc.13.2021.04.18.21.49.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from martinet by pc-0115 with local (Exim 4.94) (envelope-from ) id 1lYLqX-0016Kg-U8; Mon, 19 Apr 2021 13:49:17 +0900 Date: Mon, 19 Apr 2021 13:49:07 +0900 From: Dominique MARTINET To: "Alice Guo (OSS)" Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER Message-ID: References: <20210419042722.27554-1-alice.guo@oss.nxp.com> <20210419042722.27554-2-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210419042722.27554-2-alice.guo@oss.nxp.com> X-Mailman-Approved-At: Mon, 19 Apr 2021 16:21:18 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ulf.hansson@linaro.org, aymen.sghaier@nxp.com, geert+renesas@glider.be, rafael@kernel.org, airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, a.hajda@samsung.com, netdev@vger.kernel.org, linux-phy@lists.infradead.org, will@kernel.org, linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org, wim@linux-watchdog.org, herbert@gondor.apana.org.au, horia.geanta@nxp.com, khilman@baylibre.com, joro@8bytes.org, narmstrong@baylibre.com, linux-staging@lists.linux.dev, iommu@lists.linux-foundation.org, peter.ujfalusi@gmail.com, kishon@ti.com, tony@atomide.com, linux-omap@vger.kernel.org, stern@rowland.harvard.edu, kuba@kernel.org, linus.walleij@linaro.org, linux@roeck-us.net, linux-media@vger.kernel.org, linux-watchdog@vger.kernel.org, Roy.Pledge@nxp.com, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, edubezval@gmail.com, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, ssantosh@kernel.org, matthias.bgg@gmail.com, linux-amlogic@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, balbi@kernel.org, tomba@kernel.org, sboyd@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, robert.foss@linaro.org, leoyang.li@nxp.com, linux@prisktech.co.nz, vkoul@kernel.org, linux-crypto@vger.kernel.org, daniel@ffwll.ch, j-keerthy@ti.com, dmaengine@vger.kernel.org, jyri.sarha@iki.fi, davem@davemloft.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" First comment overall for the whole serie: Since it is the solution I had suggested when I reported the problem[1] I have no qualm on the approach, comments for individual patches follow. [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800: > From: Alice Guo > > In i.MX8M boards, the registration of SoC device is later than caam > driver which needs it. Caam driver needs soc_device_match to provide > -EPROBE_DEFER when no SoC device is registered and no > early_soc_dev_attr. This patch should be last in the set: you can't have soc_device_match return an error before its callers handle it. > Signed-off-by: Alice Guo As the one who reported the problem I would have been appreciated being at least added to Ccs... I only happened to notice you posted this by chance. There is also not a single Fixes tag -- I believe this commit should have Fixes: 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure how such tags should be handled in case of multiple patches fixing something. -- Dominique From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E9CC433ED for ; Mon, 19 Apr 2021 06:43:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 214646101C for ; Mon, 19 Apr 2021 06:43:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 214646101C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atmark-techno.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 417C96E1BA; Mon, 19 Apr 2021 06:42:58 +0000 (UTC) X-Greylist: delayed 545 seconds by postgrey-1.36 at gabe; Mon, 19 Apr 2021 04:58:28 UTC Received: from gw.atmark-techno.com (gw.atmark-techno.com [13.115.124.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D7F589ECD for ; Mon, 19 Apr 2021 04:58:28 +0000 (UTC) Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by gw.atmark-techno.com (Postfix) with ESMTPS id 2422C804A0 for ; Mon, 19 Apr 2021 13:49:22 +0900 (JST) Received: by mail-pg1-f200.google.com with SMTP id b2-20020a6567c20000b02901fda3676f83so5550193pgs.9 for ; Sun, 18 Apr 2021 21:49:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nwmKkdj5vxFBpFK3bj8w7Gz2YNFOXfPhegLyPurLzW0=; b=Ft537shWNsviQsZNB2/wWxZqVaQ7I72PFzT7bqeisnMijTwEj5zdIA59XiLKtZhEEl tiQ77EY0FblEipJGJFutDFUEnJwmz+Gvwvm5TwfV5eYbmYTotwLuVKouurZIbAqeoruG ioU2ENDch0FNc8JCbr0nLEZ7UY/oAmIz3iDAxM1a2/oMyM3fi3Ruixwqy0cMKzrzsioO RH523t8hryFnie1vzgpkq3IyuLD5L6pCLcEoGdGYYK6apDrJh4/ulwSU3HCxOSn4vlPi 8a8K1t9u4LI/ea/3ZXIf9Ly3r/QCEWE7wzDYTt1MsVP5MoyCRzbDeo4UXheRdEDeu0Fw 0vnA== X-Gm-Message-State: AOAM533MeUshreRfJXir4i180ssKTEHDwKM1+wSK74wDL1MheriT098K B5MJEwCZ/1QhWxS8vzVC4K3X57+GpElm17ga28vZJZrl3J8UQOEDTdz7w5FF1A6HkR2gsBcuxDl FkH72PWNLM3t/epXHUnXlQn+ArU/3VDoA X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145495pjg.189.1618807761146; Sun, 18 Apr 2021 21:49:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxUh9TJ2x/K//IB2lTaeXhs2rGXIpLK5cuzzNIi1YdNWpQlLZsRv610IvzYjHsCM08ZYf1MA== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145444pjg.189.1618807760853; Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from pc-0115 (117.209.187.35.bc.googleusercontent.com. [35.187.209.117]) by smtp.gmail.com with ESMTPSA id l22sm13247239pjc.13.2021.04.18.21.49.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from martinet by pc-0115 with local (Exim 4.94) (envelope-from ) id 1lYLqX-0016Kg-U8; Mon, 19 Apr 2021 13:49:17 +0900 Date: Mon, 19 Apr 2021 13:49:07 +0900 From: Dominique MARTINET To: "Alice Guo (OSS)" Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER Message-ID: References: <20210419042722.27554-1-alice.guo@oss.nxp.com> <20210419042722.27554-2-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210419042722.27554-2-alice.guo@oss.nxp.com> X-Mailman-Approved-At: Mon, 19 Apr 2021 06:42:50 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ulf.hansson@linaro.org, aymen.sghaier@nxp.com, geert+renesas@glider.be, rafael@kernel.org, airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, a.hajda@samsung.com, netdev@vger.kernel.org, linux-phy@lists.infradead.org, will@kernel.org, linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org, wim@linux-watchdog.org, herbert@gondor.apana.org.au, horia.geanta@nxp.com, khilman@baylibre.com, joro@8bytes.org, narmstrong@baylibre.com, linux-staging@lists.linux.dev, iommu@lists.linux-foundation.org, peter.ujfalusi@gmail.com, kishon@ti.com, tony@atomide.com, linux-omap@vger.kernel.org, stern@rowland.harvard.edu, kuba@kernel.org, linux@roeck-us.net, linux-media@vger.kernel.org, linux-watchdog@vger.kernel.org, Roy.Pledge@nxp.com, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, edubezval@gmail.com, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, ssantosh@kernel.org, matthias.bgg@gmail.com, linux-amlogic@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, balbi@kernel.org, tomba@kernel.org, sboyd@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, robert.foss@linaro.org, leoyang.li@nxp.com, linux@prisktech.co.nz, vkoul@kernel.org, linux-crypto@vger.kernel.org, j-keerthy@ti.com, dmaengine@vger.kernel.org, jyri.sarha@iki.fi, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" First comment overall for the whole serie: Since it is the solution I had suggested when I reported the problem[1] I have no qualm on the approach, comments for individual patches follow. [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800: > From: Alice Guo > > In i.MX8M boards, the registration of SoC device is later than caam > driver which needs it. Caam driver needs soc_device_match to provide > -EPROBE_DEFER when no SoC device is registered and no > early_soc_dev_attr. This patch should be last in the set: you can't have soc_device_match return an error before its callers handle it. > Signed-off-by: Alice Guo As the one who reported the problem I would have been appreciated being at least added to Ccs... I only happened to notice you posted this by chance. There is also not a single Fixes tag -- I believe this commit should have Fixes: 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure how such tags should be handled in case of multiple patches fixing something. -- Dominique _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D53C43462 for ; Mon, 19 Apr 2021 07:07:25 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 440ED6101D for ; Mon, 19 Apr 2021 07:07:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 440ED6101D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atmark-techno.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7BC04836F6; Mon, 19 Apr 2021 07:07:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z2l0FTCcntsX; Mon, 19 Apr 2021 07:07:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTP id 465018367C; Mon, 19 Apr 2021 07:07:23 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B80B4C0029; Mon, 19 Apr 2021 07:07:22 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id B8842C000B for ; Mon, 19 Apr 2021 04:58:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 9CCDC4036A for ; Mon, 19 Apr 2021 04:58:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tvJR1SbvIhNZ for ; Mon, 19 Apr 2021 04:58:28 +0000 (UTC) X-Greylist: delayed 00:08:53 by SQLgrey-1.8.0 Received: from gw.atmark-techno.com (gw.atmark-techno.com [13.115.124.170]) by smtp4.osuosl.org (Postfix) with ESMTP id 3B6F140368 for ; Mon, 19 Apr 2021 04:58:28 +0000 (UTC) Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by gw.atmark-techno.com (Postfix) with ESMTPS id 372E680532 for ; Mon, 19 Apr 2021 13:49:33 +0900 (JST) Received: by mail-ot1-f71.google.com with SMTP id f89-20020a9d2c620000b0290280d753a255so9238975otb.2 for ; Sun, 18 Apr 2021 21:49:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nwmKkdj5vxFBpFK3bj8w7Gz2YNFOXfPhegLyPurLzW0=; b=lqQpp6OZgCYlphwq+spPNKi1Vr5EETUE8ODqtNvyD+vIVJ5wE+sK8dvJ3vYGReMIyn jrKOUvm+XycCCksLzMNzzzOywM8JxePl2K4NF1ezeGcHaEcBEds2o2bq+AvO67MMBDn4 aMtreZjQMjR9wxPqGmEc4exYDi2ZWWLQWM63ubKe1lPqt23l4ZK6SM/vJvhD7kLtHr3m AZVNQ10bgReKf97VLxynIBDzjCWhvGLgKpKw7PiE/8aImMX38pvULBg7YwOKPb+WrXMo Ihm8W3P0RTUeaN8oTERqUt2cWiu+JcBw5ITbC6/AtcaJnG2Sy71mAHUY9cvGh1baENGO WJ9w== X-Gm-Message-State: AOAM53227LWI6PL+gxI5ET79NRtWH18/HY08ohaxLvN6z3bglD3fc3vd Iz3jr979fn2qppizkOcTqZBrHzJA3FNWhNPi7qfNfTku2VZbYIBnTjCat/HSaUNPr9gdkHfjjG8 Ec4IYKVd9H8wTCyvD0UVIffbkcGk+9h0A9Q== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145501pjg.189.1618807761153; Sun, 18 Apr 2021 21:49:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxUh9TJ2x/K//IB2lTaeXhs2rGXIpLK5cuzzNIi1YdNWpQlLZsRv610IvzYjHsCM08ZYf1MA== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr10145444pjg.189.1618807760853; Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from pc-0115 (117.209.187.35.bc.googleusercontent.com. [35.187.209.117]) by smtp.gmail.com with ESMTPSA id l22sm13247239pjc.13.2021.04.18.21.49.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Apr 2021 21:49:20 -0700 (PDT) Received: from martinet by pc-0115 with local (Exim 4.94) (envelope-from ) id 1lYLqX-0016Kg-U8; Mon, 19 Apr 2021 13:49:17 +0900 Date: Mon, 19 Apr 2021 13:49:07 +0900 From: Dominique MARTINET To: "Alice Guo (OSS)" Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER Message-ID: References: <20210419042722.27554-1-alice.guo@oss.nxp.com> <20210419042722.27554-2-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210419042722.27554-2-alice.guo@oss.nxp.com> X-Mailman-Approved-At: Mon, 19 Apr 2021 07:07:20 +0000 Cc: ulf.hansson@linaro.org, aymen.sghaier@nxp.com, geert+renesas@glider.be, rafael@kernel.org, airlied@linux.ie, mturquette@baylibre.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, a.hajda@samsung.com, netdev@vger.kernel.org, linux-phy@lists.infradead.org, will@kernel.org, linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org, wim@linux-watchdog.org, herbert@gondor.apana.org.au, horia.geanta@nxp.com, khilman@baylibre.com, narmstrong@baylibre.com, linux-staging@lists.linux.dev, iommu@lists.linux-foundation.org, peter.ujfalusi@gmail.com, kishon@ti.com, tony@atomide.com, linux-omap@vger.kernel.org, stern@rowland.harvard.edu, kuba@kernel.org, linus.walleij@linaro.org, linux@roeck-us.net, linux-media@vger.kernel.org, linux-watchdog@vger.kernel.org, Roy.Pledge@nxp.com, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, edubezval@gmail.com, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, ssantosh@kernel.org, matthias.bgg@gmail.com, linux-amlogic@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, balbi@kernel.org, tomba@kernel.org, sboyd@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, robert.foss@linaro.org, leoyang.li@nxp.com, linux@prisktech.co.nz, vkoul@kernel.org, linux-crypto@vger.kernel.org, daniel@ffwll.ch, j-keerthy@ti.com, dmaengine@vger.kernel.org, jyri.sarha@iki.fi, davem@davemloft.net X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" First comment overall for the whole serie: Since it is the solution I had suggested when I reported the problem[1] I have no qualm on the approach, comments for individual patches follow. [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800: > From: Alice Guo > > In i.MX8M boards, the registration of SoC device is later than caam > driver which needs it. Caam driver needs soc_device_match to provide > -EPROBE_DEFER when no SoC device is registered and no > early_soc_dev_attr. This patch should be last in the set: you can't have soc_device_match return an error before its callers handle it. > Signed-off-by: Alice Guo As the one who reported the problem I would have been appreciated being at least added to Ccs... I only happened to notice you posted this by chance. There is also not a single Fixes tag -- I believe this commit should have Fixes: 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure how such tags should be handled in case of multiple patches fixing something. -- Dominique _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu