From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v2 1/1] mfd: intel_quark_i2c_gpio: Don't play dirty trick with const
Date: Wed, 14 Apr 2021 20:52:23 +0300 [thread overview]
Message-ID: <YHcr144krHDay72g@smile.fi.intel.com> (raw)
In-Reply-To: <20210414171319.GQ4869@dell>
On Wed, Apr 14, 2021 at 06:13:19PM +0100, Lee Jones wrote:
> On Fri, 26 Mar 2021, Lee Jones wrote:
>
> > On Fri, 26 Mar 2021, Andy Shevchenko wrote:
> >
> > > As Linus rightfully noticed, the driver plays dirty trick with const,
> > > i.e. it assigns a place holder data structure to the const field
> > > in the MFD cell and then drops the const by explicit casting. This is
> > > not how it should be.
> > >
> > > Assign local pointers of the cell and resource to the respective
> > > non-const place holders in the intel_quark_i2c_setup() and
> > > intel_quark_gpio_setup().
> > >
> > > Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > v2: eliminated bar parameter (Lee)
> > > drivers/mfd/intel_quark_i2c_gpio.c | 26 ++++++++++++--------------
> > > 1 file changed, 12 insertions(+), 14 deletions(-)
> >
> > Neat.
> >
> > Applied, thanks.
>
> Am I still missing patches from you Andy?
Patches for fixes should be applied to for-next as well. I don't know why with
my patches it diverged.
I have already commented on this when kbuild bot complained.
So,
git checkout for-mfd-next
git merge for-mfd-fixes
or equivalent (cherry-pick) will fix that.
> I get:
>
> make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- 'CC=sccache x86_64-linux-gnu-gcc' 'HOSTCC=sccache gcc' allmodconfig
> make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- 'CC=sccache x86_64-linux-gnu-gcc' 'HOSTCC=sccache gcc'
> /builds/linux/drivers/mfd/intel_quark_i2c_gpio.c: In function 'intel_quark_i2c_setup':
> /builds/linux/drivers/mfd/intel_quark_i2c_gpio.c:181:25: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> struct resource *res = intel_quark_i2c_res;
> ^~~~~~~~~~~~~~~~~~~
> /builds/linux/drivers/mfd/intel_quark_i2c_gpio.c: In function 'intel_quark_gpio_setup':
> /builds/linux/drivers/mfd/intel_quark_i2c_gpio.c:203:25: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> struct resource *res = intel_quark_gpio_res;
> ^~~~~~~~~~~~~~~~~~~~
>
> Link to the build (see: build.log):
>
> https://builds.tuxbuild.com/1rAMovpd041jvsjfQ538kW3nvYK/
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-14 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 12:48 [PATCH v2 1/1] mfd: intel_quark_i2c_gpio: Don't play dirty trick with const Andy Shevchenko
2021-03-26 14:51 ` Lee Jones
2021-04-14 17:13 ` Lee Jones
2021-04-14 17:52 ` Andy Shevchenko [this message]
2021-04-14 21:19 ` Lee Jones
2021-04-15 11:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHcr144krHDay72g@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.