From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>, Rob Herring <robh@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Itaru Kitayama <itaru.kitayama@gmail.com>
Subject: Re: [PATCH v8 2/4] libperf: Add evsel mmap support
Date: Thu, 15 Apr 2021 16:37:10 -0300 [thread overview]
Message-ID: <YHiV5vqSD3TmUspL@kernel.org> (raw)
In-Reply-To: <CAM9d7chYYa5B-QR6xNJG5NeLb0ENv5inLdLMqT_e+8jkRZZCJA@mail.gmail.com>
Em Thu, Apr 15, 2021 at 04:14:31AM +0900, Namhyung Kim escreveu:
> On Thu, Apr 15, 2021 at 3:23 AM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >
> > Em Wed, Apr 14, 2021 at 03:02:08PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Thu, Apr 15, 2021 at 01:41:35AM +0900, Namhyung Kim escreveu:
> > > > Hello,
> > > >
> > > > On Thu, Apr 15, 2021 at 1:07 AM Rob Herring <robh@kernel.org> wrote:
> > > > > +void *perf_evsel__mmap_base(struct perf_evsel *evsel, int cpu, int thread)
> > > > > +{
> > > > > + if (FD(evsel, cpu, thread) < 0 || MMAP(evsel, cpu, thread) == NULL)
> > > > > + return NULL;
> > > >
> > > > I think you should check the cpu and the thread is in
> > > > a valid range. Currently xyarray__entry() simply accesses
> > > > the content without checking the boundaries.
> > >
> > > So, since xyarray has the bounds, it should check it, i.e. we need to
> > > have a __xyarray__entry() that is what xyarray__entry() does, i.e.
> > > assume the values have been bounds checked, then a new method,
> > > xyarray__entry() that does bounds check, if it fails, return NULL,
> > > otherwise calls __xyarray__entry().
> > >
> > > I see this is frustrating and I should've chimed in earlier, but at
> > > least now this is getting traction, and the end result will be better
> > > not just for the feature you've been dilligently working on,
> > >
> > > Thank you for your persistence,
> >
> > Re-reading, yeah, this can be done in a separate patch, Namhyung, can I
> > have your Reviewed-by? That or an Acked-by?
>
> Sure, for the series:
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Ok, b4 failed on it, probably some missing Reply to, so I'll apply it by
hand:
[acme@five perf]$ b4 am -t -s -l --cc-trailers 20210414155412.3697605-1-robh@kernel.org
Looking up https://lore.kernel.org/r/20210414155412.3697605-1-robh%40kernel.org
Grabbing thread from lore.kernel.org/lkml
Analyzing 11 messages in the thread
---
Thread incomplete, attempting to backfill
---
Writing ./v8_20210414_robh_libperf_userspace_counter_access.mbx
[PATCH v8 1/4] tools/include: Add an initial math64.h
+ Acked-by: Namhyung Kim <namhyung@kernel.org>
+ Acked-by: Jiri Olsa <jolsa@redhat.com> (✓ DKIM/redhat.com)
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
+ Link: https://lore.kernel.org/r/20210414155412.3697605-2-robh@kernel.org
+ Cc: Catalin Marinas <catalin.marinas@arm.com>
+ Cc: Mark Rutland <mark.rutland@arm.com>
+ Cc: Itaru Kitayama <itaru.kitayama@gmail.com>
+ Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
+ Cc: Will Deacon <will@kernel.org>
+ Cc: Ingo Molnar <mingo@redhat.com>
+ Cc: linux-kernel@vger.kernel.org
ERROR: missing [2/4]!
[PATCH v8 3/4] libperf: tests: Add support for verbose printing
+ Acked-by: Jiri Olsa <jolsa@redhat.com> (✓ DKIM/redhat.com)
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
+ Link: https://lore.kernel.org/r/20210414155412.3697605-3-robh@kernel.org
+ Cc: Catalin Marinas <catalin.marinas@arm.com>
+ Cc: Mark Rutland <mark.rutland@arm.com>
+ Cc: Itaru Kitayama <itaru.kitayama@gmail.com>
+ Cc: Peter Zijlstra <peterz@infradead.org>
+ Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
+ Cc: Namhyung Kim <namhyung@kernel.org>
+ Cc: Will Deacon <will@kernel.org>
+ Cc: Ingo Molnar <mingo@redhat.com>
+ Cc: linux-kernel@vger.kernel.org
[PATCH v8 4/4] libperf: Add support for user space counter access
+ Acked-by: Jiri Olsa <jolsa@redhat.com> (✓ DKIM/redhat.com)
+ Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
+ Link: https://lore.kernel.org/r/20210414155412.3697605-4-robh@kernel.org
+ Cc: Catalin Marinas <catalin.marinas@arm.com>
+ Cc: Mark Rutland <mark.rutland@arm.com>
+ Cc: Itaru Kitayama <itaru.kitayama@gmail.com>
+ Cc: Peter Zijlstra <peterz@infradead.org>
+ Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
+ Cc: Namhyung Kim <namhyung@kernel.org>
+ Cc: Will Deacon <will@kernel.org>
+ Cc: Ingo Molnar <mingo@redhat.com>
+ Cc: linux-kernel@vger.kernel.org
---
Total patches: 3
---
WARNING: Thread incomplete!
Cover: ./v8_20210414_robh_libperf_userspace_counter_access.cover
Link: https://lore.kernel.org/r/20210414155412.3697605-1-robh@kernel.org
Base: not found
git am ./v8_20210414_robh_libperf_userspace_counter_access.mbx
[acme@five perf]$
next prev parent reply other threads:[~2021-04-15 19:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 15:54 [PATCH v8 0/4] libperf userspace counter access Rob Herring
2021-04-14 15:54 ` [PATCH v8 1/4] tools/include: Add an initial math64.h Rob Herring
2021-04-14 16:07 ` [PATCH v8 2/4] libperf: Add evsel mmap support Rob Herring
2021-04-14 16:41 ` Namhyung Kim
2021-04-14 16:53 ` Rob Herring
2021-04-14 17:45 ` Namhyung Kim
2021-04-14 18:02 ` Arnaldo Carvalho de Melo
2021-04-14 18:23 ` Arnaldo Carvalho de Melo
2021-04-14 19:14 ` Namhyung Kim
2021-04-15 19:37 ` Arnaldo Carvalho de Melo [this message]
2021-04-15 20:09 ` Rob Herring
2021-04-15 20:20 ` Arnaldo Carvalho de Melo
2021-04-14 16:07 ` [PATCH v8 3/4] libperf: tests: Add support for verbose printing Rob Herring
2021-04-14 16:07 ` [PATCH v8 4/4] libperf: Add support for user space counter access Rob Herring
2021-04-20 11:10 ` Arnaldo Carvalho de Melo
2021-04-14 19:20 ` [PATCH v8 0/4] libperf userspace " Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHiV5vqSD3TmUspL@kernel.org \
--to=acme@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=itaru.kitayama@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.