From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07C8C2F81 for ; Thu, 22 Apr 2021 20:27:29 +0000 (UTC) Received: from relay7-d.mail.gandi.net (unknown [217.70.183.200]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 9DA9DE54E7 for ; Thu, 22 Apr 2021 20:15:40 +0000 (UTC) X-Originating-IP: 89.83.200.203 Received: from localhost (i15-lef02-th2-89-83-200-203.ft.lns.abo.bbox.fr [89.83.200.203]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 3927320003; Thu, 22 Apr 2021 20:15:32 +0000 (UTC) Date: Thu, 22 Apr 2021 22:15:31 +0200 From: Alexandre Belloni To: Johannes Berg Cc: Mauro Carvalho Chehab , Dan Carpenter , James Bottomley , ksummit@lists.linux.dev Subject: Re: [MAINTAINER SUMMIT] Rethinking the acceptance policy for "trivial" patches Message-ID: References: <20210421194702.GH1981@kadam> <20210422113404.09f35a85@coco.lan> <68c628ed354ea1ddea81878f0d713d2ce6426126.camel@sipsolutions.net> X-Mailing-List: ksummit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68c628ed354ea1ddea81878f0d713d2ce6426126.camel@sipsolutions.net> On 22/04/2021 11:59:38+0200, Johannes Berg wrote: > On Thu, 2021-04-22 at 11:34 +0200, Mauro Carvalho Chehab wrote: > > > > Here, I use "wdiff" in order to deal with renames. It has a somewhat > > funny dialect, but it helps a lot reviewing renaming patches. > > This also helps for casual "git show" etc.: > > [core] > pager = /usr/share/git-core/contrib/diff-highlight | less -RFX > > (path may vary, of course) > I've been shown https://github.com/dandavison/delta/ a little while ago and it has a very good side by side view, showing exactly what change on each line. I'm using: [core] pager = delta [delta] plus-color = "#012800" minus-color = "#340001" syntax-theme = Solarized (light) line-numbers = true side-by-side = true -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com