From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ABFFC433ED for ; Fri, 14 May 2021 14:38:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20E0D6144B for ; Fri, 14 May 2021 14:38:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234206AbhENOjb (ORCPT ); Fri, 14 May 2021 10:39:31 -0400 Received: from mail.skyhub.de ([5.9.137.197]:41236 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232520AbhENOja (ORCPT ); Fri, 14 May 2021 10:39:30 -0400 Received: from zn.tnic (p200300ec2f0b2c001b1c8d89a706f2ca.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:2c00:1b1c:8d89:a706:f2ca]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 202691EC0537; Fri, 14 May 2021 16:38:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1621003098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=56UXFskDRro/v9sxWzMI7cd2EQdQ1g/Ab6XrYnboPHY=; b=l6ulfs7RoVDOCFi04UqltMLII+y7afq7VEDMQQhzJJPZPFDp6UHaD/pm7/7eODbSlyEhaI IK0IZk+2mBuk8WS0N5i28eS2uqsDJ2kq2vKTIoxz1v1fzTBaYZyhaPeh+NPIT3TnQc1gwB opRwOpFGOAq43qMhE700hrizvFOpRfs= Date: Fri, 14 May 2021 16:38:14 +0200 From: Borislav Petkov To: "Joshi, Mukul" Cc: "amd-gfx@lists.freedesktop.org" , "Kasiviswanathan, Harish" , x86-ml , lkml Subject: Re: [PATCH] drm/amdgpu: Register bad page handler for Aldebaran Message-ID: References: <20210512013058.6827-1-mukul.joshi@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 01:06:33PM +0000, Joshi, Mukul wrote: > We have RAS functionality in other ASICs that is not dependent on > CONFIG_X86_MCE_AMD. So, I don't think we would want to do that just > for one ASIC. Lemme try again: you said that those errors do get reported through a deferred interrupt. Which is likely amd_deferred_error_interrupt(). If it is that interrupt and you don't have CONFIG_X86_MCE_AMD enabled, then you won't get any errors reported and your RAS functionality will simply sit there inactive. So if that above is true - something to which I'm still not getting an answer but maybe one fine day... - so if that above is true, your RAS functionality *needs* CONFIG_X86_MCE_AMD to be enabled in order to *actually* function. So you *must* make your RAS functionality depend on CONFIG_X86_MCE_AMD - otherwise no deferred interrupts and no errors reported. It is that simple. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26042C433ED for ; Fri, 14 May 2021 15:29:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C20AA613DF for ; Fri, 14 May 2021 15:29:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C20AA613DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A81A6EEC1; Fri, 14 May 2021 15:29:10 +0000 (UTC) Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by gabe.freedesktop.org (Postfix) with ESMTPS id 440CB6EE91 for ; Fri, 14 May 2021 14:38:20 +0000 (UTC) Received: from zn.tnic (p200300ec2f0b2c001b1c8d89a706f2ca.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:2c00:1b1c:8d89:a706:f2ca]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 202691EC0537; Fri, 14 May 2021 16:38:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1621003098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=56UXFskDRro/v9sxWzMI7cd2EQdQ1g/Ab6XrYnboPHY=; b=l6ulfs7RoVDOCFi04UqltMLII+y7afq7VEDMQQhzJJPZPFDp6UHaD/pm7/7eODbSlyEhaI IK0IZk+2mBuk8WS0N5i28eS2uqsDJ2kq2vKTIoxz1v1fzTBaYZyhaPeh+NPIT3TnQc1gwB opRwOpFGOAq43qMhE700hrizvFOpRfs= Date: Fri, 14 May 2021 16:38:14 +0200 From: Borislav Petkov To: "Joshi, Mukul" Subject: Re: [PATCH] drm/amdgpu: Register bad page handler for Aldebaran Message-ID: References: <20210512013058.6827-1-mukul.joshi@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Fri, 14 May 2021 15:29:09 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86-ml , "Kasiviswanathan, Harish" , lkml , "amd-gfx@lists.freedesktop.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, May 14, 2021 at 01:06:33PM +0000, Joshi, Mukul wrote: > We have RAS functionality in other ASICs that is not dependent on > CONFIG_X86_MCE_AMD. So, I don't think we would want to do that just > for one ASIC. Lemme try again: you said that those errors do get reported through a deferred interrupt. Which is likely amd_deferred_error_interrupt(). If it is that interrupt and you don't have CONFIG_X86_MCE_AMD enabled, then you won't get any errors reported and your RAS functionality will simply sit there inactive. So if that above is true - something to which I'm still not getting an answer but maybe one fine day... - so if that above is true, your RAS functionality *needs* CONFIG_X86_MCE_AMD to be enabled in order to *actually* function. So you *must* make your RAS functionality depend on CONFIG_X86_MCE_AMD - otherwise no deferred interrupts and no errors reported. It is that simple. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx