From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6FF3C43460 for ; Tue, 11 May 2021 11:48:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D970F613B4 for ; Tue, 11 May 2021 11:48:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231460AbhEKLtP (ORCPT ); Tue, 11 May 2021 07:49:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:59398 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230400AbhEKLtO (ORCPT ); Tue, 11 May 2021 07:49:14 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1620733687; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E77vEFrSkLVZEEYzBk3YTtVmGYYbCEngbIKXJXgn1lE=; b=FNKlUt0qKP32FkKDSjrlOl6Sj4jbJTnqDhgVkis/5HueyFUMy8THzXQVH+tlqPzA6eAp+4 AXbvT6dCpaGb/pCnMLjaokfdl4GXL5yqkWfD2wmXCC7jZqel7+xnUKJXK3JmahwhZ3Z/72 5KgGPpFq70MJRQXZ0D0W3XZdygmA7AQ= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2EC02B1B5; Tue, 11 May 2021 11:48:07 +0000 (UTC) Date: Tue, 11 May 2021 13:48:06 +0200 From: Petr Mladek To: Stephen Boyd Cc: Andrew Morton , linux-kernel@vger.kernel.org, Alexei Starovoitov , Andy Shevchenko , Baoquan He , Borislav Petkov , Catalin Marinas , Dave Young , Evan Green , Hsin-Yi Wang , Ingo Molnar , Jessica Yu , Jiri Olsa , kexec@lists.infradead.org, Konstantin Khlebnikov , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, Matthew Wilcox , Rasmus Villemoes , Sasha Levin , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , Vivek Goyal , Will Deacon , x86@kernel.org, Christoph Hellwig , peter enderborg Subject: Re: [PATCH v6 00/13] Add build ID to stacktraces Message-ID: References: <20210511003845.2429846-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511003845.2429846-1-swboyd@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2021-05-10 17:38:32, Stephen Boyd wrote: > This series adds the kernel's build ID[1] to the stacktrace header > printed in oops messages, warnings, etc. and the build ID for any module > that appears in the stacktrace after the module name. The goal is to > make the stacktrace more self-contained and descriptive by including the > relevant build IDs in the kernel logs when something goes wrong. This > can be used by post processing tools like script/decode_stacktrace.sh > and kernel developers to easily locate the debug info associated with a > kernel crash and line up what line and file things started falling apart > at. The entire series looks good to me. I reviewed carefully only the 5th patch touching printk/kallsyms/module code. I just scanned over the other patches touching kernel code and did not notice any obvious problem. I did not check the changes in decode_stacktrace.sh at all. I tried to get stacktraces on x86_64 and it worked as expected. Best Regards, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 215D5C433ED for ; Tue, 11 May 2021 13:14:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B382B616EB for ; Tue, 11 May 2021 13:14:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B382B616EB Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jAkaDFSADHrAeqrK/f6yPLuqcMIoo0/vLfazT1MeDaM=; b=C61ZBR+zh8ihn6zt1n9ZC83YN YqKelTGlxUVLxTfRNWroORq5LZszF82RSmnjtyfVH/tvkPKn+Jr0SxpFyfF62Z+CtfxfbvaZWVb6m 4oMYItMK0H5pr+eYexhJ1rcaKFc/E+8WwHprcANL3lAVR5lScx6uRfPwaF7Hqa14MXddc8UtMuzjl 3NHQqJv1LVMhxlaqTy9tf16xlvj+XHm7kqGcTikSPA4fL6GrSBBFeTiTI0UCqohdI2PCTXuDmD/vv 7xyw/w5f2jo56ER8NSdNjU3mNl0SIwEfExZveuntuMBQCdALUY227pN907Cc6l8BxMgIX+fsaUsFA jigwMmnqA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgSBn-0000c8-4R; Tue, 11 May 2021 13:12:43 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQrz-00HCm9-MF; Tue, 11 May 2021 11:48:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E77vEFrSkLVZEEYzBk3YTtVmGYYbCEngbIKXJXgn1lE=; b=q8YIy3HkUMkam1d0PL/JGWwWW1 vN8iVsa5kS23P2Bbw4NgpSdU8pWE/jEcl8R/ZP6G9nHHDZQlIwdTvdI2SoL/MXJi+72FLAhYk7u4s RwJ7qYhtgI/RvnfhKhjB5IcrhNwRxUCcnhdjMpTX5Do4Hxl52wS3N40ErAMeX6I1ALYVpmhYpae7S Cj+JGvVk6VFyz4Vn5NVdt+6axzdisZRxvwK2qUXC3ukqoF7+hEY7oour8lTBDOTf39pwsu1WkhYzA mbys0f1JrBIGB93Nh+UfbhFUnz+FRmsZQqHYYF9e3LtqGZqmId3mv4s20NCfF58gSlFalzeCccB/1 Ogqh+uGw==; Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQrx-009X6Y-4a; Tue, 11 May 2021 11:48:10 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1620733687; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E77vEFrSkLVZEEYzBk3YTtVmGYYbCEngbIKXJXgn1lE=; b=FNKlUt0qKP32FkKDSjrlOl6Sj4jbJTnqDhgVkis/5HueyFUMy8THzXQVH+tlqPzA6eAp+4 AXbvT6dCpaGb/pCnMLjaokfdl4GXL5yqkWfD2wmXCC7jZqel7+xnUKJXK3JmahwhZ3Z/72 5KgGPpFq70MJRQXZ0D0W3XZdygmA7AQ= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2EC02B1B5; Tue, 11 May 2021 11:48:07 +0000 (UTC) Date: Tue, 11 May 2021 13:48:06 +0200 From: Petr Mladek To: Stephen Boyd Cc: Andrew Morton , linux-kernel@vger.kernel.org, Alexei Starovoitov , Andy Shevchenko , Baoquan He , Borislav Petkov , Catalin Marinas , Dave Young , Evan Green , Hsin-Yi Wang , Ingo Molnar , Jessica Yu , Jiri Olsa , kexec@lists.infradead.org, Konstantin Khlebnikov , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, Matthew Wilcox , Rasmus Villemoes , Sasha Levin , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , Vivek Goyal , Will Deacon , x86@kernel.org, Christoph Hellwig , peter enderborg Subject: Re: [PATCH v6 00/13] Add build ID to stacktraces Message-ID: References: <20210511003845.2429846-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210511003845.2429846-1-swboyd@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_044809_346332_03D63A9D X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 2021-05-10 17:38:32, Stephen Boyd wrote: > This series adds the kernel's build ID[1] to the stacktrace header > printed in oops messages, warnings, etc. and the build ID for any module > that appears in the stacktrace after the module name. The goal is to > make the stacktrace more self-contained and descriptive by including the > relevant build IDs in the kernel logs when something goes wrong. This > can be used by post processing tools like script/decode_stacktrace.sh > and kernel developers to easily locate the debug info associated with a > kernel crash and line up what line and file things started falling apart > at. The entire series looks good to me. I reviewed carefully only the 5th patch touching printk/kallsyms/module code. I just scanned over the other patches touching kernel code and did not notice any obvious problem. I did not check the changes in decode_stacktrace.sh at all. I tried to get stacktraces on x86_64 and it worked as expected. Best Regards, Petr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Tue, 11 May 2021 13:48:06 +0200 From: Petr Mladek Subject: Re: [PATCH v6 00/13] Add build ID to stacktraces Message-ID: References: <20210511003845.2429846-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210511003845.2429846-1-swboyd@chromium.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Stephen Boyd Cc: Andrew Morton , linux-kernel@vger.kernel.org, Alexei Starovoitov , Andy Shevchenko , Baoquan He , Borislav Petkov , Catalin Marinas , Dave Young , Evan Green , Hsin-Yi Wang , Ingo Molnar , Jessica Yu , Jiri Olsa , kexec@lists.infradead.org, Konstantin Khlebnikov , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, Matthew Wilcox , Rasmus Villemoes , Sasha Levin , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , Vivek Goyal , Will Deacon , x86@kernel.org, Christoph Hellwig , peter enderborg On Mon 2021-05-10 17:38:32, Stephen Boyd wrote: > This series adds the kernel's build ID[1] to the stacktrace header > printed in oops messages, warnings, etc. and the build ID for any module > that appears in the stacktrace after the module name. The goal is to > make the stacktrace more self-contained and descriptive by including the > relevant build IDs in the kernel logs when something goes wrong. This > can be used by post processing tools like script/decode_stacktrace.sh > and kernel developers to easily locate the debug info associated with a > kernel crash and line up what line and file things started falling apart > at. The entire series looks good to me. I reviewed carefully only the 5th patch touching printk/kallsyms/module code. I just scanned over the other patches touching kernel code and did not notice any obvious problem. I did not check the changes in decode_stacktrace.sh at all. I tried to get stacktraces on x86_64 and it worked as expected. Best Regards, Petr _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec