From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ECC5C433B4 for ; Tue, 11 May 2021 14:09:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8B8D6187E for ; Tue, 11 May 2021 14:08:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8B8D6187E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgT4E-0000xS-LI for qemu-devel@archiver.kernel.org; Tue, 11 May 2021 10:08:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgT0D-0002rC-LZ for qemu-devel@nongnu.org; Tue, 11 May 2021 10:04:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgT0B-0006b4-FR for qemu-devel@nongnu.org; Tue, 11 May 2021 10:04:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620741886; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nNSsYqTp28tvWPaJuGUgjMIi3KK8o860C8MgGkXCeSU=; b=OpdIpDmY9MnATW26I0kXlP2PMVFgi67xSsK6sovi9g6jiu+KiC41n3fwSw5jJ2JzBjEj2V 8iyiAHQw1xNEI1/FHFub5ZkD9p4trCa1roNozb/pEtVn4QwIpWy+FLyrtKrMzFNMoQd7X5 U0gUDBxs8vu4y0QKTGZJC1aZm1okIes= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-252-wpfFvh2EMNaM5PDuRZ6_QQ-1; Tue, 11 May 2021 10:04:40 -0400 X-MC-Unique: wpfFvh2EMNaM5PDuRZ6_QQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 00DC5107ACCA; Tue, 11 May 2021 14:04:39 +0000 (UTC) Received: from redhat.com (ovpn-115-93.ams2.redhat.com [10.36.115.93]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2314619C44; Tue, 11 May 2021 14:04:30 +0000 (UTC) Date: Tue, 11 May 2021 15:04:27 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Subject: Re: [PATCH 01/12] gitlab: move linux user build job from CentOS 7 to CentOS 8 Message-ID: References: <20210511132641.1022161-1-berrange@redhat.com> <20210511132641.1022161-2-berrange@redhat.com> <4f6620fd-bfed-7c35-4711-79d1625f9c7c@redhat.com> MIME-Version: 1.0 In-Reply-To: <4f6620fd-bfed-7c35-4711-79d1625f9c7c@redhat.com> User-Agent: Mutt/2.0.6 (2021-03-06) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Stefan Weil , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Willian Rampazzo , Alex =?utf-8?Q?Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, May 11, 2021 at 03:54:26PM +0200, Thomas Huth wrote: > On 11/05/2021 15.26, Daniel P. Berrangé wrote: > > It has been over two years since RHEL-8 was released, and thus per the > > platform build policy, we no longer need to support RHEL-7 as a build > > target. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > .gitlab-ci.yml | 6 +++--- > > tests/docker/dockerfiles/centos8.docker | 1 + > > 2 files changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > index dcb6317aac..23917d6d73 100644 > > --- a/.gitlab-ci.yml > > +++ b/.gitlab-ci.yml > > @@ -441,12 +441,12 @@ build-user-plugins: > > MAKE_CHECK_ARGS: check-tcg > > timeout: 1h 30m > > -build-user-centos7: > > +build-user-centos8: > > <<: *native_build_job_definition > > needs: > > - job: amd64-centos7-container > > + job: amd64-centos8-container > > variables: > > - IMAGE: centos7 > > + IMAGE: centos8 > > We urgently should decrease our huge amount of jobs ... What about removing > this job completely? We already have the "build-user" job that tests the > compilation on Debian, which is likely at a similar library level as > centos8, so I doubt that we get much additional test coverage from this job > here when it's running on Centos 8. This job was added by Philippe just a couple of months ago commit 4e41d4a34e4d9f11a99a03c2279f84e98df21984 Author: Philippe Mathieu-Daudé Date: Thu Jan 21 18:28:29 2021 +0100 gitlab-ci: Test building linux-user targets on CentOS 7 Add a configuration tested by Peter Maydell (see [1] and [2]) but not covered in our CI [3]: [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o ../linux-user/strace.c: In function 'do_print_sockopt': ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function) case IPV6_ADDR_PREFERENCES: ^ This job currently takes 31 minutes 32 seconds ([4]). [1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05086.html [2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05379.html [3] https://gitlab.com/philmd/qemu/-/jobs/977408284 [4] https://gitlab.com/philmd/qemu/-/jobs/978223286 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20210121172829.1643620-3-f4bug@amsat.org> Signed-off-by: Thomas Huth I looked at the quoted thread, but I can't tell what the actual missing scenario was that motivated this. The threads don't appear to specifically mention CentOS 7, but if the issue was indeed specific to CentOS 7 we can certainly drop the job. If it was some other scenario, I defer the answer to someone who knows.... Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|