From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995C3C433ED for ; Tue, 11 May 2021 14:22:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A00561152 for ; Tue, 11 May 2021 14:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231820AbhEKOXI (ORCPT ); Tue, 11 May 2021 10:23:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:36234 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231154AbhEKOXH (ORCPT ); Tue, 11 May 2021 10:23:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1620742919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=45i14jgdilkL4c57omliQFKc/dMVSrDzuFT1ipWFf8M=; b=nePkdhpO47MaoTKB9P1sGYbCGxxIKDlBZDpre7MdnhCkKh+rpbX9XqDNiV9WACT/ogMQcK B1qI9Qhbokav6j3HT+Gb1NYLnw63gOnl7y52YpzKp3A/LvbBONIa9Zval7qh4L6KmjmgGo ijgmbxV7l3Ar/kDGcReiLeT/3zh7Exw= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 889F8B11D; Tue, 11 May 2021 14:21:59 +0000 (UTC) Date: Tue, 11 May 2021 16:21:59 +0200 From: Petr Mladek To: David Laight Cc: 'Steven Rostedt' , 'Stephen Boyd' , Andrew Morton , "linux-kernel@vger.kernel.org" , Alexei Starovoitov , Andy Shevchenko , Baoquan He , Borislav Petkov , Catalin Marinas , Dave Young , Evan Green , Hsin-Yi Wang , Ingo Molnar , Jessica Yu , Jiri Olsa , "kexec@lists.infradead.org" , Konstantin Khlebnikov , "linux-arm-kernel@lists.infradead.org" , "linux-doc@vger.kernel.org" , Matthew Wilcox , Rasmus Villemoes , Sasha Levin , Sergey Senozhatsky , Thomas Gleixner , Vivek Goyal , Will Deacon , "x86@kernel.org" , Christoph Hellwig , peter enderborg Subject: Re: [PATCH v6 00/13] Add build ID to stacktraces Message-ID: References: <20210511003845.2429846-1-swboyd@chromium.org> <20210511085235.09bc38a7@gandalf.local.home> <37ca7834a8514a5695ed002e073a83b6@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37ca7834a8514a5695ed002e073a83b6@AcuMS.aculab.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2021-05-11 12:58:47, David Laight wrote: > From: Steven Rostedt > > Sent: 11 May 2021 13:53 > > > > On Tue, 11 May 2021 12:36:06 +0000 > > David Laight wrote: > > > > > > x1 : ffffff93fef15788 x0 : ffffffe3622352e0 > > > > Call trace: > > > > lkdtm_WARNING+0x28/0x30 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] > > > > direct_entry+0x16c/0x1b4 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] > > > > full_proxy_write+0x74/0xa4 > > > > > > Is there any way to get it to print each module ID only once? > > > > If there's a trivial way to do that, then perhaps it should be done, but for > > now, this patch series isn't as obnoxious as the previous versions. It only > > affects stack traces, and I'm fine with that. > > True. Printing the id in the module list was horrid. > > The real downside is all the extra text that will overflow the > in-kernel buffer. > At least it shouldn't be extra lines causing screen wrap. > Unless the variable names are long - hi rust :-) Note that the ID is printed only when CONFIG_STACKTRACE_BUILD_ID is enabled. It will be used only by some distros/vendors that use it to download the debuginfo packages. Best Regards, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40C5C43461 for ; Tue, 11 May 2021 14:23:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 148BD6187E for ; Tue, 11 May 2021 14:23:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 148BD6187E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5MoaC2e2G5JunQpUev4fqRpAbNaVc5LGoe7rXbIWYdk=; b=aa4hbIlVQgDp27vXZDOT5WhZo 8T1rqBCL/5CqX8Rz6WuYehT66FGsNjoqlclzCY8t2aFFlZi1A6TfWvm8hRArhEnbKrSUyexY6suZf /6DXummFKt9fNMN4idnL4Z6lrbqS5dJwTwH6akHOk9Jx1+IM6uRnqVQIGiUTQFkvjagnwF77s1y+N LY/linUGjJNzao3lDU6GVk46zqvS3b9C7hltQxEOY1LnEPaWkaJi58bL/cSd3enp0mwdn1cEWR7v1 OIGDk5YM9VyB0ex0wn6PxBIOYlNC8CgB1k4nqZGN/aCSbNbTfiP/RraRkU8MaiL1bmAHypIwgbdHP tcDk5DJ2Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgTH7-000O4Q-Gs; Tue, 11 May 2021 14:22:17 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgTGx-000O1r-Rt; Tue, 11 May 2021 14:22:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=45i14jgdilkL4c57omliQFKc/dMVSrDzuFT1ipWFf8M=; b=CSTIJZiXSbzf1GVs65n7javC6W 1F12SRh/I1IFLrNayZnU1/AH7Sl7yWcwxb3w/g6y0NIQUwvp+bDf8Ji5V3yhmbvogXCcRMWbn2ARa N7mJTDi7FM90jTcbFvJIRLT0RCbPjzIQgBeVET4OhYNOI/yX4K5MnGwzDkyEE2FQlYYLjlHfYtm8O rwpmx/kFMZzTTyZTlUJHSyQCmQJMYoUB9XCRBgVpZJhiiEPFwjZZ7opuXLD3y8fcJ6zmfgO1jdISA HveuA693LaovAcsELIW4bS7dl5bHsnM/kcSZFD1aYNnXMc7muHXdTk2Nkb7hPH8Wl6GcVtzNZTH4g ElqHi/9w==; Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgTGu-009fEE-Oa; Tue, 11 May 2021 14:22:06 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1620742919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=45i14jgdilkL4c57omliQFKc/dMVSrDzuFT1ipWFf8M=; b=nePkdhpO47MaoTKB9P1sGYbCGxxIKDlBZDpre7MdnhCkKh+rpbX9XqDNiV9WACT/ogMQcK B1qI9Qhbokav6j3HT+Gb1NYLnw63gOnl7y52YpzKp3A/LvbBONIa9Zval7qh4L6KmjmgGo ijgmbxV7l3Ar/kDGcReiLeT/3zh7Exw= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 889F8B11D; Tue, 11 May 2021 14:21:59 +0000 (UTC) Date: Tue, 11 May 2021 16:21:59 +0200 From: Petr Mladek To: David Laight Cc: 'Steven Rostedt' , 'Stephen Boyd' , Andrew Morton , "linux-kernel@vger.kernel.org" , Alexei Starovoitov , Andy Shevchenko , Baoquan He , Borislav Petkov , Catalin Marinas , Dave Young , Evan Green , Hsin-Yi Wang , Ingo Molnar , Jessica Yu , Jiri Olsa , "kexec@lists.infradead.org" , Konstantin Khlebnikov , "linux-arm-kernel@lists.infradead.org" , "linux-doc@vger.kernel.org" , Matthew Wilcox , Rasmus Villemoes , Sasha Levin , Sergey Senozhatsky , Thomas Gleixner , Vivek Goyal , Will Deacon , "x86@kernel.org" , Christoph Hellwig , peter enderborg Subject: Re: [PATCH v6 00/13] Add build ID to stacktraces Message-ID: References: <20210511003845.2429846-1-swboyd@chromium.org> <20210511085235.09bc38a7@gandalf.local.home> <37ca7834a8514a5695ed002e073a83b6@AcuMS.aculab.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <37ca7834a8514a5695ed002e073a83b6@AcuMS.aculab.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_072204_955038_7211BB74 X-CRM114-Status: GOOD ( 19.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 2021-05-11 12:58:47, David Laight wrote: > From: Steven Rostedt > > Sent: 11 May 2021 13:53 > > > > On Tue, 11 May 2021 12:36:06 +0000 > > David Laight wrote: > > > > > > x1 : ffffff93fef15788 x0 : ffffffe3622352e0 > > > > Call trace: > > > > lkdtm_WARNING+0x28/0x30 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] > > > > direct_entry+0x16c/0x1b4 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] > > > > full_proxy_write+0x74/0xa4 > > > > > > Is there any way to get it to print each module ID only once? > > > > If there's a trivial way to do that, then perhaps it should be done, but for > > now, this patch series isn't as obnoxious as the previous versions. It only > > affects stack traces, and I'm fine with that. > > True. Printing the id in the module list was horrid. > > The real downside is all the extra text that will overflow the > in-kernel buffer. > At least it shouldn't be extra lines causing screen wrap. > Unless the variable names are long - hi rust :-) Note that the ID is printed only when CONFIG_STACKTRACE_BUILD_ID is enabled. It will be used only by some distros/vendors that use it to download the debuginfo packages. Best Regards, Petr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Tue, 11 May 2021 16:21:59 +0200 From: Petr Mladek Subject: Re: [PATCH v6 00/13] Add build ID to stacktraces Message-ID: References: <20210511003845.2429846-1-swboyd@chromium.org> <20210511085235.09bc38a7@gandalf.local.home> <37ca7834a8514a5695ed002e073a83b6@AcuMS.aculab.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <37ca7834a8514a5695ed002e073a83b6@AcuMS.aculab.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: David Laight Cc: 'Steven Rostedt' , 'Stephen Boyd' , Andrew Morton , "linux-kernel@vger.kernel.org" , Alexei Starovoitov , Andy Shevchenko , Baoquan He , Borislav Petkov , Catalin Marinas , Dave Young , Evan Green , Hsin-Yi Wang , Ingo Molnar , Jessica Yu , Jiri Olsa , "kexec@lists.infradead.org" , Konstantin Khlebnikov , "linux-arm-kernel@lists.infradead.org" , "linux-doc@vger.kernel.org" , Matthew Wilcox , Rasmus Villemoes , Sasha Levin , Sergey Senozhatsky , Thomas Gleixner , Vivek Goyal , Will Deacon , "x86@kernel.org" , Christoph Hellwig , peter enderborg On Tue 2021-05-11 12:58:47, David Laight wrote: > From: Steven Rostedt > > Sent: 11 May 2021 13:53 > > > > On Tue, 11 May 2021 12:36:06 +0000 > > David Laight wrote: > > > > > > x1 : ffffff93fef15788 x0 : ffffffe3622352e0 > > > > Call trace: > > > > lkdtm_WARNING+0x28/0x30 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] > > > > direct_entry+0x16c/0x1b4 [lkdtm ed5019fdf5e53be37cb1ba7899292d7e143b259e] > > > > full_proxy_write+0x74/0xa4 > > > > > > Is there any way to get it to print each module ID only once? > > > > If there's a trivial way to do that, then perhaps it should be done, but for > > now, this patch series isn't as obnoxious as the previous versions. It only > > affects stack traces, and I'm fine with that. > > True. Printing the id in the module list was horrid. > > The real downside is all the extra text that will overflow the > in-kernel buffer. > At least it shouldn't be extra lines causing screen wrap. > Unless the variable names are long - hi rust :-) Note that the ID is printed only when CONFIG_STACKTRACE_BUILD_ID is enabled. It will be used only by some distros/vendors that use it to download the debuginfo packages. Best Regards, Petr _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec