From: Gregory Anders <greg@gpanders.com>
To: Jeff King <peff@peff.net>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v5] git-send-email: use ! to indicate relative path to command
Date: Tue, 11 May 2021 18:45:58 -0600 [thread overview]
Message-ID: <YJslRhzOmSwD7V2E@gpanders.com> (raw)
In-Reply-To: <YJsi1jbtNFDRKXmq@coredump.intra.peff.net>
On Tue, 11 May 2021 20:35 -0400, Jeff King wrote:
>On Wed, May 12, 2021 at 12:00:51AM +0000, brian m. carlson wrote:
>
>> > + specify a sendmail-like program instead, either by a full
>> > + path-name or by prefixing the program name with `!`. The
>> > + program must support the `-i` option. Default value can be
>> > + specified by the `sendemail.smtpServer` configuration option;
>> > + the built-in default is to search for `sendmail` in `/usr/sbin`,
>> > + `/usr/lib` and $PATH if such program is available, falling back
>> > + to `localhost` otherwise.
>>
>> Elsewhere we use the ! syntax we invoke the shell, and I would suggest
>> that we do the same here. That means we'll get PATH functionality by
>> default and we'll let people do a modicum of scripting if they like.
>
>Thanks for bringing that up. I agree it makes things more consistent
>with other uses of "!", and certainly it's more flexible. It does
>introduce an inconsistency with the absolute-path form, as I mentioned
>in https://lore.kernel.org/git/YJsiKDNbKclFU00b@coredump.intra.peff.net/.
>
>I don't know if that's a show-stopper or not. Certainly the
>documentation can explain the difference, but it's nice to keep the
>rules as simple as possible.
>
>(My gut feeling is that consistency with other "!" places is more
>important than consistency with the absolute-path form).
>
>-Peff
We already have sendemail.smtpServerOption to add options:
[sendemail]
smtpServer = !msmtp
smtpServerOption = -f
smtpServerOption = greg@gpanders.com
I agree that it's not the prettiest and it's a little annoying to have
to specify the option multiple times, but I thought it worth mentioning
before considering another way to do the same thing.
I also am curious what other's thoughts are on Felipe's suggestion to
add a sendemail.program option, which would altogether remove the need
to further overload sendemail.smtpServer:
https://lore.kernel.org/git/609b0017a323b_6064920888@natae.notmuch/
IMO if we want to add the capability to run an arbitrary shell command
as the smtpServer, this makes more sense to add as a dedicated
sendemail.program option that has that functionality baked right in:
[sendemail]
program = "msmtp -f greg@gpanders.com"
next prev parent reply other threads:[~2021-05-12 0:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 19:15 [PATCH v3] git-send-email: use ! to indicate relative path to command Gregory Anders
2021-05-11 19:24 ` Jeff King
2021-05-11 20:40 ` [PATCH v4] " Gregory Anders
2021-05-11 21:39 ` Jeff King
2021-05-11 22:18 ` Gregory Anders
2021-05-11 23:09 ` Junio C Hamano
2021-05-11 23:49 ` [PATCH v5] " Gregory Anders
2021-05-12 0:00 ` brian m. carlson
2021-05-12 0:35 ` Jeff King
2021-05-12 0:45 ` Gregory Anders [this message]
2021-05-12 0:49 ` Jeff King
2021-05-12 3:29 ` Junio C Hamano
2021-05-12 0:51 ` brian m. carlson
2021-05-11 20:03 ` [PATCH v3] " Felipe Contreras
2021-05-11 20:42 ` Gregory Anders
2021-05-11 22:07 ` Felipe Contreras
2021-05-11 22:19 ` Gregory Anders
2021-05-12 0:47 ` Jeff King
2021-05-12 1:08 ` Felipe Contreras
2021-05-12 1:24 ` Jeff King
2021-05-12 1:52 ` Felipe Contreras
2021-05-12 1:58 ` Gregory Anders
2021-05-12 4:17 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJslRhzOmSwD7V2E@gpanders.com \
--to=greg@gpanders.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.