From: Jarkko Sakkinen <jarkko@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgg@ziepe.ca>,
Thirupathaiah Annapureddy <thiruan@microsoft.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours
Date: Thu, 20 May 2021 19:43:17 +0300 [thread overview]
Message-ID: <YKaRpdpxTVr8Igm1@kernel.org> (raw)
In-Reply-To: <20210520121347.3467794-9-lee.jones@linaro.org>
On Thu, May 20, 2021 at 01:13:39PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Function parameter or member 'dev' not described in 'ftpm_tee_probe'
> drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Excess function parameter 'pdev' description in 'ftpm_tee_probe'
> drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Function parameter or member 'dev' not described in 'ftpm_tee_remove'
> drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Excess function parameter 'pdev' description in 'ftpm_tee_remove'
> drivers/char/tpm/tpm_ftpm_tee.c:349: warning: expecting prototype for ftpm_tee_shutdown(). Prototype was for ftpm_plat_tee_shutdown() instead
>
> Cc: Peter Huewe <peterhuewe@gmx.de>
> Cc: Jarkko Sakkinen <jarkko@kernel.org>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Thirupathaiah Annapureddy <thiruan@microsoft.com>
> Cc: linux-integrity@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
/Jarkko
> ---
> drivers/char/tpm/tpm_ftpm_tee.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> index 2ccdf8ac69948..2d9c0ecd43f0a 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.c
> +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> @@ -209,7 +209,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data)
>
> /**
> * ftpm_tee_probe() - initialize the fTPM
> - * @pdev: the platform_device description.
> + * @dev: the platform_device description.
> *
> * Return:
> * On success, 0. On failure, -errno.
> @@ -305,7 +305,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev)
>
> /**
> * ftpm_tee_remove() - remove the TPM device
> - * @pdev: the platform_device description.
> + * @dev: the platform_device description.
> *
> * Return:
> * 0 always.
> @@ -342,7 +342,7 @@ static int ftpm_plat_tee_remove(struct platform_device *pdev)
> }
>
> /**
> - * ftpm_tee_shutdown() - shutdown the TPM device
> + * ftpm_plat_tee_shutdown() - shutdown the TPM device
> * @pdev: the platform_device description.
> */
> static void ftpm_plat_tee_shutdown(struct platform_device *pdev)
> --
> 2.31.1
>
>
next prev parent reply other threads:[~2021-05-20 16:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 12:13 [PATCH 00/16] Rid W=1 warnings from Char Lee Jones
2021-05-20 12:13 ` Lee Jones
2021-05-20 12:13 ` [PATCH 01/16] char: pcmcia: cm4000_cs: Remove unused variable 'tmp' Lee Jones
2021-05-20 12:13 ` [PATCH 02/16] char: pcmcia: cm4040_cs: Remove unused variable 'uc' Lee Jones
2021-05-20 12:13 ` [PATCH 03/16] char: random: Include header containing our prototypes Lee Jones
2021-05-20 12:13 ` [PATCH 04/16] char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues Lee Jones
2021-05-20 12:13 ` [PATCH 05/16] " Lee Jones
2021-05-21 8:09 ` Greg Kroah-Hartman
2021-05-21 8:17 ` Lee Jones
2021-05-20 12:13 ` [PATCH 06/16] char: applicom: Remove 3 unused variables 'ret' and 2 instances of 'byte_reset_it' Lee Jones
2021-05-20 12:27 ` Arnd Bergmann
2021-05-20 12:13 ` [PATCH 07/16] char: tpm: tpm1-cmd: Fix a couple of misnamed functions Lee Jones
2021-05-20 16:41 ` Jarkko Sakkinen
2021-05-20 12:13 ` [PATCH 08/16] char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours Lee Jones
2021-05-20 16:43 ` Jarkko Sakkinen [this message]
2021-05-20 12:13 ` [PATCH 09/16] char: agp: backend: Demote some non-conformant kernel-doc headers Lee Jones
2021-06-17 9:52 ` Lee Jones
2021-05-20 12:13 ` [PATCH 10/16] char: agp: frontend: Include header file containing our prototypes Lee Jones
2021-05-20 12:13 ` [PATCH 11/16] char: agp: via-agp: Remove unused variable 'current_size' Lee Jones
2021-05-20 12:13 ` [PATCH 12/16] char: hpet: Remove unused variable 'm' Lee Jones
2021-05-20 12:13 ` [PATCH 13/16] char: agp: generic: Place braces around optimised out function in if() Lee Jones
2021-05-20 12:13 ` [PATCH 14/16] char: agp: uninorth-agp: Remove unused variable 'size' Lee Jones
2021-05-20 12:13 ` [PATCH 15/16] char: hw_random: pseries-rng: Demote non-conformant kernel-doc header Lee Jones
2021-05-20 12:13 ` Lee Jones
2021-05-20 12:13 ` [PATCH 16/16] char: mem: Provide local prototype for non-static function Lee Jones
2021-05-20 12:32 ` Arnd Bergmann
2021-05-20 12:56 ` [PATCH 00/16] Rid W=1 warnings from Char Arnd Bergmann
2021-05-20 12:56 ` Arnd Bergmann
2021-05-21 7:22 ` Lee Jones
2021-05-21 7:22 ` Lee Jones
2021-05-21 7:42 ` Greg Kroah-Hartman
2021-05-21 7:42 ` Greg Kroah-Hartman
2021-05-21 7:44 ` Greg Kroah-Hartman
2021-05-21 7:44 ` Greg Kroah-Hartman
2021-05-21 7:56 ` Lee Jones
2021-05-21 7:56 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKaRpdpxTVr8Igm1@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=lee.jones@linaro.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=thiruan@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.