From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] syscalls/sendfile: Convert sendfile09 to the new API
Date: Fri, 21 May 2021 13:18:54 +0200 [thread overview]
Message-ID: <YKeXHtPOexQr8Iic@pevik> (raw)
In-Reply-To: <88d2297a-58f1-2ee3-0db4-6686ffbf4de2@huawei.com>
Hi Ziyao,
> > > +++ b/testcases/kernel/syscalls/sendfile/sendfile09.c
> > ...
> > > + * Copyright (c) International Business Machines Corp., 2014
> > Again, missing copyright.
> I wonder if I should add copyright without changing the code logic.
IMHO yes. You significantly changed the code. At least we do that.
...
> > > -static void cleanup(void);
> > > -static void setup(void);
> > > +#ifndef OFF_T
> > > +#define OFF_T off_t
> > > +#endif
> > I wonder where OFF_T comes from and if we can just simply use off_t.
> Not sure about this.
@metan any idea?
It looks like nothing needs it:
https://travis-ci.org/github/pevik/ltp/builds/771843061
> > > + for (int i = 1; i <= (4 * 1024); ++i) {
> > This will lead to error in old compilers:
> > error: 'for' loop initial declarations are only allowed in C99 mode
> > https://travis-ci.org/github/pevik/ltp/jobs/771837120
> > https://travis-ci.org/github/pevik/ltp/jobs/771837126
> > It must be:
> > int i;
> > ...
> > for (i = 1; i <= (4 * 1024); ++i) {
> > Thus probably better to declare fd before as well.
> > int i, fd;
> I'll pay attention next time. Thanks.
np, you obviously not work on legacy distro. Travis CI would tell you, but we
don't expect users to run Travis CI on their LTP fork to catch the failures
before sending it to ML (but of course feel free to set it up).
> Hi, Petr,
> Not sure whether to remove OFF_T, the other modifications worked fine for
> me.
Thanks for info, we sort out OFF_T and I'll push it fixed after the release.
> Thanks for your review.
yw, thanks a lot for your work!
Kind regards,
Petr
> Kind regards,
> Ziyao
next prev parent reply other threads:[~2021-05-21 11:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 8:46 [LTP] [PATCH 0/2] syscalls/sendfile: Convert sendfile{08, 09} to the new API Xie Ziyao
2021-05-19 8:46 ` [LTP] [PATCH 1/2] syscalls/sendfile: Convert sendfile08 " Xie Ziyao
2021-05-19 9:18 ` Cyril Hrubis
2021-05-20 21:28 ` Petr Vorel
2021-05-21 3:29 ` Xie Ziyao
2021-05-21 6:48 ` Petr Vorel
2021-05-19 8:46 ` [LTP] [PATCH 2/2] syscalls/sendfile: Convert sendfile09 " Xie Ziyao
2021-05-19 9:37 ` Cyril Hrubis
2021-05-20 11:10 ` Xie Ziyao
2021-05-20 10:49 ` Cyril Hrubis
2021-05-25 15:17 ` Petr Vorel
2021-05-20 21:56 ` Petr Vorel
2021-05-21 9:20 ` Xie Ziyao
2021-05-21 11:18 ` Petr Vorel [this message]
2021-05-25 15:13 ` Petr Vorel
2021-05-26 3:23 ` Xie Ziyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKeXHtPOexQr8Iic@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.