From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D63C04FF3 for ; Fri, 21 May 2021 22:37:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72D51613D8 for ; Fri, 21 May 2021 22:37:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230096AbhEUWjE (ORCPT ); Fri, 21 May 2021 18:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230162AbhEUWjC (ORCPT ); Fri, 21 May 2021 18:39:02 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85CF3C06138F for ; Fri, 21 May 2021 15:37:31 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id d16so15939441pfn.12 for ; Fri, 21 May 2021 15:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ccivkmqRxvbEoQM0V9sS14GS9yzetYD2ZYyUao6LYL8=; b=HOGxRJT+S3zcq6hG9tZPy7cA+K51TbarsJRrSVikqTSau6Cy77dyYdOclcQ4KvkpHL 5ki+DoCGpNRtNv4oENFijvD3ZkT/t1aN2qNTMepSrH0L94PGE0RLEjmqtf8E00t3c/86 CDqc01/JsB/YG4kBmyYNC+6VoiJyGqMitHpngLrllV4yPODbvzUlEsqIsK6f0hlR8Tcb C8K/mEhs8pnXSwp444dQA5fcf7dakjkkfbgdlRkymTXroZ2d6+yqAh452WDayssVLPJm nhKApahBosgELZ6FlET1/n1KNxZ2IiCLlx/30dQUtLw8acr4TeNRu03XZcXHHQwKaJ3h 1zFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ccivkmqRxvbEoQM0V9sS14GS9yzetYD2ZYyUao6LYL8=; b=T14bNyeVr+cm4EqRnMw2K/Lw9g+xV5HNQrAg7dXChYkOUWWt2wOlMB1no0c6BUKgG0 2LKTTDVgYV0gXwnpCfDcd9sZBDVHzsAXiz/HTNuT5m2UL8hYbM/4GOzAqeN1XwQLH62K CeCO9pa8lWfeFRTbK5UlpQ8dS0yoSYXaZFxHnaiHoUagwbmAaEfYGcx5/pVIc+/GGze+ 8snKsilBZlyv8ZdWxrIf5K/9NCo2U3MW9FOIiipsdj9hQNsTks+GGwSMyV1fw2FRlLHE outlM6ZM6634jZV+dvZAnZHUW2VkW+nB0X3LhFWEW6cFm0Rc4VSe1llndsCJLUIBiPu5 VF1w== X-Gm-Message-State: AOAM532s7XWk5gRQM/QZUyI+E71xmJlIiW7e1xMXNB7wd5d0q06mTaLD wNxM7r5ZOSPumZaAJi2UyBEOIg== X-Google-Smtp-Source: ABdhPJwzK3VZ3KUvllj7T7UMXQIPumDuGJJFVNI/o3u4lcUKHfVMLwumBcQE4Nn84BsmiwpYUjd3Pw== X-Received: by 2002:a62:3682:0:b029:2dd:ed69:6e85 with SMTP id d124-20020a6236820000b02902dded696e85mr12537608pfa.20.1621636650955; Fri, 21 May 2021 15:37:30 -0700 (PDT) Received: from relinquished.localdomain ([2620:10d:c090:400::5:1e18]) by smtp.gmail.com with ESMTPSA id pg5sm2712122pjb.28.2021.05.21.15.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 15:37:29 -0700 (PDT) Date: Fri, 21 May 2021 15:37:27 -0700 From: Omar Sandoval To: Chaitanya Kulkarni Cc: Johannes Thumshirn , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "target-devel@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "axboe@kernel.dk" , "mb@lightnvm.io" , "martin.petersen@oracle.com" , "clm@fb.com" , "josef@toxicpanda.com" , "dsterba@suse.com" , "ming.lei@redhat.com" , "osandov@fb.com" , "willy@infradead.org" , "jefflexu@linux.alibaba.com" , "hch@lst.de" Subject: Re: [RFC PATCH 0/8] block: fix bio_add_XXX_page() return type Message-ID: References: <20210520062255.4908-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, May 21, 2021 at 09:37:43PM +0000, Chaitanya Kulkarni wrote: > On 5/21/21 03:25, Johannes Thumshirn wrote: > > I couldn't spot any errors, but I'm not sure it's worth the effort. > > > > If Jens decides to take it: > > Reviewed-by: Johannes Thumshirn > > > > It does create confusion on the code level which can result in > invalid error checks. Do you have any examples of bugs caused by this confusion (whether they were fixed in the past, currently exist, or were caught in code review)? That would be good justification for doing this.