From: David Gibson <david@gibson.dropbear.id.au>
To: Fabiano Rosas <farosas@linux.ibm.com>
Cc: richard.henderson@linaro.org, lucas.araujo@eldorado.org.br,
qemu-devel@nongnu.org, luis.pires@eldorado.org.br,
fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org,
matheus.ferst@eldorado.org.br, Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH v2 1/2] target/ppc: fix address translation bug for radix mmus
Date: Tue, 15 Jun 2021 11:18:18 +1000 [thread overview]
Message-ID: <YMf/2vmRcAii2dM2@yekko> (raw)
In-Reply-To: <87r1h4upiq.fsf@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 994 bytes --]
On Mon, Jun 14, 2021 at 06:04:13PM -0300, Fabiano Rosas wrote:
> "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> writes:
>
> > +/*
> > + * These correspond to the mmu_idx values computed in
> > + * hreg_compute_hflags_value. See the tables therein
> > + */
> > +static inline bool mmuidx_pr(int idx) { return !(idx & 1); }
> > +/*
> > + * If we want to use these macros for hash-style MMUs, we need to
> > + * add an if or another macro here.
> > + */
>
> Don't these work just fine for hash as well? Except for Booke.
Right, I think we want to restrict these to BookS mmus, but I don't
think we need to restrict to radix.
>
> > +static inline bool mmuidx_real(int idx) { return idx & 2; }
> > +static inline bool mmuidx_hv(int idx) { return idx & 4; }
> > +
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-15 1:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 19:16 [PATCH v2 1/2] target/ppc: fix address translation bug for radix mmus Bruno Larsen (billionai)
2021-06-14 19:16 ` [RFC PATCH v2 2/2] target/ppc: make gdb able to translate priviledged addresses Bruno Larsen (billionai)
2021-06-14 19:37 ` Philippe Mathieu-Daudé
2021-06-15 1:41 ` David Gibson
2021-06-15 12:12 ` Bruno Piazera Larsen
2021-06-14 21:25 ` Fabiano Rosas
2021-06-15 11:59 ` Bruno Piazera Larsen
2021-06-14 22:37 ` Richard Henderson
2021-06-15 11:32 ` Bruno Piazera Larsen
2021-06-15 20:00 ` Richard Henderson
2021-06-15 21:37 ` Fabiano Rosas
2021-06-16 12:07 ` Bruno Piazera Larsen
2021-06-16 6:18 ` David Gibson
2021-06-14 19:29 ` [PATCH v2 1/2] target/ppc: fix address translation bug for radix mmus Greg Kurz
2021-06-14 21:04 ` Fabiano Rosas
2021-06-15 1:18 ` David Gibson [this message]
2021-06-15 1:41 ` David Gibson
2021-06-15 3:20 ` Richard Henderson
2021-06-15 12:25 ` Bruno Piazera Larsen
2021-06-16 6:16 ` David Gibson
2021-06-15 13:57 ` Cédric Le Goater
2021-06-15 14:14 ` Philippe Mathieu-Daudé
2021-06-15 14:57 ` Bruno Piazera Larsen
2021-06-15 15:57 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMf/2vmRcAii2dM2@yekko \
--to=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=fernando.valle@eldorado.org.br \
--cc=groug@kaod.org \
--cc=lucas.araujo@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.