From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EFB0C48BE8 for ; Tue, 15 Jun 2021 14:10:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1216561480 for ; Tue, 15 Jun 2021 14:10:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231222AbhFOOMV (ORCPT ); Tue, 15 Jun 2021 10:12:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:33440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230450AbhFOOMA (ORCPT ); Tue, 15 Jun 2021 10:12:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 976D06140B; Tue, 15 Jun 2021 14:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623766192; bh=bvj81Bgsko3aki1RHrDsNK91qLZ/GZamekNSHfl2XIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZDHkZeNwAKdMR7sK0vdZLfep7VHmvY21n7IUJ9zZ7rapcn9ECK4Ntgm8P4AqCGMS0 BNTFpLHqqQ+tIXfFmuWIC7s1hCGXnyfkj7WfuTi37mfXGhly5iWPYZs36/YKDSj9/J Jhw3MQjOOIkQuJhRYoW9CQmzyAhJkWqOhM1Bk/uM= Date: Tue, 15 Jun 2021 16:09:50 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Jason Gunthorpe , Alex Williamson , Kirti Wankhede , David Airlie , Tony Krowiak , Christian Borntraeger , Cornelia Huck , Jonathan Corbet , Daniel Vetter , dri-devel@lists.freedesktop.org, Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, Jani Nikula , Jason Herne , Joonas Lahtinen , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Halil Pasic , "Rafael J. Wysocki" , Rodrigo Vivi Subject: Re: [PATCH 02/10] driver core: Better distinguish probe errors in really_probe Message-ID: References: <20210615133519.754763-1-hch@lst.de> <20210615133519.754763-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615133519.754763-3-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jun 15, 2021 at 03:35:11PM +0200, Christoph Hellwig wrote: > really_probe tries to special case errors from ->probe, but due to all > other initialization added to the function over time now a lot of > internal errors hit that code path as well. Untangle that by adding > a new probe_err local variable and apply the special casing only to > that. > > Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F333C48BDF for ; Tue, 15 Jun 2021 14:09:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FF6261477 for ; Tue, 15 Jun 2021 14:09:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FF6261477 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 142626E0ED; Tue, 15 Jun 2021 14:09:53 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6058D6E0ED; Tue, 15 Jun 2021 14:09:52 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 976D06140B; Tue, 15 Jun 2021 14:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623766192; bh=bvj81Bgsko3aki1RHrDsNK91qLZ/GZamekNSHfl2XIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZDHkZeNwAKdMR7sK0vdZLfep7VHmvY21n7IUJ9zZ7rapcn9ECK4Ntgm8P4AqCGMS0 BNTFpLHqqQ+tIXfFmuWIC7s1hCGXnyfkj7WfuTi37mfXGhly5iWPYZs36/YKDSj9/J Jhw3MQjOOIkQuJhRYoW9CQmzyAhJkWqOhM1Bk/uM= Date: Tue, 15 Jun 2021 16:09:50 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Message-ID: References: <20210615133519.754763-1-hch@lst.de> <20210615133519.754763-3-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210615133519.754763-3-hch@lst.de> Subject: Re: [Intel-gfx] [PATCH 02/10] driver core: Better distinguish probe errors in really_probe X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Kirti Wankhede , linux-s390@vger.kernel.org, Jonathan Corbet , "Rafael J. Wysocki" , Halil Pasic , Christian Borntraeger , Jason Gunthorpe , intel-gfx@lists.freedesktop.org, Jason Herne , Vasily Gorbik , Heiko Carstens , Tony Krowiak , Cornelia Huck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Jun 15, 2021 at 03:35:11PM +0200, Christoph Hellwig wrote: > really_probe tries to special case errors from ->probe, but due to all > other initialization added to the function over time now a lot of > internal errors hit that code path as well. Untangle that by adding > a new probe_err local variable and apply the special casing only to > that. > > Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D31CDC48BE5 for ; Tue, 15 Jun 2021 14:09:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A648A61446 for ; Tue, 15 Jun 2021 14:09:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A648A61446 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED67C6E2C7; Tue, 15 Jun 2021 14:09:53 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6058D6E0ED; Tue, 15 Jun 2021 14:09:52 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 976D06140B; Tue, 15 Jun 2021 14:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623766192; bh=bvj81Bgsko3aki1RHrDsNK91qLZ/GZamekNSHfl2XIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZDHkZeNwAKdMR7sK0vdZLfep7VHmvY21n7IUJ9zZ7rapcn9ECK4Ntgm8P4AqCGMS0 BNTFpLHqqQ+tIXfFmuWIC7s1hCGXnyfkj7WfuTi37mfXGhly5iWPYZs36/YKDSj9/J Jhw3MQjOOIkQuJhRYoW9CQmzyAhJkWqOhM1Bk/uM= Date: Tue, 15 Jun 2021 16:09:50 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Subject: Re: [PATCH 02/10] driver core: Better distinguish probe errors in really_probe Message-ID: References: <20210615133519.754763-1-hch@lst.de> <20210615133519.754763-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615133519.754763-3-hch@lst.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Kirti Wankhede , linux-s390@vger.kernel.org, Jonathan Corbet , "Rafael J. Wysocki" , Halil Pasic , Christian Borntraeger , Jason Gunthorpe , intel-gfx@lists.freedesktop.org, Jason Herne , Vasily Gorbik , Heiko Carstens , Alex Williamson , Rodrigo Vivi , Tony Krowiak , Cornelia Huck Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 15, 2021 at 03:35:11PM +0200, Christoph Hellwig wrote: > really_probe tries to special case errors from ->probe, but due to all > other initialization added to the function over time now a lot of > internal errors hit that code path as well. Untangle that by adding > a new probe_err local variable and apply the special casing only to > that. > > Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman