From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6256EC48BDF for ; Tue, 15 Jun 2021 11:51:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5021F60FF0 for ; Tue, 15 Jun 2021 11:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230305AbhFOLx7 (ORCPT ); Tue, 15 Jun 2021 07:53:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230120AbhFOLx4 (ORCPT ); Tue, 15 Jun 2021 07:53:56 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1645C061574 for ; Tue, 15 Jun 2021 04:51:51 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id i94so17954488wri.4 for ; Tue, 15 Jun 2021 04:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ZmDdvySgqdUlY2q8ke4e4ZpA292A0Wud2ttf4plmCMY=; b=pvQaJNNzDKK3GpIZeua9CqXPirqGx6NKgfmbtjihjABYe6IUz2vRqb0WpKkUguR76e 6UP7caynyBTU5ExTVZhi7ewqC6Gp4nHzLp8ZITCkeApr1at1nsDnYYjIKej/na6G4cZh AuHKmHW9raTxyFdOpXLVTZ04/qTomhvqTxe5ywACySanWgwkwT/HShC98HAcWuJGOjL2 XecOcWVIBLcb1EjvG5iM6rOlqEBrLV051S6Ms8P0PPIMx1yBimI7Ce5gNNpOgjtpo+v5 kkInIioMuPnsEcdbrxPvdW98GP/xD+uPxLSeXwL5MGl6OZ8lqBMGG/XGUNsDumS7Ld9x /3yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ZmDdvySgqdUlY2q8ke4e4ZpA292A0Wud2ttf4plmCMY=; b=e9ixIrw2yN/8yI3m3D6tuw4Srl1zGZCUhr/lWR2SwoDAFq9f92EiY+FK94JB/QUO3y ip+t3h0enKZa2euPJVaFQrP8q2qmmSMdwFZbCFj+zhCPzl+68RkO9gY+rMYg4w4FfFWw uOsstVv2zVpsa+VkWgOeLrs64zxViJhC6/mA6xLuX78oeshNxHKWTHC93Gu9dOZNFBQE 80jY5NlcT6F4A9r+1z98Fvh48H9ypBcPYzAHaVEOYgnQ/9rmP4LcODT6hQMry63DIS59 KP339NvQ2i1D9UiuMM1VxNoqhvzuP8OIL1IuuBT0mxKFzTJ3hzGt7Ni68aKiqpY07zIf kvRQ== X-Gm-Message-State: AOAM531Q1uisEFU8DYkD3zno4ToLD9mgtLOJ/+tZ0UkxGbwBM3G1n2oo BdqXqUHTULeM1W1d0RE/CNu0JQ== X-Google-Smtp-Source: ABdhPJymFrFA9Tr+UC2MqlIHxE7AQHRohn0x+RAeDamz4LU63AcE7R4SuOg5nVo4nZoP26ITolt81A== X-Received: by 2002:adf:de91:: with SMTP id w17mr25122541wrl.352.1623757910499; Tue, 15 Jun 2021 04:51:50 -0700 (PDT) Received: from dell ([91.110.221.170]) by smtp.gmail.com with ESMTPSA id u15sm1926281wmq.48.2021.06.15.04.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 04:51:50 -0700 (PDT) Date: Tue, 15 Jun 2021 12:51:48 +0100 From: Lee Jones To: Zhen Lei Cc: patches , linux-arm-kernel , linux-kernel Subject: Re: [PATCH 3/9] mfd: timberdale: use DEVICE_ATTR_RO macro Message-ID: References: <20210602114339.11223-1-thunder.leizhen@huawei.com> <20210602114339.11223-4-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210602114339.11223-4-thunder.leizhen@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 Jun 2021, Zhen Lei wrote: > Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes > the code a bit shorter and easier to read. > > Signed-off-by: Zhen Lei > --- > drivers/mfd/timberdale.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42ABC48BDF for ; Tue, 15 Jun 2021 17:56:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 918F161059 for ; Tue, 15 Jun 2021 17:56:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 918F161059 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4LlBYoh0uTXNousWKb3TdRRkY/fUd1NYwz93e5kRmYo=; b=xLVScNMlnO7sXn dnWFB9jp3iJK9BN4s29cQ+CrBW2CqrgeuEEfB459J5sPeH8W5AEuKGjQ3CCIo9ZcvYp0YjSl3cbNx WuKq/re0++ozij5e+7kO2jdKctLVA9hRE7hg+nzNF3gO6YQAzZWjP55dbYYVbdlbvmouar//2HJLm VB5KkyRP0VynRbpd5gsm45NzXAnU44ZUx3gG6EaCa2Xebj7x4Ws/pfSg6nOdc6M1ULCFC4k7mgKBP ujhJohmfb7BeR4SYaM2w8RhniQv2VI0uPK9DW9b7z65p8Aan37/9a18HZaCiU1GlS2U/oc/0hhVzS 1GFb3JqBv/q/jvoZ+LLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltDH2-001tqI-2T; Tue, 15 Jun 2021 17:54:52 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt9FE-000ByJ-Bq for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Jun 2021 13:36:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=ZmDdvySgqdUlY2q8ke4e4ZpA292A0Wud2ttf4plmCMY=; b=cmyblBy+r8SbgX3gOdLQbuQNa2 bBSuKqxMUy3u4bU4dLp1LjRASlmuiv6uQEXUBGlRf01YQNtDL2qoaFKxz5knaWcLaRffMAvmjf0Q0 v+oo7RwsepGelOemhujWTcWdaZHeUL35vq655TUDBqkXQoxh83AJAIgcZM5Ojn+YOJE4NjvMGpIZO sDz4w0IeWSNYEgu895mf84+SdN3ku2WiuzFlmpNXXhUpmB5T46k3g9RtzRp0mv8Q5MIEC5Kt4X1ZX 9QM/zkG1m1rWrPI1WUyHNKvy7GP7uszP31TJzBWhNR+jfVaXCoGqAN8STsTkIR/VZNo5gWRAvwJmF CaI/Kn+A==; Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt7bc-007ovB-KH for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 11:51:53 +0000 Received: by mail-wr1-x429.google.com with SMTP id f2so17994598wri.11 for ; Tue, 15 Jun 2021 04:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ZmDdvySgqdUlY2q8ke4e4ZpA292A0Wud2ttf4plmCMY=; b=pvQaJNNzDKK3GpIZeua9CqXPirqGx6NKgfmbtjihjABYe6IUz2vRqb0WpKkUguR76e 6UP7caynyBTU5ExTVZhi7ewqC6Gp4nHzLp8ZITCkeApr1at1nsDnYYjIKej/na6G4cZh AuHKmHW9raTxyFdOpXLVTZ04/qTomhvqTxe5ywACySanWgwkwT/HShC98HAcWuJGOjL2 XecOcWVIBLcb1EjvG5iM6rOlqEBrLV051S6Ms8P0PPIMx1yBimI7Ce5gNNpOgjtpo+v5 kkInIioMuPnsEcdbrxPvdW98GP/xD+uPxLSeXwL5MGl6OZ8lqBMGG/XGUNsDumS7Ld9x /3yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ZmDdvySgqdUlY2q8ke4e4ZpA292A0Wud2ttf4plmCMY=; b=fnauQdzR7P4bXOnswdobnGlQDVHj4fLccOmMKCAAXQh/5s7CMuJP/7L7WdPH14Vuf6 In6udvMZWKsDOX0ECvfScaO0Iwpl7tLDlekdp+3ThPvxYEhlpkdINLf0VYfl0309Oxnc Wsw6nXvF+0RfU3QRcc6bWz6kAJCCSWUs0ju+GiGTDbVdfLdiZvNNOxPd6En7yG41NUO3 bGVZLRViTzs01b50WdYrnq389ysLJ++YP4Q/Bkf2sdfLZDLOI9OhW5tQhlRXtchcIZsh O1BLFCHfat/s4qYWsgSAXiPAdi10qbfSk/az7Qo7LAai53K/yew2DfGEpUQf6eR1SC4z nY1Q== X-Gm-Message-State: AOAM5304iWxdc/PKLZXQAiB8ZDJ8uES2AewB5iU9OD6j+6hVMHILsk9a FQgKB5OX0Rnt5nmQxv0rfm10Sw== X-Google-Smtp-Source: ABdhPJymFrFA9Tr+UC2MqlIHxE7AQHRohn0x+RAeDamz4LU63AcE7R4SuOg5nVo4nZoP26ITolt81A== X-Received: by 2002:adf:de91:: with SMTP id w17mr25122541wrl.352.1623757910499; Tue, 15 Jun 2021 04:51:50 -0700 (PDT) Received: from dell ([91.110.221.170]) by smtp.gmail.com with ESMTPSA id u15sm1926281wmq.48.2021.06.15.04.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 04:51:50 -0700 (PDT) Date: Tue, 15 Jun 2021 12:51:48 +0100 From: Lee Jones To: Zhen Lei Cc: patches , linux-arm-kernel , linux-kernel Subject: Re: [PATCH 3/9] mfd: timberdale: use DEVICE_ATTR_RO macro Message-ID: References: <20210602114339.11223-1-thunder.leizhen@huawei.com> <20210602114339.11223-4-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210602114339.11223-4-thunder.leizhen@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_125151_485856_DB57D573 X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAwMiBKdW4gMjAyMSwgWmhlbiBMZWkgd3JvdGU6Cgo+IFVzZSBERVZJQ0VfQVRUUl9S TyBtYWNybyBoZWxwZXIgaW5zdGVhZCBvZiBwbGFpbiBERVZJQ0VfQVRUUiwgd2hpY2ggbWFrZXMK PiB0aGUgY29kZSBhIGJpdCBzaG9ydGVyIGFuZCBlYXNpZXIgdG8gcmVhZC4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBaaGVuIExlaSA8dGh1bmRlci5sZWl6aGVuQGh1YXdlaS5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvbWZkL3RpbWJlcmRhbGUuYyB8IDYgKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpBcHBsaWVkLCB0aGFua3MuCgotLSAKTGVlIEpv bmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNl cwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93 IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=