From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 144CEC48BDF for ; Tue, 15 Jun 2021 12:15:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD0E161461 for ; Tue, 15 Jun 2021 12:15:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230292AbhFOMRb (ORCPT ); Tue, 15 Jun 2021 08:17:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230205AbhFOMR3 (ORCPT ); Tue, 15 Jun 2021 08:17:29 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D562C061574 for ; Tue, 15 Jun 2021 05:15:23 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id f2so18078297wri.11 for ; Tue, 15 Jun 2021 05:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=59bkyyYwA5Alndf1/hcekhkhVORqh2nyBj19xriGPQE=; b=uUFMKUyjVW1PYJkOHDZfWmvX5ib7kFcrGnDjM6xoyFBfRHIZjmYr/06XFIOoQqR8E5 stfsdJHSQMU4Np03ccBzkAdX63SQef+y36cI+ri2hzH8GYJC5owNua1ifNNSPdy0FhQj mDa0opiBAaCj3pB3982JrvTJYTCZxEjnJMH3Gh6KatIHm2I4LbpOiJeaesr8OcwM7qy0 w4Cx70ZVtXOhcoDlFCbDcFvcZ+HL2/2Da7riKLGKlOrD5VlrI/xeBHjaGOQ3CSaXw2QX 9YOyXxmWcv3KwJtGrAHZY1YIVYoFkQZaJmc4MnmtFDO7teAthbNXkXJx8tMXjrav9tmp EzIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=59bkyyYwA5Alndf1/hcekhkhVORqh2nyBj19xriGPQE=; b=a+vpIb8aNRHy3FmuJZ1BwNoiF4edWXWZvMmDoD71lfmSOuRZFj5AZ72iu4A4fqlHfF hE95Cg939vyjNwYna2oUQkAhi8CQqI7QXM2alt11ZRrbdhy1RmFo+aiYhjcvPtYpZeN6 sHp6nYy/owPQR5nofGZQ6uI8fKD3BUjnCvJIWhbTyUmeOB29dSYHEsiPpeaFj4yTtt7Z rzCMXrovc+9HDMycI6xyUU0gtvTYfXgWk3g1Asd66RgdhLazPd9DuNfsXuXStno8fPiM iO1LwY9rfKpFH3YDfXe2pzNg4z08Gv7nyJuH12HWdu99Cqs4/GNiTpQmA1clSAczZxGM nQtQ== X-Gm-Message-State: AOAM530Lc8A5PHpHedKgKS4AHyPTFvei7WQhlA25PecSgNdwVS4IFuIR IXMWBHsog31CBLuJbgKVQGVFVg== X-Google-Smtp-Source: ABdhPJzz5oWcqNCv3FNjMZhWaoj2Syuw2ZcjSPc7eTfwtxyNu3l7ni927ofQfDvGy0cphJTvLqPSDQ== X-Received: by 2002:a5d:6a82:: with SMTP id s2mr5443378wru.247.1623759322073; Tue, 15 Jun 2021 05:15:22 -0700 (PDT) Received: from dell ([91.110.221.170]) by smtp.gmail.com with ESMTPSA id u15sm1977922wmq.48.2021.06.15.05.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 05:15:21 -0700 (PDT) Date: Tue, 15 Jun 2021 13:15:20 +0100 From: Lee Jones To: Zhen Lei Cc: patches , linux-arm-kernel , linux-kernel Subject: Re: [PATCH 9/9] mfd: ab8500-core: use DEVICE_ATTR_RO/RW macro Message-ID: References: <20210602114339.11223-1-thunder.leizhen@huawei.com> <20210602114339.11223-10-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210602114339.11223-10-thunder.leizhen@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 Jun 2021, Zhen Lei wrote: > Use DEVICE_ATTR_RO/RW macro helper instead of plain DEVICE_ATTR, which > makes the code a bit shorter and easier to read. > > Signed-off-by: Zhen Lei > --- > drivers/mfd/ab8500-core.c | 33 ++++++++++++++++----------------- > 1 file changed, 16 insertions(+), 17 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59C2DC48BE5 for ; Tue, 15 Jun 2021 18:46:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1191B61241 for ; Tue, 15 Jun 2021 18:46:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1191B61241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TpOqse8rRGG6nsZ6q3ZleySINZUp1dtd6jN5xIpDsE0=; b=MhyfTNE/v1B3gZ JGiKududYyQxrsmqbA4TsovsnHjX4C5I1tcCO3/2rk09tlMVf3WmAfWJ77CnYMH5A+xFyx9W90TQ7 tDUhTEhE11D1m5ZbV5HBrVRshGYYIWTG9pYGJuUuXuKcN0e+9BZq3SCSYww9TitUP+W+eatMt9TVO SCxm8NdKJZxEuksTP7lv9RwQ+B21O4YDcTyhb9+8jjZ+u9NXLBZYyzeGhD984QVg0kdS6iJeUcY8N PRhf31gWUTWc0m7G0/rtcIGzGEm5Bl1xYhYt0f0pz/e+hfI/JhVFCMuLaxQOMDSmk2xWdQCZMeDE9 Chs7F1b5cC5BiEzexoNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltE2K-002D0l-FG; Tue, 15 Jun 2021 18:43:45 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt9E8-000ByJ-FL for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Jun 2021 13:35:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=59bkyyYwA5Alndf1/hcekhkhVORqh2nyBj19xriGPQE=; b=neaShcFoD9D8+Zb9g53IA3xAav tFf6Yhkvx6DLaBh3eY0CAuovjeNztBPtKDNi6U513uJcmXn6OtgF7E2yJrfFAXzi+CSX1NWNPsayn nc/1xqVIb4i6erDPIiuNG1T5aNckUUuZQ+h6Q5eLcAbZu/YYQvnoTIE8at0AL/vIXWkfJwPt4AaQD Wlnt5LGVO1XoiyLtM8ylWA/rKpnlv4Sn/9FyUxGG1KA6IiKVSLY0Te6dJK0uBc/Rq1OpfzN5yiguV AXUxJk3+m8lw/hUKa9R/iUpmsPnq3z9iUsFiTTdoXuUzhzZyOXf+f+yjqXTcuYlk+PcuMfYSgkY2v iE4FfNwA==; Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt7yO-007q80-41 for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 12:15:24 +0000 Received: by mail-wr1-x429.google.com with SMTP id a11so18067096wrt.13 for ; Tue, 15 Jun 2021 05:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=59bkyyYwA5Alndf1/hcekhkhVORqh2nyBj19xriGPQE=; b=uUFMKUyjVW1PYJkOHDZfWmvX5ib7kFcrGnDjM6xoyFBfRHIZjmYr/06XFIOoQqR8E5 stfsdJHSQMU4Np03ccBzkAdX63SQef+y36cI+ri2hzH8GYJC5owNua1ifNNSPdy0FhQj mDa0opiBAaCj3pB3982JrvTJYTCZxEjnJMH3Gh6KatIHm2I4LbpOiJeaesr8OcwM7qy0 w4Cx70ZVtXOhcoDlFCbDcFvcZ+HL2/2Da7riKLGKlOrD5VlrI/xeBHjaGOQ3CSaXw2QX 9YOyXxmWcv3KwJtGrAHZY1YIVYoFkQZaJmc4MnmtFDO7teAthbNXkXJx8tMXjrav9tmp EzIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=59bkyyYwA5Alndf1/hcekhkhVORqh2nyBj19xriGPQE=; b=dahzHgW/G3fswA4EBdt7WL5T9XnuYn6GKOkTkBDE1D8RpbmLsIScBTMoH50jNV+PwY 8zrpl5vyVla5h0LAk/3A6nIgBBdM2yMIfFKphYQ456ZtreN4rque7ZW/bLTPiCpUJkK8 G21zmKKkGDRUXDvphIoG1cvbqdo1a22pAKVmxWRTuHGkrqloWN9qSGHgQQNP8yfim7NL Ckx6lC/Ewj00vvO+gohyiK4mmKLI7XREfDA49usJa43GjJI1FYS4ZNmkskfuslfg5cdx 4xXaDU43PDESfdNyRmihgstJwJfsJP+nVLUMKA/b8PG/QAzY4R8DZyc6safS8cUMJ59p K+dw== X-Gm-Message-State: AOAM532Y351e9ihuymuEvVVmgi2k1Wx4zyCTmqwTt3H3lp1/GeHO9GO3 YAK6USwzCSlljiVkVQFFJDgjNg== X-Google-Smtp-Source: ABdhPJzz5oWcqNCv3FNjMZhWaoj2Syuw2ZcjSPc7eTfwtxyNu3l7ni927ofQfDvGy0cphJTvLqPSDQ== X-Received: by 2002:a5d:6a82:: with SMTP id s2mr5443378wru.247.1623759322073; Tue, 15 Jun 2021 05:15:22 -0700 (PDT) Received: from dell ([91.110.221.170]) by smtp.gmail.com with ESMTPSA id u15sm1977922wmq.48.2021.06.15.05.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 05:15:21 -0700 (PDT) Date: Tue, 15 Jun 2021 13:15:20 +0100 From: Lee Jones To: Zhen Lei Cc: patches , linux-arm-kernel , linux-kernel Subject: Re: [PATCH 9/9] mfd: ab8500-core: use DEVICE_ATTR_RO/RW macro Message-ID: References: <20210602114339.11223-1-thunder.leizhen@huawei.com> <20210602114339.11223-10-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210602114339.11223-10-thunder.leizhen@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_131523_117354_B9F0B85A X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAwMiBKdW4gMjAyMSwgWmhlbiBMZWkgd3JvdGU6Cgo+IFVzZSBERVZJQ0VfQVRUUl9S Ty9SVyBtYWNybyBoZWxwZXIgaW5zdGVhZCBvZiBwbGFpbiBERVZJQ0VfQVRUUiwgd2hpY2gKPiBt YWtlcyB0aGUgY29kZSBhIGJpdCBzaG9ydGVyIGFuZCBlYXNpZXIgdG8gcmVhZC4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBaaGVuIExlaSA8dGh1bmRlci5sZWl6aGVuQGh1YXdlaS5jb20+Cj4gLS0tCj4g IGRyaXZlcnMvbWZkL2FiODUwMC1jb3JlLmMgfCAzMyArKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9u cygtKQoKQXBwbGllZCwgdGhhbmtzLgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpTZW5pb3Ig VGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBz b3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdp dHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK