From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E4C1C48BE6 for ; Wed, 16 Jun 2021 06:53:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B300D61164 for ; Wed, 16 Jun 2021 06:53:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B300D61164 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltPQ3-0004bw-TJ for qemu-devel@archiver.kernel.org; Wed, 16 Jun 2021 02:52:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltPHK-0004cz-ID; Wed, 16 Jun 2021 02:43:58 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:52159) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltPHI-0004MH-1I; Wed, 16 Jun 2021 02:43:58 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4G4bHm3lDMz9sXG; Wed, 16 Jun 2021 16:43:48 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1623825828; bh=wwyfql3qEzdf0SzEbZ+kKqzYJt51XbBehHrP6eArYpQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XWGdHSrEibuIOvT0KkZxnDEMqve4Nc5R3XH0yGSsIESlz2kru/5bi57TszIh2BQyG 6SLACn99FNauVTO/oM7Q2TlPwWlNEdjow08WzyWzKjTLY5y9p25hzMdJs54NA4CkS4 u/Ekpzlf2Puemt+EkVjRWU+Riyki/HxQkq2RFlPQ= Date: Wed, 16 Jun 2021 16:16:45 +1000 From: David Gibson To: Bruno Piazera Larsen Subject: Re: [PATCH v2 1/2] target/ppc: fix address translation bug for radix mmus Message-ID: References: <20210614191630.101304-1-bruno.larsen@eldorado.org.br> <61359cca-19fc-8f2f-0cf6-ee520fc356c2@linaro.org> <0b052edd-99fe-fd68-fb19-6d295c4119e9@eldorado.org.br> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ze2ZXZtQqTKA6Iwf" Content-Disposition: inline In-Reply-To: <0b052edd-99fe-fd68-fb19-6d295c4119e9@eldorado.org.br> Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farosas@linux.ibm.com, Richard Henderson , qemu-devel@nongnu.org, Greg Kurz , lucas.araujo@eldorado.org.br, fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br, luis.pires@eldorado.org.br Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --ze2ZXZtQqTKA6Iwf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 15, 2021 at 09:25:06AM -0300, Bruno Piazera Larsen wrote: >=20 > On 15/06/2021 00:20, Richard Henderson wrote: > > On 6/14/21 6:41 PM, David Gibson wrote: > > > I think move these to mmu-book3s-v3.h, since they're correct for both > > > the radix and hash sides of the modern book3s mmu. > >=20 > > They're also correct for all non-booke mmus, e.g. hash32 and 6xx, which > > is why I recommended internal.h (or some new mmu-internal.h). > >=20 > > While neither hash32 nor 6xx have HV, and thus there is no second tlb > > bug, it would still be More Correct to use mmu_idx instead of direct > > references to msr_pr et al. > yeah, I agree that I should change the documentation. Before I send a new > version with everything corrected, I wanna make sure if I should leave th= em > in internal and use it for hash32 and 6xx MMUs, or do I put them in > mmu-book3s-v3.h, since only radix64 has that the bug? Put them in mmu-book3s-v3.h for the time being, we can move it later if it makes sense. I want to move to a mode model-first approach to the softmmu code, so I think of these values as logically per-MMU-style, even if they are the same in practice for many of them. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ze2ZXZtQqTKA6Iwf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmDJl00ACgkQbDjKyiDZ s5KjCRAAo+Y07B30qvrK9ArNYq0TnoeRKfk1XPVWO9uriX2EPkX6K3fFsGINDTMB kzJ/c/oyc0LPYcIsGI9t8qF1zZgjvUU4GsWxyI0jLTizYWUuRG6PUTtFaqbqXz5L Q6dZRbLq6jqJ59T0R60ou2oCHm09qtogTYPVImHJSuo4sExbqYpAEdDhw72yXR0I RCDfzOiyS6r+D12Wr7yAvAJ2I1x3xdgXAdgwvp0cqzhyMmN1eVcMi1YuO9xKlagp HCbjXnaApel02U/G8drAW3bU2kTlsjDg2EGTAGQ9xPcRwvl0+i3IGZ5L+VrriUPY 8tFrPv40Pp1nTD/0JTssPhtcnRzEaFpLa4gcqor9Sr2GzRpcLXxYbxwv6vWwMgij NPesueNTMN1TcxTII+b7DhjmPJa/IgH62m4PGjBgfZhm1P1KQyWHwwaI95eY0CQF QxHPzsMNePn1WxeJGSnlpYLgp5ms9DCTIIPLSL6rYL2xwmT7+S4KnH4mIFC9lQZK 4sfmCiApk3b08HCNQ0owB7cvsJVmSfCVXM7lmCFRWDf2A3omc4frT+0Zn5EglVno b3XEOuLIdTDsZOd5dvQt+e2bbr29FLwV3hbV2hRNgeeqKii0AF7DA40fARBw3EuE dnY6nd673oR3F6WFKSKLMNT+nqHzCJGwc9jyDDNxYhnkFEt64R8= =9aEG -----END PGP SIGNATURE----- --ze2ZXZtQqTKA6Iwf--