From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D0F8C11F64 for ; Mon, 28 Jun 2021 18:11:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1605861C6F for ; Mon, 28 Jun 2021 18:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231950AbhF1SOI (ORCPT ); Mon, 28 Jun 2021 14:14:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233615AbhF1SOE (ORCPT ); Mon, 28 Jun 2021 14:14:04 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A3D7C061767 for ; Mon, 28 Jun 2021 11:11:38 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id u190so16147992pgd.8 for ; Mon, 28 Jun 2021 11:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3CTgejj7lyDfhzX2dzFowMolpFgct9NOBpKU9MNvQtw=; b=Sc6OqygxSFouqdOlogrAUiHLeOwpITrPTjkw/k2XBGHIR+ewdts2BLoNOigqRunYY2 NQfK/sE2nm+OPBV+wUEon7YtBOPCs8oGY0fBiCUk9MwRI23Ywn7rQLdX7tC+JbwduDcI 8mWebW8GUvPLzfIeXg3Ys58oS241vhtkwLq8E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3CTgejj7lyDfhzX2dzFowMolpFgct9NOBpKU9MNvQtw=; b=tYo91aWc6qyl/l6Ntz6H8WFO3Sc/nv7+dzXGW6RAco5iIzxlCCKcN3Jvq0YMpsFI4a wBsZa7SGlzTrl9eLCBhsvraVS/cLpiRIm3fAo1+oOqHfml7IrqspK7l4r6Ct1o8OxfBt 7wqek2TcZa2kOIWngTlS7VWpSH+ZAo2McURgzAQXxFrYkkgaj08mrYlGCD1B6cWRE7PL GFtK1au0XMfLpHO4yP4VnSfqI9OHmzxRnL0N3nsy9+W2pY1ObfSvTLhRGuPCwZlIFPNO jsFxyTfKWmNmLhZ1GjqyMMl2nxQIi9QArz+Fu7XHpWg611iMl/+eHL0B+aq+dAGgiALu JmfQ== X-Gm-Message-State: AOAM530cN2Z0IeV+x94dN3wjKcAB4qIaEFQJKWOx3LKpMLevXgSsXPH2 uNjxwQjQlbBV9c8SikQbjs1xAA== X-Google-Smtp-Source: ABdhPJwDDSKq52s0pA5ZRq7/h6wngl4jVxfxRf//SwJNyTD1XT3Z5MwE0vonZHCEmP2mLfWZPTi04g== X-Received: by 2002:a62:174c:0:b029:30d:fab7:ef5a with SMTP id 73-20020a62174c0000b029030dfab7ef5amr923165pfx.75.1624903897438; Mon, 28 Jun 2021 11:11:37 -0700 (PDT) Received: from localhost ([2620:15c:202:201:df70:d2d8:b384:35cf]) by smtp.gmail.com with UTF8SMTPSA id x13sm15787159pjh.30.2021.06.28.11.11.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jun 2021 11:11:37 -0700 (PDT) Date: Mon, 28 Jun 2021 11:11:33 -0700 From: Matthias Kaehlcke To: Sibi Sankar Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org, swboyd@chromium.org Subject: Re: [PATCH 6/9] arm64: dts: qcom: sc7280: Update reserved memory map Message-ID: References: <1624564058-24095-1-git-send-email-sibis@codeaurora.org> <1624564058-24095-7-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1624564058-24095-7-git-send-email-sibis@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 25, 2021 at 01:17:35AM +0530, Sibi Sankar wrote: > Subject: arm64: dts: qcom: sc7280: Update reserved memory map That's very vague. Also personally I'm not a fan of patches that touch SoC and board files with a commit message that only mentions the SoC, as is frequently done for IDP boards. Why not split this in (at least) two, one for adding the missing memory regions to the SoC, and one for the IDP. > Add missing regions and remove unused regions from the reserved memory > map, as described in version 1. What is this 'version 1'? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DE57C11F64 for ; Mon, 28 Jun 2021 18:13:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDD4961C75 for ; Mon, 28 Jun 2021 18:13:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDD4961C75 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U8a0ZoCKw1MHQnQIsoJox2LlMP0rLuUrFWCqw4b0v94=; b=xqwyOlCBKoGiRw /ZmZCHGQYCl8Y64grwkPh9dJ9rw/vI5UHs/4jtsuuOTe43HYdZNB8mKgA7fY5jeW9E8euSK23+VFH HzZ6zBEJVXtKQ8YKxWqL29ufe8slDmA5Ohrx8B9H1oKWqJ5VXOLYsy4eO2hWxIyrWILECZbNI9r1n pRhJKzSZ2zYi0/quwpDLwJST2345iHmuOCn5/mKjorWsEje3OhK7nCAQap5BV5/Yx50tUT2qL5LKL jVYfpnGlsIHNEn13Xdns1hzvOX9hWXe/RW0P8CwxA+RP+pDgCBEieZq1P+L0luUu+QlbVLMUEpVfZ sBY5x+wQ+WaTlSYch09A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxvjU-008sT0-5d; Mon, 28 Jun 2021 18:11:44 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxvjP-008sSC-7C for linux-arm-kernel@lists.infradead.org; Mon, 28 Jun 2021 18:11:41 +0000 Received: by mail-pg1-x52a.google.com with SMTP id u14so9665054pga.11 for ; Mon, 28 Jun 2021 11:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3CTgejj7lyDfhzX2dzFowMolpFgct9NOBpKU9MNvQtw=; b=Sc6OqygxSFouqdOlogrAUiHLeOwpITrPTjkw/k2XBGHIR+ewdts2BLoNOigqRunYY2 NQfK/sE2nm+OPBV+wUEon7YtBOPCs8oGY0fBiCUk9MwRI23Ywn7rQLdX7tC+JbwduDcI 8mWebW8GUvPLzfIeXg3Ys58oS241vhtkwLq8E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3CTgejj7lyDfhzX2dzFowMolpFgct9NOBpKU9MNvQtw=; b=IktSqtC0SNwQ2m3myKqe5lIQRzcfkv1eVanpdvy383n5cFQj6cxR9ktu0ueLtQxvXe /HRi7day4ysjlEFUuP12YyZ+jX7ZNLQvlKKQZ6O0IfmFzEuBLBJ828Ai4PH7pOL8eY35 pTWtVupYdZ1uWMQnU/z72L/hgQJqCjRV4vMo8RH7N8UW4xaAJWfUJZTid5mXK7Z3WCqO 3yLaCtOPrGOtvRRphxe7T/7SwQkD5ckWmkutTz53/Xoj+XcttmtcP4qN88V9DPPmeipR JDA/RUrzyFi/YaUt1nYGt4HeEgKbUZBb+2el+/ew1TdNd0p17e3h8qaLy5hW+9cnKOHU zHkA== X-Gm-Message-State: AOAM531Rt548XE6v8hSxfW2QEDbr49Cc4UrQyZw0hU1eU97mKspWEyK4 oIFlIhDRdhIpm//SKaHGIjTxCQ== X-Google-Smtp-Source: ABdhPJwDDSKq52s0pA5ZRq7/h6wngl4jVxfxRf//SwJNyTD1XT3Z5MwE0vonZHCEmP2mLfWZPTi04g== X-Received: by 2002:a62:174c:0:b029:30d:fab7:ef5a with SMTP id 73-20020a62174c0000b029030dfab7ef5amr923165pfx.75.1624903897438; Mon, 28 Jun 2021 11:11:37 -0700 (PDT) Received: from localhost ([2620:15c:202:201:df70:d2d8:b384:35cf]) by smtp.gmail.com with UTF8SMTPSA id x13sm15787159pjh.30.2021.06.28.11.11.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jun 2021 11:11:37 -0700 (PDT) Date: Mon, 28 Jun 2021 11:11:33 -0700 From: Matthias Kaehlcke To: Sibi Sankar Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org, swboyd@chromium.org Subject: Re: [PATCH 6/9] arm64: dts: qcom: sc7280: Update reserved memory map Message-ID: References: <1624564058-24095-1-git-send-email-sibis@codeaurora.org> <1624564058-24095-7-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1624564058-24095-7-git-send-email-sibis@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210628_111139_301259_C3C364E9 X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 25, 2021 at 01:17:35AM +0530, Sibi Sankar wrote: > Subject: arm64: dts: qcom: sc7280: Update reserved memory map That's very vague. Also personally I'm not a fan of patches that touch SoC and board files with a commit message that only mentions the SoC, as is frequently done for IDP boards. Why not split this in (at least) two, one for adding the missing memory regions to the SoC, and one for the IDP. > Add missing regions and remove unused regions from the reserved memory > map, as described in version 1. What is this 'version 1'? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel