From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B1BC07E96 for ; Tue, 6 Jul 2021 12:54:42 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD6F4619AC for ; Tue, 6 Jul 2021 12:54:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD6F4619AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GK2ZS3ln0z3f5j for ; Tue, 6 Jul 2021 22:54:40 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=heikki.krogerus@linux.intel.com; receiver=) X-Greylist: delayed 124 seconds by postgrey-1.36 at boromir; Tue, 06 Jul 2021 21:45:27 AEST Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GK12b4HFbz2yNf for ; Tue, 6 Jul 2021 21:45:27 +1000 (AEST) X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="272945357" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="272945357" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 04:42:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="562991774" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 06 Jul 2021 04:41:40 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 06 Jul 2021 14:41:39 +0300 Date: Tue, 6 Jul 2021 14:41:39 +0300 From: Heikki Krogerus To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] bus: Make remove callback return void Message-ID: References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> X-Mailman-Approved-At: Tue, 06 Jul 2021 22:48:04 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alison Schofield , Alexander Shishkin , Samuel Iglesias Gonsalvez , Jens Taprogge , Alexandre Belloni , "James E.J. Bottomley" , Benjamin Tissoires , Paul Mackerras , Srinivas Pandruvada , "K. Y. Srinivasan" , Ira Weiny , Wei Liu , Alex Dubov , Dave Jiang , Maxim Levitsky , Johannes Thumshirn , Vishal Verma , Helge Deller , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Dexuan Cui , Russell King , Jernej Skrabec , Chen-Yu Tsai , Tom Rix , Len Brown , Jiri Kosina , Haiyang Zhang , Sudeep Holla , William Breathitt Gray , Maxime Ripard , Ben Widawsky , Moritz Fischer , Stephen Hemminger , Dan Williams , Mauro Carvalho Chehab , Cristian Marussi , Thomas Bogendoerfer , Geoff Levand , Greg Kroah-Hartman , Dmitry Torokhov , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Wolfram Sang , Vinod Koul , Stefan Richter , kernel@pengutronix.de, Wu Hao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-König For ulpi and typec: Acked-by: Heikki Krogerus thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42144C07E96 for ; Thu, 8 Jul 2021 10:07:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 933E861955 for ; Thu, 8 Jul 2021 10:07:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 933E861955 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1F8D91614; Thu, 8 Jul 2021 12:06:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1F8D91614 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1625738822; bh=tnfX0qQGPCPMxBGdPonzbGA1T2X52E/rJTKcj3RX4A4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dTENy22GblseSO+JwGt7pguL82vpFzGqqbeNA+LAC74XnSltOpBDBc68iKQuCYo54 1FRU50bFWCR+xoXdPP58ZXQa3jsTbAHx4QULPQ1JXFL8lgNpD553j+GdkTmK7OPf4j B6RUCnmRSrxvsALHaP5xnQMYrvKAYdSNMEjZk9cQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 99581F804E1; Thu, 8 Jul 2021 12:04:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CCC79F80249; Tue, 6 Jul 2021 13:42:27 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5DADCF8014E for ; Tue, 6 Jul 2021 13:42:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5DADCF8014E X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="272945353" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="272945353" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 04:42:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="562991774" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 06 Jul 2021 04:41:40 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 06 Jul 2021 14:41:39 +0300 Date: Tue, 6 Jul 2021 14:41:39 +0300 From: Heikki Krogerus To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] bus: Make remove callback return void Message-ID: References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> X-Mailman-Approved-At: Thu, 08 Jul 2021 12:04:25 +0200 Cc: Alison Schofield , Alexander Shishkin , Benjamin Herrenschmidt , Samuel Iglesias Gonsalvez , "Dubov , Alexandre Belloni , "James E.J. Bottomley" , Benjamin Tissoires , Paul Mackerras , Srinivas Pandruvada , "K. Y. Srinivasan" , Ira Weiny , Wei Liu , Dave Jiang , Maxim Levitsky , Johannes Thumshirn , Vishal Verma , Helge Deller , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Dexuan Cui , Russell King , Jernej Skrabec , Chen-Yu Tsai , Alex@alsa-project.org, Tom Rix , Len Brown , Jiri Kosina , Haiyang Zhang , Sudeep Holla , William Breathitt Gray , Maxime Ripard , Ben Widawsky , Moritz Fischer , Stephen Hemminger , Dan Williams , Mauro Carvalho Chehab , Cristian Marussi , Thomas Bogendoerfer , Geoff Levand , Greg Kroah-Hartman , Dmitry Torokhov , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Wolfram Sang , Vinod Koul , Stefan Richter , kernel@pengutronix.de, Michael Ellerman , Wu Hao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-König For ulpi and typec: Acked-by: Heikki Krogerus thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6981749566085267456 X-Received: by 2002:a63:5059:: with SMTP id q25mr10150510pgl.9.1625571735913; Tue, 06 Jul 2021 04:42:15 -0700 (PDT) X-BeenThere: linux-ntb@googlegroups.com Received: by 2002:a17:902:968c:: with SMTP id n12ls10750175plp.8.gmail; Tue, 06 Jul 2021 04:42:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyf4Q9EcXnFchcNvrHU7Iwph4Ga5L2n+hDJZULyDmFYcD9xdXRPX7ZcLPoC1WfleFHukkUv X-Received: by 2002:a17:90a:9914:: with SMTP id b20mr5532954pjp.112.1625571735240; Tue, 06 Jul 2021 04:42:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625571735; cv=none; d=google.com; s=arc-20160816; b=M5jyoX61MUv7ZhWJS6FHQ/vcY7L9Woidh/LmjIrWSChwjuMlLXD1e2QAb2DuFylw+U chskTg/CGccsmP3YyNyoJBLpzK0CtCXW9vwmg/u1JL7or11EOuVQKSK5pNxAXv87q96w R1TuI2JSfgTGBChqlqFu3+QeYoQWV134Zr9UdsTaP/VbYFAyPLBMUnAFVbJCZJee08Aq zUg2fwX/1PPl8U1vcRrjyFGyRWCO7L60qu1hXbHwPO2tF0aRDdiYvQE4sinMTBJf3h8w daYyEKjXhvWVtrgnoL7cSP6vpEZAiPQfsFQLkPa29jV4NGByDE4RUmWmv/pV/OmiDQ0d lIRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=V/RGub/1UxFQNrHXKd+7o8uYVkmOmP9DJ2TlidSApMc=; b=gH66UTaUjAy9C82eXI0JrB3HD7Rb17k24UtILF+JR23/CIvv/0W4sHecYQv2SZ7Ves wPf2+Wy5nuokQ45Ncs1vHf1eQKR3l1JhCqp5EswHluxra2J4IfQrk+IuVlLhTuCFwIwx KmX63RFbzS7jZF2RH6HbwZwj/bGDJRLA956WyEIkBko0E4eD4yxnZAD+ark5MY9k6g6v a6w1LB1UzJ7V6kIV+qLuLMQ5kgZS9ddWC+fgcFUb6+98BW9wlRQ5xgxqhYeeuAR4obSw Tm58NBHZFS5WxNafKwcxytQxiyZOilwBEbcTKP0n22mTIwbVfAjvfWW8OI/QN7kl+lN6 XImg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of heikki.krogerus@linux.intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=heikki.krogerus@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from mga05.intel.com (mga05.intel.com. [192.55.52.43]) by gmr-mx.google.com with ESMTPS id o20si1960307pgv.1.2021.07.06.04.42.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Jul 2021 04:42:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of heikki.krogerus@linux.intel.com designates 192.55.52.43 as permitted sender) client-ip=192.55.52.43; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of heikki.krogerus@linux.intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=heikki.krogerus@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="294739854" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="294739854" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 04:42:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="562991774" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 06 Jul 2021 04:41:40 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 06 Jul 2021 14:41:39 +0300 Date: Tue, 6 Jul 2021 14:41:39 +0300 From: Heikki Krogerus To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Greg Kroah-Hartman , kernel@pengutronix.de, linux-kernel@vger.kernel.org, Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Geoff Levand , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Rafael J. Wysocki" , Len Brown , William Breathitt Gray , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , Dan Williams , Dave Jiang , Vinod Koul , Stefan Richter , Sudeep Holla , Cristian Marussi , Wu Hao , Tom Rix , Moritz Fischer , Jiri Kosina , Benjamin Tissoires , Srinivas Pandruvada , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Alexander Shishkin , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Samuel Iglesias Gonsalvez , Jens Taprogge , Johannes Thumshirn , Mauro Carvalho Chehab , Maxim Levitsky , Alex Dubov References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> X-Import-Rejected-Reason: No matching List-ID On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-K�nig wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-K�nig For ulpi and typec: Acked-by: Heikki Krogerus thanks, -- heikki