From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E84C07E9E for ; Tue, 6 Jul 2021 20:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45AC561C85 for ; Tue, 6 Jul 2021 20:43:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbhGFUqF (ORCPT ); Tue, 6 Jul 2021 16:46:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbhGFUqE (ORCPT ); Tue, 6 Jul 2021 16:46:04 -0400 Received: from mail-oo1-xc31.google.com (mail-oo1-xc31.google.com [IPv6:2607:f8b0:4864:20::c31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25059C061762 for ; Tue, 6 Jul 2021 13:43:25 -0700 (PDT) Received: by mail-oo1-xc31.google.com with SMTP id o3-20020a4a84c30000b0290251d599f19bso2953489oog.8 for ; Tue, 06 Jul 2021 13:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pxMY07o9eA6SvMdwqfO/Cy/RP18zRy8WHvKUzTEaaNE=; b=cMEULcwqLZ1Wut54PhoGe8eWn9DWOkTBGefRRfl5OdVDl+rs626G5wMaH28cgDjzcy C3SrxS4IBWN9GT87WmK8g47N1LXQplCWDOfx8int0/GS3k/x/nkilLmTHNlFEJRG7MNd XBIkEEXZ1pU0eRvjS1TRSvA1B76ydqAA34SpYmKB2ihzHjiFB86o3rkOkpvBUwbSv3hH SAJ7sWW3535WnApBT/aqgm8mqOlZd3rAIlZ18pf5XSKHOT2S+byWJIp1xZIbcvBH0etl zsjB18jSpkL6JUn2+voD9bKAbUaWuj/V1AbjBFUkZHMHiCqgtvfqmj4sQqDjclnu51kM rRng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pxMY07o9eA6SvMdwqfO/Cy/RP18zRy8WHvKUzTEaaNE=; b=jTntgODWg42Ecgiws9pdULvUTOFhnCnAuvSzgqfn0+MtMASjvUBnI09Cb7Gbu8YPKG 5+WBzBbsKFqVPPBdT30T5bKHFJn7rqNpaiJ6VwM7rI4ocOWzm+0pe76u2eeo/f2N526+ sOSi3niiiq0Kc/jKIAi5L00ki1rL2D30k+1Qlt3S0PEW3NO92HZQ3wrfdVEy9HKFuu7K eOB0IvVI4iD0yr3scMYQDV38X5YQnBH1XqYi0egqVzkQgOMP4fhaccELFvYi9pkpo9qh 6ahhSM2LI6n1fAFz2ibqrJ5Ic8tW7VLJ3xTF5NJw2Qeq/5EixPeR2crqu0zMxCPd/F2d OzKQ== X-Gm-Message-State: AOAM533NIvEA9ZZANETxrov8LsmLm3uDdm5P5w77TwudHgJ4/VhupmYS 6BnMZByBNfjGRltA/6PwgZyW3Q== X-Google-Smtp-Source: ABdhPJxDvDPv3ADYsyyhWPVlnzb7CaqMGlOMdSkFiej4dUoXbTCedb2luVlDDH/zGyqw6KpVymfMhg== X-Received: by 2002:a4a:d6cc:: with SMTP id j12mr2894172oot.0.1625604204373; Tue, 06 Jul 2021 13:43:24 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id x130sm1332892oix.22.2021.07.06.13.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 13:43:23 -0700 (PDT) Date: Tue, 6 Jul 2021 15:43:21 -0500 From: Bjorn Andersson To: Uwe Kleine-K?nig Cc: nvdimm@lists.linux.dev, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, linux-wireless@vger.kernel.org, linux-fpga@vger.kernel.org, linux-pci@vger.kernel.org, alsa-devel@alsa-project.org, linux-cxl@vger.kernel.org, platform-driver-x86@vger.kernel.org, target-devel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, linux-acpi@vger.kernel.org, industrypack-devel@lists.sourceforge.net, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-remoteproc@vger.kernel.org, greybus-dev@lists.linaro.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mips@vger.kernel.org, linux-spi@vger.kernel.org, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-ntb@googlegroups.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 4/4] bus: Make remove callback return void Message-ID: References: <20210706154803.1631813-1-u.kleine-koenig@pengutronix.de> <20210706154803.1631813-5-u.kleine-koenig@pengutronix.de> <20210706184323.fudcbsiu4i34dojs@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210706184323.fudcbsiu4i34dojs@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue 06 Jul 13:43 CDT 2021, Uwe Kleine-K?nig wrote: > Hello Bjorn, > > On Tue, Jul 06, 2021 at 01:08:18PM -0500, Bjorn Andersson wrote: > > On Tue 06 Jul 10:48 CDT 2021, Uwe Kleine-K?nig wrote: > > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > > > index c1404d3dae2c..7f6fac618ab2 100644 > > > --- a/drivers/rpmsg/rpmsg_core.c > > > +++ b/drivers/rpmsg/rpmsg_core.c > > > @@ -530,7 +530,7 @@ static int rpmsg_dev_probe(struct device *dev) > > > return err; > > > } > > > > > > -static int rpmsg_dev_remove(struct device *dev) > > > +static void rpmsg_dev_remove(struct device *dev) > > > { > > > struct rpmsg_device *rpdev = to_rpmsg_device(dev); > > > struct rpmsg_driver *rpdrv = to_rpmsg_driver(rpdev->dev.driver); > > > @@ -546,8 +546,6 @@ static int rpmsg_dev_remove(struct device *dev) > > > > > > if (rpdev->ept) > > > rpmsg_destroy_ept(rpdev->ept); > > > - > > > - return err; > > > > This leaves err assigned but never used, but I don't mind following up > > with a patch cleaning that up after this has landed. > > Ah, good catch. If I send out a v3 I will fold the following into this > patch: > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 7f6fac618ab2..9151836190ce 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -534,10 +534,9 @@ static void rpmsg_dev_remove(struct device *dev) > { > struct rpmsg_device *rpdev = to_rpmsg_device(dev); > struct rpmsg_driver *rpdrv = to_rpmsg_driver(rpdev->dev.driver); > - int err = 0; > > if (rpdev->ops->announce_destroy) > - err = rpdev->ops->announce_destroy(rpdev); > + rpdev->ops->announce_destroy(rpdev); > > if (rpdrv->remove) > rpdrv->remove(rpdev); > Sounds good, feel free to keep my ack on this. > Maybe .announce_destroy() should then be changed to return void, too? > Something like: > Yes, I saw this opportunity as well. But that will fan out further, so let's postpone that until your series has landed and we can follow up with such changes through the remoteproc tree. > diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h > index a76c344253bf..d5204756714c 100644 > --- a/drivers/rpmsg/rpmsg_internal.h > +++ b/drivers/rpmsg/rpmsg_internal.h > @@ -40,7 +40,7 @@ struct rpmsg_device_ops { > struct rpmsg_channel_info chinfo); > > int (*announce_create)(struct rpmsg_device *ept); > - int (*announce_destroy)(struct rpmsg_device *ept); > + void (*announce_destroy)(struct rpmsg_device *ept); > }; > > /** > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 8e49a3bacfc7..4e05994634f8 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -340,7 +340,7 @@ static int virtio_rpmsg_announce_create(struct rpmsg_device *rpdev) > return err; > } > > -static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > +static void virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > { > struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev); > struct virtproc_info *vrp = vch->vrp; > @@ -360,8 +360,6 @@ static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > if (err) > dev_err(dev, "failed to announce service %d\n", err); > } > - > - return err; > } > > static const struct rpmsg_device_ops virtio_rpmsg_ops = { > > though it's not obvious for me that the last hunk is sensible. (OTOH the > return code is ignored anyhow as rpmsg_dev_remove() is the only caller. > I need to backtrack a little bit more to figure out why we ended up with this... Thanks, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D34F7C07E9E for ; Tue, 6 Jul 2021 20:43:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A21FA61C81 for ; Tue, 6 Jul 2021 20:43:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A21FA61C81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QwyvZlXj/k6dCU9wTTsdm9bZ5PPyfPkFj7VzXw1qhqI=; b=Pwlr/3zs1c/gVK M4qQtVikHJTMBbNIRWycF7jv0+bT9WpEzKzUEEm2KQSggp0uIZXGxu6dtY0O3Imtsr27gomBztlTH WLYSZvp37dA5CeS6dt7fip86ccmk+hC/56QNCBvDyhNfg7flMf8xfTYC/MBmQKp0WuKsuYRZatttj 2w6d4+EfEcvUtzOIH8kF8f6PqFi7Zmw/xI10VALzDarwj524QeiJWI3S7T1wlZEKjuVD3XiWIq6jJ BRlOXUjx/+eV/gXRKMzWCYRBny31v+LNy61HneFOwTe6RMXLLoXmKuOgIhV3/DRk+gCLbPstMBGH+ QkUVWbC0VdzLJemRr4CA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0rus-00Co61-W1; Tue, 06 Jul 2021 20:43:39 +0000 Received: from mail-oo1-xc30.google.com ([2607:f8b0:4864:20::c30]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0ruf-00Co3V-CF for linux-i3c@lists.infradead.org; Tue, 06 Jul 2021 20:43:27 +0000 Received: by mail-oo1-xc30.google.com with SMTP id 68-20020a4a00470000b0290258a7ff4058so1432288ooh.10 for ; Tue, 06 Jul 2021 13:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pxMY07o9eA6SvMdwqfO/Cy/RP18zRy8WHvKUzTEaaNE=; b=cMEULcwqLZ1Wut54PhoGe8eWn9DWOkTBGefRRfl5OdVDl+rs626G5wMaH28cgDjzcy C3SrxS4IBWN9GT87WmK8g47N1LXQplCWDOfx8int0/GS3k/x/nkilLmTHNlFEJRG7MNd XBIkEEXZ1pU0eRvjS1TRSvA1B76ydqAA34SpYmKB2ihzHjiFB86o3rkOkpvBUwbSv3hH SAJ7sWW3535WnApBT/aqgm8mqOlZd3rAIlZ18pf5XSKHOT2S+byWJIp1xZIbcvBH0etl zsjB18jSpkL6JUn2+voD9bKAbUaWuj/V1AbjBFUkZHMHiCqgtvfqmj4sQqDjclnu51kM rRng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pxMY07o9eA6SvMdwqfO/Cy/RP18zRy8WHvKUzTEaaNE=; b=ahlnXvXMk8q4A4WojUKdVygt2Np9IhoTbnafE6WzGghJdvpzlYGmMTFoN+UXlk58NN cyqqZgcS6CG5+HGOpbcGzY5OKI0VlzY4U1KCy0juqnGuLgYWB2l2hlYXCK4msPSBUsfy ZYVH8gw+o6Yc47x9vd3Y0ZeLK/BLcSurf+4gkzAysQTXoKHSNie7bLFQHGWhVQ7JZ+pS nsUy58zsEHGlM+y0Bi57tg4W6x+vsj3hkqCJjZCYNu3tovPTV9f4kzBejSrBJQ2PkDtX OB0Ytw4zaxN5RVU/3yJk1Kgr+kFaJB1agWvRX+O2EJHDz+hjGOYB8laKCxP+9V5VdhnK HdWw== X-Gm-Message-State: AOAM533yx58k7HwY2g8uBsujxflXIfK8x2ZDlN6jM715WFQL9+98P+Qv OK7qnDZhhzr48/hhzvr3mIXuuQ== X-Google-Smtp-Source: ABdhPJxDvDPv3ADYsyyhWPVlnzb7CaqMGlOMdSkFiej4dUoXbTCedb2luVlDDH/zGyqw6KpVymfMhg== X-Received: by 2002:a4a:d6cc:: with SMTP id j12mr2894172oot.0.1625604204373; Tue, 06 Jul 2021 13:43:24 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id x130sm1332892oix.22.2021.07.06.13.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 13:43:23 -0700 (PDT) Date: Tue, 6 Jul 2021 15:43:21 -0500 From: Bjorn Andersson To: Uwe Kleine-K?nig Cc: nvdimm@lists.linux.dev, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, linux-wireless@vger.kernel.org, linux-fpga@vger.kernel.org, linux-pci@vger.kernel.org, alsa-devel@alsa-project.org, linux-cxl@vger.kernel.org, platform-driver-x86@vger.kernel.org, target-devel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, linux-acpi@vger.kernel.org, industrypack-devel@lists.sourceforge.net, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-remoteproc@vger.kernel.org, greybus-dev@lists.linaro.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mips@vger.kernel.org, linux-spi@vger.kernel.org, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-ntb@googlegroups.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 4/4] bus: Make remove callback return void Message-ID: References: <20210706154803.1631813-1-u.kleine-koenig@pengutronix.de> <20210706154803.1631813-5-u.kleine-koenig@pengutronix.de> <20210706184323.fudcbsiu4i34dojs@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210706184323.fudcbsiu4i34dojs@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210706_134325_485895_D50E53E5 X-CRM114-Status: GOOD ( 23.47 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Tue 06 Jul 13:43 CDT 2021, Uwe Kleine-K?nig wrote: > Hello Bjorn, > > On Tue, Jul 06, 2021 at 01:08:18PM -0500, Bjorn Andersson wrote: > > On Tue 06 Jul 10:48 CDT 2021, Uwe Kleine-K?nig wrote: > > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > > > index c1404d3dae2c..7f6fac618ab2 100644 > > > --- a/drivers/rpmsg/rpmsg_core.c > > > +++ b/drivers/rpmsg/rpmsg_core.c > > > @@ -530,7 +530,7 @@ static int rpmsg_dev_probe(struct device *dev) > > > return err; > > > } > > > > > > -static int rpmsg_dev_remove(struct device *dev) > > > +static void rpmsg_dev_remove(struct device *dev) > > > { > > > struct rpmsg_device *rpdev = to_rpmsg_device(dev); > > > struct rpmsg_driver *rpdrv = to_rpmsg_driver(rpdev->dev.driver); > > > @@ -546,8 +546,6 @@ static int rpmsg_dev_remove(struct device *dev) > > > > > > if (rpdev->ept) > > > rpmsg_destroy_ept(rpdev->ept); > > > - > > > - return err; > > > > This leaves err assigned but never used, but I don't mind following up > > with a patch cleaning that up after this has landed. > > Ah, good catch. If I send out a v3 I will fold the following into this > patch: > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 7f6fac618ab2..9151836190ce 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -534,10 +534,9 @@ static void rpmsg_dev_remove(struct device *dev) > { > struct rpmsg_device *rpdev = to_rpmsg_device(dev); > struct rpmsg_driver *rpdrv = to_rpmsg_driver(rpdev->dev.driver); > - int err = 0; > > if (rpdev->ops->announce_destroy) > - err = rpdev->ops->announce_destroy(rpdev); > + rpdev->ops->announce_destroy(rpdev); > > if (rpdrv->remove) > rpdrv->remove(rpdev); > Sounds good, feel free to keep my ack on this. > Maybe .announce_destroy() should then be changed to return void, too? > Something like: > Yes, I saw this opportunity as well. But that will fan out further, so let's postpone that until your series has landed and we can follow up with such changes through the remoteproc tree. > diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h > index a76c344253bf..d5204756714c 100644 > --- a/drivers/rpmsg/rpmsg_internal.h > +++ b/drivers/rpmsg/rpmsg_internal.h > @@ -40,7 +40,7 @@ struct rpmsg_device_ops { > struct rpmsg_channel_info chinfo); > > int (*announce_create)(struct rpmsg_device *ept); > - int (*announce_destroy)(struct rpmsg_device *ept); > + void (*announce_destroy)(struct rpmsg_device *ept); > }; > > /** > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 8e49a3bacfc7..4e05994634f8 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -340,7 +340,7 @@ static int virtio_rpmsg_announce_create(struct rpmsg_device *rpdev) > return err; > } > > -static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > +static void virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > { > struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev); > struct virtproc_info *vrp = vch->vrp; > @@ -360,8 +360,6 @@ static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > if (err) > dev_err(dev, "failed to announce service %d\n", err); > } > - > - return err; > } > > static const struct rpmsg_device_ops virtio_rpmsg_ops = { > > though it's not obvious for me that the last hunk is sensible. (OTOH the > return code is ignored anyhow as rpmsg_dev_remove() is the only caller. > I need to backtrack a little bit more to figure out why we ended up with this... Thanks, Bjorn -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28F4C07E9C for ; Tue, 6 Jul 2021 20:43:29 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77EF861C98 for ; Tue, 6 Jul 2021 20:43:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77EF861C98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2F064401E4; Tue, 6 Jul 2021 20:43:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0GOJTUUz-pTl; Tue, 6 Jul 2021 20:43:28 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id B830B401CF; Tue, 6 Jul 2021 20:43:27 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 89981C001A; Tue, 6 Jul 2021 20:43:27 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3E7B7C000E for ; Tue, 6 Jul 2021 20:43:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2D72F401E3 for ; Tue, 6 Jul 2021 20:43:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BBbQfRWVCXsR for ; Tue, 6 Jul 2021 20:43:25 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by smtp2.osuosl.org (Postfix) with ESMTPS id 58AF1401CF for ; Tue, 6 Jul 2021 20:43:25 +0000 (UTC) Received: by mail-oo1-xc32.google.com with SMTP id x139-20020a4a41910000b0290257bad81ed5so1743895ooa.3 for ; Tue, 06 Jul 2021 13:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pxMY07o9eA6SvMdwqfO/Cy/RP18zRy8WHvKUzTEaaNE=; b=cMEULcwqLZ1Wut54PhoGe8eWn9DWOkTBGefRRfl5OdVDl+rs626G5wMaH28cgDjzcy C3SrxS4IBWN9GT87WmK8g47N1LXQplCWDOfx8int0/GS3k/x/nkilLmTHNlFEJRG7MNd XBIkEEXZ1pU0eRvjS1TRSvA1B76ydqAA34SpYmKB2ihzHjiFB86o3rkOkpvBUwbSv3hH SAJ7sWW3535WnApBT/aqgm8mqOlZd3rAIlZ18pf5XSKHOT2S+byWJIp1xZIbcvBH0etl zsjB18jSpkL6JUn2+voD9bKAbUaWuj/V1AbjBFUkZHMHiCqgtvfqmj4sQqDjclnu51kM rRng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pxMY07o9eA6SvMdwqfO/Cy/RP18zRy8WHvKUzTEaaNE=; b=M6nv4hs7OHd1yOQDmFrdFPTEQvPEvPOB3jnbVqvEIkj7W/4eaZXYKVTlYgonC2TTUa sjXuS17y6xmM+ghh1ANhad8wr86XyJQRm8OIPvlOqvKw2u4dsR0wNOiLyY7/9GZE/fNe hlAMtppFm2VjOMO+ltWhyXniE/79+10YhG4uItJouH5YUTEfjiFw89+BS3p5fqqJvLJh 3+dt/KQgIXCvO08VMtlLsnzRHbLFK8/cgD7Bp90ktIioaz1RQAJbwA53qCKSik8l7mW8 5/K4VlOnHebzhbLyrzfkbqkz8XeuQceiXCICkOXe2NwLxw0GqV/8/jcucFcJN9U7Auk7 2jeA== X-Gm-Message-State: AOAM532IZO40OeBgJkmvTQSd8IrvNsaUoxDMkBkylokGWNfqqOzZvwmi AqObiN0OzubsGcftYBFbXOSRtw== X-Google-Smtp-Source: ABdhPJxDvDPv3ADYsyyhWPVlnzb7CaqMGlOMdSkFiej4dUoXbTCedb2luVlDDH/zGyqw6KpVymfMhg== X-Received: by 2002:a4a:d6cc:: with SMTP id j12mr2894172oot.0.1625604204373; Tue, 06 Jul 2021 13:43:24 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id x130sm1332892oix.22.2021.07.06.13.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 13:43:23 -0700 (PDT) Date: Tue, 6 Jul 2021 15:43:21 -0500 From: Bjorn Andersson To: Uwe Kleine-K?nig Subject: Re: [PATCH v2 4/4] bus: Make remove callback return void Message-ID: References: <20210706154803.1631813-1-u.kleine-koenig@pengutronix.de> <20210706154803.1631813-5-u.kleine-koenig@pengutronix.de> <20210706184323.fudcbsiu4i34dojs@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210706184323.fudcbsiu4i34dojs@pengutronix.de> Cc: nvdimm@lists.linux.dev, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org, linux-fpga@vger.kernel.org, linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, linux-cxl@vger.kernel.org, platform-driver-x86@vger.kernel.org, target-devel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, linux-acpi@vger.kernel.org, industrypack-devel@lists.sourceforge.net, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org, greybus-dev@lists.linaro.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-mips@vger.kernel.org, linux-spi@vger.kernel.org, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-ntb@googlegroups.com, linuxppc-dev@lists.ozlabs.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue 06 Jul 13:43 CDT 2021, Uwe Kleine-K?nig wrote: > Hello Bjorn, > > On Tue, Jul 06, 2021 at 01:08:18PM -0500, Bjorn Andersson wrote: > > On Tue 06 Jul 10:48 CDT 2021, Uwe Kleine-K?nig wrote: > > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > > > index c1404d3dae2c..7f6fac618ab2 100644 > > > --- a/drivers/rpmsg/rpmsg_core.c > > > +++ b/drivers/rpmsg/rpmsg_core.c > > > @@ -530,7 +530,7 @@ static int rpmsg_dev_probe(struct device *dev) > > > return err; > > > } > > > > > > -static int rpmsg_dev_remove(struct device *dev) > > > +static void rpmsg_dev_remove(struct device *dev) > > > { > > > struct rpmsg_device *rpdev = to_rpmsg_device(dev); > > > struct rpmsg_driver *rpdrv = to_rpmsg_driver(rpdev->dev.driver); > > > @@ -546,8 +546,6 @@ static int rpmsg_dev_remove(struct device *dev) > > > > > > if (rpdev->ept) > > > rpmsg_destroy_ept(rpdev->ept); > > > - > > > - return err; > > > > This leaves err assigned but never used, but I don't mind following up > > with a patch cleaning that up after this has landed. > > Ah, good catch. If I send out a v3 I will fold the following into this > patch: > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 7f6fac618ab2..9151836190ce 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -534,10 +534,9 @@ static void rpmsg_dev_remove(struct device *dev) > { > struct rpmsg_device *rpdev = to_rpmsg_device(dev); > struct rpmsg_driver *rpdrv = to_rpmsg_driver(rpdev->dev.driver); > - int err = 0; > > if (rpdev->ops->announce_destroy) > - err = rpdev->ops->announce_destroy(rpdev); > + rpdev->ops->announce_destroy(rpdev); > > if (rpdrv->remove) > rpdrv->remove(rpdev); > Sounds good, feel free to keep my ack on this. > Maybe .announce_destroy() should then be changed to return void, too? > Something like: > Yes, I saw this opportunity as well. But that will fan out further, so let's postpone that until your series has landed and we can follow up with such changes through the remoteproc tree. > diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h > index a76c344253bf..d5204756714c 100644 > --- a/drivers/rpmsg/rpmsg_internal.h > +++ b/drivers/rpmsg/rpmsg_internal.h > @@ -40,7 +40,7 @@ struct rpmsg_device_ops { > struct rpmsg_channel_info chinfo); > > int (*announce_create)(struct rpmsg_device *ept); > - int (*announce_destroy)(struct rpmsg_device *ept); > + void (*announce_destroy)(struct rpmsg_device *ept); > }; > > /** > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 8e49a3bacfc7..4e05994634f8 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -340,7 +340,7 @@ static int virtio_rpmsg_announce_create(struct rpmsg_device *rpdev) > return err; > } > > -static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > +static void virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > { > struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev); > struct virtproc_info *vrp = vch->vrp; > @@ -360,8 +360,6 @@ static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > if (err) > dev_err(dev, "failed to announce service %d\n", err); > } > - > - return err; > } > > static const struct rpmsg_device_ops virtio_rpmsg_ops = { > > though it's not obvious for me that the last hunk is sensible. (OTOH the > return code is ignored anyhow as rpmsg_dev_remove() is the only caller. > I need to backtrack a little bit more to figure out why we ended up with this... Thanks, Bjorn _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01759C07E96 for ; Tue, 6 Jul 2021 20:45:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCEF461C94 for ; Tue, 6 Jul 2021 20:45:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCEF461C94 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=agWn3xfymQz+N+Yz7o8wLq3DzUFu3pBEn5RiqG59qWA=; b=CjYZfK47MP7UAp duH3Mt5+5nUJ1qT/cbWlNxOCUQlB73G40REvqU1AYu6IS14V3VZkuV4CQsyIKy2eAwoWAkklWp0Lh HxnkQHDYaZCTrK50AZOlqXW/nrFsu41fw4wCgn+x/neywqKzi7dRQDd/o7HKzf8LazTcpOoElZ5fc +KFuVQj1vVZGmB5WBLZjFZJRLyCGArKdJ2BbviZO1mioKekItYIrLZ0PJ0LC+3hAWyREdbUslipF3 y1wpxxFW+gbur1XmYkEZ32JI+1qxl9N3dRoaOT9rprZRJxacI1S3qh+TmuXGE91OpkkVRXUZcVz9k Fb725xVYUC3rw4ob8m8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0ruj-00Co4U-Qr; Tue, 06 Jul 2021 20:43:30 +0000 Received: from mail-oo1-xc2c.google.com ([2607:f8b0:4864:20::c2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0ruf-00Co3U-CE for linux-arm-kernel@lists.infradead.org; Tue, 06 Jul 2021 20:43:27 +0000 Received: by mail-oo1-xc2c.google.com with SMTP id l26-20020a4ac61a0000b029024c94215d77so5576246ooq.11 for ; Tue, 06 Jul 2021 13:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pxMY07o9eA6SvMdwqfO/Cy/RP18zRy8WHvKUzTEaaNE=; b=cMEULcwqLZ1Wut54PhoGe8eWn9DWOkTBGefRRfl5OdVDl+rs626G5wMaH28cgDjzcy C3SrxS4IBWN9GT87WmK8g47N1LXQplCWDOfx8int0/GS3k/x/nkilLmTHNlFEJRG7MNd XBIkEEXZ1pU0eRvjS1TRSvA1B76ydqAA34SpYmKB2ihzHjiFB86o3rkOkpvBUwbSv3hH SAJ7sWW3535WnApBT/aqgm8mqOlZd3rAIlZ18pf5XSKHOT2S+byWJIp1xZIbcvBH0etl zsjB18jSpkL6JUn2+voD9bKAbUaWuj/V1AbjBFUkZHMHiCqgtvfqmj4sQqDjclnu51kM rRng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pxMY07o9eA6SvMdwqfO/Cy/RP18zRy8WHvKUzTEaaNE=; b=dDSQfVZks2GR3j2BGzRsBNhpFehi55+Xvkh20aND5vZ0GWc7/5QvwDOkYup+2v4pJr ZSFqbl0cNhQrnZC6mNrY/k8T1gRCTGaayn/8wHlVpu0F5UG1Xi4Xk+BsFC9OzZAhtQLP KM1BPN7h5Nu0TlgjSYWbdN56YIPcA69u//qp0JkpjvX8k3ZZmebbH9EpoKTR4+Whv33T kqQLQ/PdcDU3HWcSku4VQBy14bAlwdYD6lfws9SyklFNmZWwSw8rndJ98sDKp3onsnml 0BayCXtMZgALr98s2oBcj7uK6bUcD7bnXcN+Dzo6tjIuSSc7GU7nV2vKNNXEQ0xOJKB7 yBIw== X-Gm-Message-State: AOAM533ELU8fV69tsbBlzx4Vo2IVavReUFTikcE1BFRU41YVPYnucRMx ot5rnIgKwCNx27cP/1yImMyrCg== X-Google-Smtp-Source: ABdhPJxDvDPv3ADYsyyhWPVlnzb7CaqMGlOMdSkFiej4dUoXbTCedb2luVlDDH/zGyqw6KpVymfMhg== X-Received: by 2002:a4a:d6cc:: with SMTP id j12mr2894172oot.0.1625604204373; Tue, 06 Jul 2021 13:43:24 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id x130sm1332892oix.22.2021.07.06.13.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 13:43:23 -0700 (PDT) Date: Tue, 6 Jul 2021 15:43:21 -0500 From: Bjorn Andersson To: Uwe Kleine-K?nig Cc: nvdimm@lists.linux.dev, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, linux-wireless@vger.kernel.org, linux-fpga@vger.kernel.org, linux-pci@vger.kernel.org, alsa-devel@alsa-project.org, linux-cxl@vger.kernel.org, platform-driver-x86@vger.kernel.org, target-devel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, linux-acpi@vger.kernel.org, industrypack-devel@lists.sourceforge.net, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-remoteproc@vger.kernel.org, greybus-dev@lists.linaro.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mips@vger.kernel.org, linux-spi@vger.kernel.org, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-ntb@googlegroups.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 4/4] bus: Make remove callback return void Message-ID: References: <20210706154803.1631813-1-u.kleine-koenig@pengutronix.de> <20210706154803.1631813-5-u.kleine-koenig@pengutronix.de> <20210706184323.fudcbsiu4i34dojs@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210706184323.fudcbsiu4i34dojs@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210706_134325_484396_153AB7FC X-CRM114-Status: GOOD ( 24.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 06 Jul 13:43 CDT 2021, Uwe Kleine-K?nig wrote: > Hello Bjorn, > > On Tue, Jul 06, 2021 at 01:08:18PM -0500, Bjorn Andersson wrote: > > On Tue 06 Jul 10:48 CDT 2021, Uwe Kleine-K?nig wrote: > > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > > > index c1404d3dae2c..7f6fac618ab2 100644 > > > --- a/drivers/rpmsg/rpmsg_core.c > > > +++ b/drivers/rpmsg/rpmsg_core.c > > > @@ -530,7 +530,7 @@ static int rpmsg_dev_probe(struct device *dev) > > > return err; > > > } > > > > > > -static int rpmsg_dev_remove(struct device *dev) > > > +static void rpmsg_dev_remove(struct device *dev) > > > { > > > struct rpmsg_device *rpdev = to_rpmsg_device(dev); > > > struct rpmsg_driver *rpdrv = to_rpmsg_driver(rpdev->dev.driver); > > > @@ -546,8 +546,6 @@ static int rpmsg_dev_remove(struct device *dev) > > > > > > if (rpdev->ept) > > > rpmsg_destroy_ept(rpdev->ept); > > > - > > > - return err; > > > > This leaves err assigned but never used, but I don't mind following up > > with a patch cleaning that up after this has landed. > > Ah, good catch. If I send out a v3 I will fold the following into this > patch: > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 7f6fac618ab2..9151836190ce 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -534,10 +534,9 @@ static void rpmsg_dev_remove(struct device *dev) > { > struct rpmsg_device *rpdev = to_rpmsg_device(dev); > struct rpmsg_driver *rpdrv = to_rpmsg_driver(rpdev->dev.driver); > - int err = 0; > > if (rpdev->ops->announce_destroy) > - err = rpdev->ops->announce_destroy(rpdev); > + rpdev->ops->announce_destroy(rpdev); > > if (rpdrv->remove) > rpdrv->remove(rpdev); > Sounds good, feel free to keep my ack on this. > Maybe .announce_destroy() should then be changed to return void, too? > Something like: > Yes, I saw this opportunity as well. But that will fan out further, so let's postpone that until your series has landed and we can follow up with such changes through the remoteproc tree. > diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h > index a76c344253bf..d5204756714c 100644 > --- a/drivers/rpmsg/rpmsg_internal.h > +++ b/drivers/rpmsg/rpmsg_internal.h > @@ -40,7 +40,7 @@ struct rpmsg_device_ops { > struct rpmsg_channel_info chinfo); > > int (*announce_create)(struct rpmsg_device *ept); > - int (*announce_destroy)(struct rpmsg_device *ept); > + void (*announce_destroy)(struct rpmsg_device *ept); > }; > > /** > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 8e49a3bacfc7..4e05994634f8 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -340,7 +340,7 @@ static int virtio_rpmsg_announce_create(struct rpmsg_device *rpdev) > return err; > } > > -static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > +static void virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > { > struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev); > struct virtproc_info *vrp = vch->vrp; > @@ -360,8 +360,6 @@ static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > if (err) > dev_err(dev, "failed to announce service %d\n", err); > } > - > - return err; > } > > static const struct rpmsg_device_ops virtio_rpmsg_ops = { > > though it's not obvious for me that the last hunk is sensible. (OTOH the > return code is ignored anyhow as rpmsg_dev_remove() is the only caller. > I need to backtrack a little bit more to figure out why we ended up with this... Thanks, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5FDAC07E96 for ; Thu, 8 Jul 2021 10:17:32 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F8C261C17 for ; Thu, 8 Jul 2021 10:17:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F8C261C17 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DCC3F170B; Thu, 8 Jul 2021 12:16:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DCC3F170B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1625739450; bh=xZ0xx2p9M7WieWcBI2ispxcrD2KdLL4qYvHlRPmCK04=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NyOgBUvE127NR8W6dzQt/OuSPa0SZ6fk0jWvdGOONheCL8gvvYpTX2/OaElzhPPAW yxyj46qDdvmkieNr1zXigb+ZwcpT4zCAJcMG6vju+f8RbkPb9PqkCg3NkYahlbIlg1 vAiBRzWZXsQUIkaaqAqv7rQOur9eleWgN47wvIIM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3A6ADF805D6; Thu, 8 Jul 2021 12:04:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C286BF80249; Tue, 6 Jul 2021 22:43:31 +0200 (CEST) Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1BD25F8014E for ; Tue, 6 Jul 2021 22:43:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1BD25F8014E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cMEULcwq" Received: by mail-oo1-xc30.google.com with SMTP id e1-20020a0568200601b029024ea261f0ccso5320923oow.2 for ; Tue, 06 Jul 2021 13:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pxMY07o9eA6SvMdwqfO/Cy/RP18zRy8WHvKUzTEaaNE=; b=cMEULcwqLZ1Wut54PhoGe8eWn9DWOkTBGefRRfl5OdVDl+rs626G5wMaH28cgDjzcy C3SrxS4IBWN9GT87WmK8g47N1LXQplCWDOfx8int0/GS3k/x/nkilLmTHNlFEJRG7MNd XBIkEEXZ1pU0eRvjS1TRSvA1B76ydqAA34SpYmKB2ihzHjiFB86o3rkOkpvBUwbSv3hH SAJ7sWW3535WnApBT/aqgm8mqOlZd3rAIlZ18pf5XSKHOT2S+byWJIp1xZIbcvBH0etl zsjB18jSpkL6JUn2+voD9bKAbUaWuj/V1AbjBFUkZHMHiCqgtvfqmj4sQqDjclnu51kM rRng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pxMY07o9eA6SvMdwqfO/Cy/RP18zRy8WHvKUzTEaaNE=; b=P99u/VSFULqhQJGbIwfExHVztcjg65vxymFPk+zQ4A+DdiwEvkxDb8o6JJ6IBTy82T 6ZtX9HTI3TdbUEXjnCwyuNwZBNC9UwS+Wha7rb8RFM+62yKZ6TIFC6jCO2lIw7J6Ho7e 03cfXa1QRopYwf6Hp9xg62daPMJEWoAKvpiW2EA3vYStYYz+TDsFCTov9lkcYDHUy+pD JAXzEQ1nCJ08G+hl2ccK1+wGvg5Br7GQcBZnygP60SQVUhgZIHJDlr1+6NxENkoKT1nk 8hJISN3VYbUnlFhpL/hxkWhywryX6z3xGt+POwCfOR+ey+ufX08Lr3MKj626CmbylfHX tmww== X-Gm-Message-State: AOAM530+xXbpi2c2tw1Cl86gl+0BNFXajp5Mp7VsuRt38ClXhpxr1sYu LtyZqVde93vOkOgsBNlG0JfYVw== X-Google-Smtp-Source: ABdhPJxDvDPv3ADYsyyhWPVlnzb7CaqMGlOMdSkFiej4dUoXbTCedb2luVlDDH/zGyqw6KpVymfMhg== X-Received: by 2002:a4a:d6cc:: with SMTP id j12mr2894172oot.0.1625604204373; Tue, 06 Jul 2021 13:43:24 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id x130sm1332892oix.22.2021.07.06.13.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 13:43:23 -0700 (PDT) Date: Tue, 6 Jul 2021 15:43:21 -0500 From: Bjorn Andersson To: Uwe Kleine-K?nig Subject: Re: [PATCH v2 4/4] bus: Make remove callback return void Message-ID: References: <20210706154803.1631813-1-u.kleine-koenig@pengutronix.de> <20210706154803.1631813-5-u.kleine-koenig@pengutronix.de> <20210706184323.fudcbsiu4i34dojs@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210706184323.fudcbsiu4i34dojs@pengutronix.de> X-Mailman-Approved-At: Thu, 08 Jul 2021 12:04:25 +0200 Cc: nvdimm@lists.linux.dev, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org, linux-fpga@vger.kernel.org, linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, linux-cxl@vger.kernel.org, platform-driver-x86@vger.kernel.org, target-devel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, linux-acpi@vger.kernel.org, industrypack-devel@lists.sourceforge.net, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org, greybus-dev@lists.linaro.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-mips@vger.kernel.org, linux-spi@vger.kernel.org, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-ntb@googlegroups.com, linuxppc-dev@lists.ozlabs.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue 06 Jul 13:43 CDT 2021, Uwe Kleine-K?nig wrote: > Hello Bjorn, > > On Tue, Jul 06, 2021 at 01:08:18PM -0500, Bjorn Andersson wrote: > > On Tue 06 Jul 10:48 CDT 2021, Uwe Kleine-K?nig wrote: > > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > > > index c1404d3dae2c..7f6fac618ab2 100644 > > > --- a/drivers/rpmsg/rpmsg_core.c > > > +++ b/drivers/rpmsg/rpmsg_core.c > > > @@ -530,7 +530,7 @@ static int rpmsg_dev_probe(struct device *dev) > > > return err; > > > } > > > > > > -static int rpmsg_dev_remove(struct device *dev) > > > +static void rpmsg_dev_remove(struct device *dev) > > > { > > > struct rpmsg_device *rpdev = to_rpmsg_device(dev); > > > struct rpmsg_driver *rpdrv = to_rpmsg_driver(rpdev->dev.driver); > > > @@ -546,8 +546,6 @@ static int rpmsg_dev_remove(struct device *dev) > > > > > > if (rpdev->ept) > > > rpmsg_destroy_ept(rpdev->ept); > > > - > > > - return err; > > > > This leaves err assigned but never used, but I don't mind following up > > with a patch cleaning that up after this has landed. > > Ah, good catch. If I send out a v3 I will fold the following into this > patch: > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 7f6fac618ab2..9151836190ce 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -534,10 +534,9 @@ static void rpmsg_dev_remove(struct device *dev) > { > struct rpmsg_device *rpdev = to_rpmsg_device(dev); > struct rpmsg_driver *rpdrv = to_rpmsg_driver(rpdev->dev.driver); > - int err = 0; > > if (rpdev->ops->announce_destroy) > - err = rpdev->ops->announce_destroy(rpdev); > + rpdev->ops->announce_destroy(rpdev); > > if (rpdrv->remove) > rpdrv->remove(rpdev); > Sounds good, feel free to keep my ack on this. > Maybe .announce_destroy() should then be changed to return void, too? > Something like: > Yes, I saw this opportunity as well. But that will fan out further, so let's postpone that until your series has landed and we can follow up with such changes through the remoteproc tree. > diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h > index a76c344253bf..d5204756714c 100644 > --- a/drivers/rpmsg/rpmsg_internal.h > +++ b/drivers/rpmsg/rpmsg_internal.h > @@ -40,7 +40,7 @@ struct rpmsg_device_ops { > struct rpmsg_channel_info chinfo); > > int (*announce_create)(struct rpmsg_device *ept); > - int (*announce_destroy)(struct rpmsg_device *ept); > + void (*announce_destroy)(struct rpmsg_device *ept); > }; > > /** > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 8e49a3bacfc7..4e05994634f8 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -340,7 +340,7 @@ static int virtio_rpmsg_announce_create(struct rpmsg_device *rpdev) > return err; > } > > -static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > +static void virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > { > struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev); > struct virtproc_info *vrp = vch->vrp; > @@ -360,8 +360,6 @@ static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev) > if (err) > dev_err(dev, "failed to announce service %d\n", err); > } > - > - return err; > } > > static const struct rpmsg_device_ops virtio_rpmsg_ops = { > > though it's not obvious for me that the last hunk is sensible. (OTOH the > return code is ignored anyhow as rpmsg_dev_remove() is the only caller. > I need to backtrack a little bit more to figure out why we ended up with this... Thanks, Bjorn